mbox series

[00/17] acpi:pc/q35: minor PCI refactoring/cleanups

Message ID 20220701133515.137890-1-imammedo@redhat.com
Headers show
Series acpi:pc/q35: minor PCI refactoring/cleanups | expand

Message

Igor Mammedov July 1, 2022, 1:34 p.m. UTC
Flushing out ACPI PCI cleanups that preceed conversion of
DSDT PCI slots ennumeration to AcpiDevAmlIf interface.
It's is mostly collection of patches thraet removes code
duplication, we've accumulated around PCI relaterd AML
in DSDT.

git:
   https://gitlab.com/imammedo/qemu.git x86_pci_cleanups

Igor Mammedov (17):
  tests: acpi: whitelist pc/q35 DSDT due to HPET AML move
  acpi: x86: deduplicate HPET AML building
  tests: acpi: update expected blobs after HPET move
  tests: acpi: whitelist pc/q35 DSDT due to HPET AML move
  acpi: x86: refactor PDSM method to reduce nesting
  x86: acpi: _DSM: use Package to pass parameters
  tests: acpi: update expected blobs
  tests: acpi: whitelist pc/q35 DSDT before switching _DSM to use ASUN
  x86: acpi: cleanup PCI device _DSM duplication
  tests: acpi: update expected blobs
  tests: acpi: whitelist pc/q35 DSDT before moving _ADR field
  x86: pci: acpi: reorder Device's _ADR and _SUN fields
  tests: acpi: update expected blobs
  tests: acpi: whitelist pc/q35 DSDT before moving _ADR field
  x86: pci: acpi:  reorder Device's _DSM method
  tests: acpi: update expected blobs
  x86: pci: acpi: deduplate PCI slots creation

 hw/i386/acpi-build.c                  | 302 ++++++++++++++------------
 tests/data/acpi/pc/DSDT               | Bin 5987 -> 6422 bytes
 tests/data/acpi/pc/DSDT.acpierst      | Bin 5954 -> 6382 bytes
 tests/data/acpi/pc/DSDT.acpihmat      | Bin 7312 -> 7747 bytes
 tests/data/acpi/pc/DSDT.bridge        | Bin 8653 -> 9496 bytes
 tests/data/acpi/pc/DSDT.cphp          | Bin 6451 -> 6886 bytes
 tests/data/acpi/pc/DSDT.dimmpxm       | Bin 7641 -> 8076 bytes
 tests/data/acpi/pc/DSDT.hpbridge      | Bin 5954 -> 6382 bytes
 tests/data/acpi/pc/DSDT.hpbrroot      | Bin 3069 -> 3069 bytes
 tests/data/acpi/pc/DSDT.ipmikcs       | Bin 6059 -> 6494 bytes
 tests/data/acpi/pc/DSDT.memhp         | Bin 7346 -> 7781 bytes
 tests/data/acpi/pc/DSDT.nohpet        | Bin 5845 -> 6280 bytes
 tests/data/acpi/pc/DSDT.numamem       | Bin 5993 -> 6428 bytes
 tests/data/acpi/pc/DSDT.roothp        | Bin 6195 -> 6656 bytes
 tests/data/acpi/q35/DSDT              | Bin 8274 -> 8320 bytes
 tests/data/acpi/q35/DSDT.acpierst     | Bin 8291 -> 8337 bytes
 tests/data/acpi/q35/DSDT.acpihmat     | Bin 9599 -> 9645 bytes
 tests/data/acpi/q35/DSDT.applesmc     | Bin 8320 -> 8366 bytes
 tests/data/acpi/q35/DSDT.bridge       | Bin 10988 -> 11449 bytes
 tests/data/acpi/q35/DSDT.cphp         | Bin 8738 -> 8784 bytes
 tests/data/acpi/q35/DSDT.cxl          | Bin 9600 -> 9646 bytes
 tests/data/acpi/q35/DSDT.dimmpxm      | Bin 9928 -> 9974 bytes
 tests/data/acpi/q35/DSDT.ipmibt       | Bin 8349 -> 8395 bytes
 tests/data/acpi/q35/DSDT.ipmismbus    | Bin 8363 -> 8409 bytes
 tests/data/acpi/q35/DSDT.ivrs         | Bin 8291 -> 8337 bytes
 tests/data/acpi/q35/DSDT.memhp        | Bin 9633 -> 9679 bytes
 tests/data/acpi/q35/DSDT.mmio64       | Bin 9404 -> 9450 bytes
 tests/data/acpi/q35/DSDT.multi-bridge | Bin 8568 -> 8640 bytes
 tests/data/acpi/q35/DSDT.nohpet       | Bin 8132 -> 8178 bytes
 tests/data/acpi/q35/DSDT.numamem      | Bin 8280 -> 8326 bytes
 tests/data/acpi/q35/DSDT.pvpanic-isa  | Bin 8375 -> 8421 bytes
 tests/data/acpi/q35/DSDT.tis.tpm12    | Bin 8880 -> 8926 bytes
 tests/data/acpi/q35/DSDT.tis.tpm2     | Bin 8906 -> 8952 bytes
 tests/data/acpi/q35/DSDT.viot         | Bin 9383 -> 9429 bytes
 tests/data/acpi/q35/DSDT.xapic        | Bin 35637 -> 35683 bytes
 35 files changed, 161 insertions(+), 141 deletions(-)

Comments

Igor Mammedov Sept. 6, 2022, 11:41 a.m. UTC | #1
On Fri,  1 Jul 2022 09:34:58 -0400
Igor Mammedov <imammedo@redhat.com> wrote:

> Flushing out ACPI PCI cleanups that preceed conversion of
> DSDT PCI slots ennumeration to AcpiDevAmlIf interface.
> It's is mostly collection of patches thraet removes code
> duplication, we've accumulated around PCI relaterd AML
> in DSDT.

ping,
it still applies cleanly to master.

Michael can you pick it up?

> 
> git:
>    https://gitlab.com/imammedo/qemu.git x86_pci_cleanups
> 
> Igor Mammedov (17):
>   tests: acpi: whitelist pc/q35 DSDT due to HPET AML move
>   acpi: x86: deduplicate HPET AML building
>   tests: acpi: update expected blobs after HPET move
>   tests: acpi: whitelist pc/q35 DSDT due to HPET AML move
>   acpi: x86: refactor PDSM method to reduce nesting
>   x86: acpi: _DSM: use Package to pass parameters
>   tests: acpi: update expected blobs
>   tests: acpi: whitelist pc/q35 DSDT before switching _DSM to use ASUN
>   x86: acpi: cleanup PCI device _DSM duplication
>   tests: acpi: update expected blobs
>   tests: acpi: whitelist pc/q35 DSDT before moving _ADR field
>   x86: pci: acpi: reorder Device's _ADR and _SUN fields
>   tests: acpi: update expected blobs
>   tests: acpi: whitelist pc/q35 DSDT before moving _ADR field
>   x86: pci: acpi:  reorder Device's _DSM method
>   tests: acpi: update expected blobs
>   x86: pci: acpi: deduplate PCI slots creation
> 
>  hw/i386/acpi-build.c                  | 302 ++++++++++++++------------
>  tests/data/acpi/pc/DSDT               | Bin 5987 -> 6422 bytes
>  tests/data/acpi/pc/DSDT.acpierst      | Bin 5954 -> 6382 bytes
>  tests/data/acpi/pc/DSDT.acpihmat      | Bin 7312 -> 7747 bytes
>  tests/data/acpi/pc/DSDT.bridge        | Bin 8653 -> 9496 bytes
>  tests/data/acpi/pc/DSDT.cphp          | Bin 6451 -> 6886 bytes
>  tests/data/acpi/pc/DSDT.dimmpxm       | Bin 7641 -> 8076 bytes
>  tests/data/acpi/pc/DSDT.hpbridge      | Bin 5954 -> 6382 bytes
>  tests/data/acpi/pc/DSDT.hpbrroot      | Bin 3069 -> 3069 bytes
>  tests/data/acpi/pc/DSDT.ipmikcs       | Bin 6059 -> 6494 bytes
>  tests/data/acpi/pc/DSDT.memhp         | Bin 7346 -> 7781 bytes
>  tests/data/acpi/pc/DSDT.nohpet        | Bin 5845 -> 6280 bytes
>  tests/data/acpi/pc/DSDT.numamem       | Bin 5993 -> 6428 bytes
>  tests/data/acpi/pc/DSDT.roothp        | Bin 6195 -> 6656 bytes
>  tests/data/acpi/q35/DSDT              | Bin 8274 -> 8320 bytes
>  tests/data/acpi/q35/DSDT.acpierst     | Bin 8291 -> 8337 bytes
>  tests/data/acpi/q35/DSDT.acpihmat     | Bin 9599 -> 9645 bytes
>  tests/data/acpi/q35/DSDT.applesmc     | Bin 8320 -> 8366 bytes
>  tests/data/acpi/q35/DSDT.bridge       | Bin 10988 -> 11449 bytes
>  tests/data/acpi/q35/DSDT.cphp         | Bin 8738 -> 8784 bytes
>  tests/data/acpi/q35/DSDT.cxl          | Bin 9600 -> 9646 bytes
>  tests/data/acpi/q35/DSDT.dimmpxm      | Bin 9928 -> 9974 bytes
>  tests/data/acpi/q35/DSDT.ipmibt       | Bin 8349 -> 8395 bytes
>  tests/data/acpi/q35/DSDT.ipmismbus    | Bin 8363 -> 8409 bytes
>  tests/data/acpi/q35/DSDT.ivrs         | Bin 8291 -> 8337 bytes
>  tests/data/acpi/q35/DSDT.memhp        | Bin 9633 -> 9679 bytes
>  tests/data/acpi/q35/DSDT.mmio64       | Bin 9404 -> 9450 bytes
>  tests/data/acpi/q35/DSDT.multi-bridge | Bin 8568 -> 8640 bytes
>  tests/data/acpi/q35/DSDT.nohpet       | Bin 8132 -> 8178 bytes
>  tests/data/acpi/q35/DSDT.numamem      | Bin 8280 -> 8326 bytes
>  tests/data/acpi/q35/DSDT.pvpanic-isa  | Bin 8375 -> 8421 bytes
>  tests/data/acpi/q35/DSDT.tis.tpm12    | Bin 8880 -> 8926 bytes
>  tests/data/acpi/q35/DSDT.tis.tpm2     | Bin 8906 -> 8952 bytes
>  tests/data/acpi/q35/DSDT.viot         | Bin 9383 -> 9429 bytes
>  tests/data/acpi/q35/DSDT.xapic        | Bin 35637 -> 35683 bytes
>  35 files changed, 161 insertions(+), 141 deletions(-)
>
Michael S. Tsirkin Sept. 6, 2022, 1:10 p.m. UTC | #2
On Tue, Sep 06, 2022 at 01:41:08PM +0200, Igor Mammedov wrote:
> On Fri,  1 Jul 2022 09:34:58 -0400
> Igor Mammedov <imammedo@redhat.com> wrote:
> 
> > Flushing out ACPI PCI cleanups that preceed conversion of
> > DSDT PCI slots ennumeration to AcpiDevAmlIf interface.
> > It's is mostly collection of patches thraet removes code
> > duplication, we've accumulated around PCI relaterd AML
> > in DSDT.
> 
> ping,
> it still applies cleanly to master.
> 
> Michael can you pick it up?

yes, thanks for the ping!

> > 
> > git:
> >    https://gitlab.com/imammedo/qemu.git x86_pci_cleanups
> > 
> > Igor Mammedov (17):
> >   tests: acpi: whitelist pc/q35 DSDT due to HPET AML move
> >   acpi: x86: deduplicate HPET AML building
> >   tests: acpi: update expected blobs after HPET move
> >   tests: acpi: whitelist pc/q35 DSDT due to HPET AML move
> >   acpi: x86: refactor PDSM method to reduce nesting
> >   x86: acpi: _DSM: use Package to pass parameters
> >   tests: acpi: update expected blobs
> >   tests: acpi: whitelist pc/q35 DSDT before switching _DSM to use ASUN
> >   x86: acpi: cleanup PCI device _DSM duplication
> >   tests: acpi: update expected blobs
> >   tests: acpi: whitelist pc/q35 DSDT before moving _ADR field
> >   x86: pci: acpi: reorder Device's _ADR and _SUN fields
> >   tests: acpi: update expected blobs
> >   tests: acpi: whitelist pc/q35 DSDT before moving _ADR field
> >   x86: pci: acpi:  reorder Device's _DSM method
> >   tests: acpi: update expected blobs
> >   x86: pci: acpi: deduplate PCI slots creation
> > 
> >  hw/i386/acpi-build.c                  | 302 ++++++++++++++------------
> >  tests/data/acpi/pc/DSDT               | Bin 5987 -> 6422 bytes
> >  tests/data/acpi/pc/DSDT.acpierst      | Bin 5954 -> 6382 bytes
> >  tests/data/acpi/pc/DSDT.acpihmat      | Bin 7312 -> 7747 bytes
> >  tests/data/acpi/pc/DSDT.bridge        | Bin 8653 -> 9496 bytes
> >  tests/data/acpi/pc/DSDT.cphp          | Bin 6451 -> 6886 bytes
> >  tests/data/acpi/pc/DSDT.dimmpxm       | Bin 7641 -> 8076 bytes
> >  tests/data/acpi/pc/DSDT.hpbridge      | Bin 5954 -> 6382 bytes
> >  tests/data/acpi/pc/DSDT.hpbrroot      | Bin 3069 -> 3069 bytes
> >  tests/data/acpi/pc/DSDT.ipmikcs       | Bin 6059 -> 6494 bytes
> >  tests/data/acpi/pc/DSDT.memhp         | Bin 7346 -> 7781 bytes
> >  tests/data/acpi/pc/DSDT.nohpet        | Bin 5845 -> 6280 bytes
> >  tests/data/acpi/pc/DSDT.numamem       | Bin 5993 -> 6428 bytes
> >  tests/data/acpi/pc/DSDT.roothp        | Bin 6195 -> 6656 bytes
> >  tests/data/acpi/q35/DSDT              | Bin 8274 -> 8320 bytes
> >  tests/data/acpi/q35/DSDT.acpierst     | Bin 8291 -> 8337 bytes
> >  tests/data/acpi/q35/DSDT.acpihmat     | Bin 9599 -> 9645 bytes
> >  tests/data/acpi/q35/DSDT.applesmc     | Bin 8320 -> 8366 bytes
> >  tests/data/acpi/q35/DSDT.bridge       | Bin 10988 -> 11449 bytes
> >  tests/data/acpi/q35/DSDT.cphp         | Bin 8738 -> 8784 bytes
> >  tests/data/acpi/q35/DSDT.cxl          | Bin 9600 -> 9646 bytes
> >  tests/data/acpi/q35/DSDT.dimmpxm      | Bin 9928 -> 9974 bytes
> >  tests/data/acpi/q35/DSDT.ipmibt       | Bin 8349 -> 8395 bytes
> >  tests/data/acpi/q35/DSDT.ipmismbus    | Bin 8363 -> 8409 bytes
> >  tests/data/acpi/q35/DSDT.ivrs         | Bin 8291 -> 8337 bytes
> >  tests/data/acpi/q35/DSDT.memhp        | Bin 9633 -> 9679 bytes
> >  tests/data/acpi/q35/DSDT.mmio64       | Bin 9404 -> 9450 bytes
> >  tests/data/acpi/q35/DSDT.multi-bridge | Bin 8568 -> 8640 bytes
> >  tests/data/acpi/q35/DSDT.nohpet       | Bin 8132 -> 8178 bytes
> >  tests/data/acpi/q35/DSDT.numamem      | Bin 8280 -> 8326 bytes
> >  tests/data/acpi/q35/DSDT.pvpanic-isa  | Bin 8375 -> 8421 bytes
> >  tests/data/acpi/q35/DSDT.tis.tpm12    | Bin 8880 -> 8926 bytes
> >  tests/data/acpi/q35/DSDT.tis.tpm2     | Bin 8906 -> 8952 bytes
> >  tests/data/acpi/q35/DSDT.viot         | Bin 9383 -> 9429 bytes
> >  tests/data/acpi/q35/DSDT.xapic        | Bin 35637 -> 35683 bytes
> >  35 files changed, 161 insertions(+), 141 deletions(-)
> >
Igor Mammedov Sept. 27, 2022, 10:20 a.m. UTC | #3
On Tue, 6 Sep 2022 09:10:32 -0400
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Tue, Sep 06, 2022 at 01:41:08PM +0200, Igor Mammedov wrote:
> > On Fri,  1 Jul 2022 09:34:58 -0400
> > Igor Mammedov <imammedo@redhat.com> wrote:
> >   
> > > Flushing out ACPI PCI cleanups that preceed conversion of
> > > DSDT PCI slots ennumeration to AcpiDevAmlIf interface.
> > > It's is mostly collection of patches thraet removes code
> > > duplication, we've accumulated around PCI relaterd AML
> > > in DSDT.  
> > 
> > ping,
> > it still applies cleanly to master.
> > 
> > Michael can you pick it up?  
> 
> yes, thanks for the ping!

ping?

> 
> > > 
> > > git:
> > >    https://gitlab.com/imammedo/qemu.git x86_pci_cleanups
> > > 
> > > Igor Mammedov (17):
> > >   tests: acpi: whitelist pc/q35 DSDT due to HPET AML move
> > >   acpi: x86: deduplicate HPET AML building
> > >   tests: acpi: update expected blobs after HPET move
> > >   tests: acpi: whitelist pc/q35 DSDT due to HPET AML move
> > >   acpi: x86: refactor PDSM method to reduce nesting
> > >   x86: acpi: _DSM: use Package to pass parameters
> > >   tests: acpi: update expected blobs
> > >   tests: acpi: whitelist pc/q35 DSDT before switching _DSM to use ASUN
> > >   x86: acpi: cleanup PCI device _DSM duplication
> > >   tests: acpi: update expected blobs
> > >   tests: acpi: whitelist pc/q35 DSDT before moving _ADR field
> > >   x86: pci: acpi: reorder Device's _ADR and _SUN fields
> > >   tests: acpi: update expected blobs
> > >   tests: acpi: whitelist pc/q35 DSDT before moving _ADR field
> > >   x86: pci: acpi:  reorder Device's _DSM method
> > >   tests: acpi: update expected blobs
> > >   x86: pci: acpi: deduplate PCI slots creation
> > > 
> > >  hw/i386/acpi-build.c                  | 302 ++++++++++++++------------
> > >  tests/data/acpi/pc/DSDT               | Bin 5987 -> 6422 bytes
> > >  tests/data/acpi/pc/DSDT.acpierst      | Bin 5954 -> 6382 bytes
> > >  tests/data/acpi/pc/DSDT.acpihmat      | Bin 7312 -> 7747 bytes
> > >  tests/data/acpi/pc/DSDT.bridge        | Bin 8653 -> 9496 bytes
> > >  tests/data/acpi/pc/DSDT.cphp          | Bin 6451 -> 6886 bytes
> > >  tests/data/acpi/pc/DSDT.dimmpxm       | Bin 7641 -> 8076 bytes
> > >  tests/data/acpi/pc/DSDT.hpbridge      | Bin 5954 -> 6382 bytes
> > >  tests/data/acpi/pc/DSDT.hpbrroot      | Bin 3069 -> 3069 bytes
> > >  tests/data/acpi/pc/DSDT.ipmikcs       | Bin 6059 -> 6494 bytes
> > >  tests/data/acpi/pc/DSDT.memhp         | Bin 7346 -> 7781 bytes
> > >  tests/data/acpi/pc/DSDT.nohpet        | Bin 5845 -> 6280 bytes
> > >  tests/data/acpi/pc/DSDT.numamem       | Bin 5993 -> 6428 bytes
> > >  tests/data/acpi/pc/DSDT.roothp        | Bin 6195 -> 6656 bytes
> > >  tests/data/acpi/q35/DSDT              | Bin 8274 -> 8320 bytes
> > >  tests/data/acpi/q35/DSDT.acpierst     | Bin 8291 -> 8337 bytes
> > >  tests/data/acpi/q35/DSDT.acpihmat     | Bin 9599 -> 9645 bytes
> > >  tests/data/acpi/q35/DSDT.applesmc     | Bin 8320 -> 8366 bytes
> > >  tests/data/acpi/q35/DSDT.bridge       | Bin 10988 -> 11449 bytes
> > >  tests/data/acpi/q35/DSDT.cphp         | Bin 8738 -> 8784 bytes
> > >  tests/data/acpi/q35/DSDT.cxl          | Bin 9600 -> 9646 bytes
> > >  tests/data/acpi/q35/DSDT.dimmpxm      | Bin 9928 -> 9974 bytes
> > >  tests/data/acpi/q35/DSDT.ipmibt       | Bin 8349 -> 8395 bytes
> > >  tests/data/acpi/q35/DSDT.ipmismbus    | Bin 8363 -> 8409 bytes
> > >  tests/data/acpi/q35/DSDT.ivrs         | Bin 8291 -> 8337 bytes
> > >  tests/data/acpi/q35/DSDT.memhp        | Bin 9633 -> 9679 bytes
> > >  tests/data/acpi/q35/DSDT.mmio64       | Bin 9404 -> 9450 bytes
> > >  tests/data/acpi/q35/DSDT.multi-bridge | Bin 8568 -> 8640 bytes
> > >  tests/data/acpi/q35/DSDT.nohpet       | Bin 8132 -> 8178 bytes
> > >  tests/data/acpi/q35/DSDT.numamem      | Bin 8280 -> 8326 bytes
> > >  tests/data/acpi/q35/DSDT.pvpanic-isa  | Bin 8375 -> 8421 bytes
> > >  tests/data/acpi/q35/DSDT.tis.tpm12    | Bin 8880 -> 8926 bytes
> > >  tests/data/acpi/q35/DSDT.tis.tpm2     | Bin 8906 -> 8952 bytes
> > >  tests/data/acpi/q35/DSDT.viot         | Bin 9383 -> 9429 bytes
> > >  tests/data/acpi/q35/DSDT.xapic        | Bin 35637 -> 35683 bytes
> > >  35 files changed, 161 insertions(+), 141 deletions(-)
> > >   
>