mbox series

[v5,0/3] tpm: Add missing ACPI device identification objects

Message ID 20220104175806.872996-1-stefanb@linux.ibm.com
Headers show
Series tpm: Add missing ACPI device identification objects | expand

Message

Stefan Berger Jan. 4, 2022, 5:58 p.m. UTC 
This series of patches adds missing ACPI device identification objects _STR
and _UID to TPM 1.2 and TPM 2 ACPI tables.

   Stefan

v5:
 - Changed Fixes: tag to Resolves:
 - Mentioned in 2/3 that choice of uid '1' is based on inspection of hardware
   TPMs' sysfs entries

v4:
 - Rebased on current master: regenerated binaries in patch 3

v3:
 - Dropped replacement of ACPI tables with empty files in 1/3.
 - Reduced ignored files

Stefan Berger (3):
  tests: acpi: prepare for updated TPM related tables
  acpi: tpm: Add missing device identification objects
  tests: acpi: Add updated TPM related tables

 hw/arm/virt-acpi-build.c           |   1 +
 hw/i386/acpi-build.c               |   7 +++++++
 tests/data/acpi/q35/DSDT.tis.tpm12 | Bin 8894 -> 8900 bytes
 tests/data/acpi/q35/DSDT.tis.tpm2  | Bin 8894 -> 8921 bytes
 4 files changed, 8 insertions(+)

Comments

Daniel P. Berrangé Jan. 4, 2022, 6:09 p.m. UTC | #1 
On Tue, Jan 04, 2022 at 12:58:03PM -0500, Stefan Berger wrote:
> This series of patches adds missing ACPI device identification objects _STR
> and _UID to TPM 1.2 and TPM 2 ACPI tables.

What was the practical impact on guests (if any) from these ACPI
objects being missing ?

Regards,
Daniel
Stefan Berger Jan. 4, 2022, 6:14 p.m. UTC | #2 
On 1/4/22 13:09, Daniel P. Berrangé wrote:
> On Tue, Jan 04, 2022 at 12:58:03PM -0500, Stefan Berger wrote:
>> This series of patches adds missing ACPI device identification objects _STR
>> and _UID to TPM 1.2 and TPM 2 ACPI tables.
> What was the practical impact on guests (if any) from these ACPI
> objects being missing ?

As discussed in v4: I don't know if there's software relying on this or 
just a user who found these to be missing:

https://gitlab.com/qemu-project/qemu/-/issues/708

I can only say that these entries were missing, so I added them. It 
makes TPM ACPI more complete, for sure. Maybe someone else knows more if 
there's something out there that actually needs this. I'd be curious as 
well.

    Stefan

>
> Regards,
> Daniel