mbox series

[v2,0/5] hw/qdev: Clarify qdev_connect_gpio_out() documentation

Message ID 20211218130437.1516929-1-f4bug@amsat.org
Headers show
Series hw/qdev: Clarify qdev_connect_gpio_out() documentation | expand

Message

Philippe Mathieu-Daudé Dec. 18, 2021, 1:04 p.m. UTC 
Trivial patches clarifying qdev_connect_gpio_out() use,
basically that the qemu_irq argument is an input.

Since v1:
- Addressed Yanan Wang and Peter Maydell comments:
- Correct qdev_init_gpio_out_named() doc
- Drop i8042_setup_a20_line() wrapper

Philippe Mathieu-Daudé (5):
  hw/qdev: Cosmetic around documentation
  hw/qdev: Correct qdev_init_gpio_out_named() documentation
  hw/qdev: Correct qdev_connect_gpio_out_named() documentation
  hw/qdev: Rename qdev_connect_gpio_out*() 'input_pin' parameter
  hw/input/pckbd: Open-code i8042_setup_a20_line() wrapper

 include/hw/input/i8042.h |  1 -
 include/hw/qdev-core.h   | 24 ++++++++++++++++++------
 hw/core/gpio.c           | 13 +++++++------
 hw/i386/pc.c             |  3 ++-
 hw/input/pckbd.c         |  5 -----
 5 files changed, 27 insertions(+), 19 deletions(-)

Comments

Philippe Mathieu-Daudé Dec. 23, 2021, 7:01 a.m. UTC | #1 
Hi Peter.

Since you reviewed v1, and Ack-by on v2 would be welcomed.
Otherwise, if you don't object, I plan to queue this via
machine-next tree.

Thanks,

Phil.

On 12/18/21 14:04, Philippe Mathieu-Daudé wrote:
> Trivial patches clarifying qdev_connect_gpio_out() use,
> basically that the qemu_irq argument is an input.
> 
> Since v1:
> - Addressed Yanan Wang and Peter Maydell comments:
> - Correct qdev_init_gpio_out_named() doc
> - Drop i8042_setup_a20_line() wrapper
> 
> Philippe Mathieu-Daudé (5):
>   hw/qdev: Cosmetic around documentation
>   hw/qdev: Correct qdev_init_gpio_out_named() documentation
>   hw/qdev: Correct qdev_connect_gpio_out_named() documentation
>   hw/qdev: Rename qdev_connect_gpio_out*() 'input_pin' parameter
>   hw/input/pckbd: Open-code i8042_setup_a20_line() wrapper
> 
>  include/hw/input/i8042.h |  1 -
>  include/hw/qdev-core.h   | 24 ++++++++++++++++++------
>  hw/core/gpio.c           | 13 +++++++------
>  hw/i386/pc.c             |  3 ++-
>  hw/input/pckbd.c         |  5 -----
>  5 files changed, 27 insertions(+), 19 deletions(-)
>
Philippe Mathieu-Daudé Dec. 31, 2021, 12:17 p.m. UTC | #2 
On 12/18/21 14:04, Philippe Mathieu-Daudé wrote:
> Trivial patches clarifying qdev_connect_gpio_out() use,
> basically that the qemu_irq argument is an input.
> 
> Since v1:
> - Addressed Yanan Wang and Peter Maydell comments:
> - Correct qdev_init_gpio_out_named() doc
> - Drop i8042_setup_a20_line() wrapper
> 
> Philippe Mathieu-Daudé (5):
>   hw/qdev: Cosmetic around documentation
>   hw/qdev: Correct qdev_init_gpio_out_named() documentation
>   hw/qdev: Correct qdev_connect_gpio_out_named() documentation
>   hw/qdev: Rename qdev_connect_gpio_out*() 'input_pin' parameter
>   hw/input/pckbd: Open-code i8042_setup_a20_line() wrapper

Queuing patches 1-4 via machine-next.
Peter Maydell Jan. 6, 2022, 3:30 p.m. UTC | #3 
On Thu, 23 Dec 2021 at 09:05, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> Hi Peter.
>
> Since you reviewed v1, and Ack-by on v2 would be welcomed.
> Otherwise, if you don't object, I plan to queue this via
> machine-next tree.

Been on holiday since mid-Dec :-)  I see this is already
upstream, which is fine, I have no objections.

-- PMM