mbox series

[0/8] hw: Have DMA API take MemTxAttrs arg & propagate MemTxResult (part 2)

Message ID 20211216123558.799425-1-philmd@redhat.com
Headers show
Series hw: Have DMA API take MemTxAttrs arg & propagate MemTxResult (part 2) | expand

Message

Philippe Mathieu-Daudé Dec. 16, 2021, 12:35 p.m. UTC 
This is the continuation of part 1 (dma_memory API):
https://www.mail-archive.com/qemu-devel@nongnu.org/msg820359.html

This series update the dma_buf API.

Based on "hw: Let the DMA API take a MemTxAttrs argument"
Based-on: <20210702092439.989969-1-philmd@redhat.com>

Philippe Mathieu-Daudé (8):
  dma: Have dma_buf_rw() take a void pointer
  dma: Have dma_buf_read() / dma_buf_write() take a void pointer
  dma: Let pci_dma_rw() take MemTxAttrs argument
  dma: Let dma_buf_rw() take MemTxAttrs argument
  dma: Let dma_buf_write() take MemTxAttrs argument
  dma: Let dma_buf_read() take MemTxAttrs argument
  dma: Let dma_buf_rw() propagate MemTxResult
  dma: Let dma_buf_read() / dma_buf_write() propagate MemTxResult

 include/hw/pci/pci.h  | 10 +++++----
 include/sysemu/dma.h  |  6 ++++--
 hw/audio/intel-hda.c  |  3 ++-
 hw/ide/ahci.c         | 10 +++++----
 hw/nvme/ctrl.c        |  5 +++--
 hw/scsi/esp-pci.c     |  2 +-
 hw/scsi/megasas.c     | 48 ++++++++++++++++++++++++++++++-------------
 hw/scsi/scsi-bus.c    |  4 ++--
 softmmu/dma-helpers.c | 25 ++++++++++++++--------
 9 files changed, 74 insertions(+), 39 deletions(-)

Comments

Klaus Jensen Dec. 16, 2021, 7:33 p.m. UTC | #1 
On Dec 16 13:35, Philippe Mathieu-Daudé wrote:
> This is the continuation of part 1 (dma_memory API):
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg820359.html
> 
> This series update the dma_buf API.
> 
> Based on "hw: Let the DMA API take a MemTxAttrs argument"
> Based-on: <20210702092439.989969-1-philmd@redhat.com>
> 
> Philippe Mathieu-Daudé (8):
>   dma: Have dma_buf_rw() take a void pointer
>   dma: Have dma_buf_read() / dma_buf_write() take a void pointer
>   dma: Let pci_dma_rw() take MemTxAttrs argument
>   dma: Let dma_buf_rw() take MemTxAttrs argument
>   dma: Let dma_buf_write() take MemTxAttrs argument
>   dma: Let dma_buf_read() take MemTxAttrs argument
>   dma: Let dma_buf_rw() propagate MemTxResult
>   dma: Let dma_buf_read() / dma_buf_write() propagate MemTxResult
> 
>  include/hw/pci/pci.h  | 10 +++++----
>  include/sysemu/dma.h  |  6 ++++--
>  hw/audio/intel-hda.c  |  3 ++-
>  hw/ide/ahci.c         | 10 +++++----
>  hw/nvme/ctrl.c        |  5 +++--
>  hw/scsi/esp-pci.c     |  2 +-
>  hw/scsi/megasas.c     | 48 ++++++++++++++++++++++++++++++-------------
>  hw/scsi/scsi-bus.c    |  4 ++--
>  softmmu/dma-helpers.c | 25 ++++++++++++++--------
>  9 files changed, 74 insertions(+), 39 deletions(-)
> 

LGTM.

Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
John Snow Dec. 16, 2021, 11:28 p.m. UTC | #2 
Looks OK at a very quick glance. Very weak ACK from me.

On Thu, Dec 16, 2021 at 7:36 AM Philippe Mathieu-Daudé <philmd@redhat.com>
wrote:

> This is the continuation of part 1 (dma_memory API):
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg820359.html
>
> This series update the dma_buf API.
>
> Based on "hw: Let the DMA API take a MemTxAttrs argument"
> Based-on: <20210702092439.989969-1-philmd@redhat.com>
>
> Philippe Mathieu-Daudé (8):
>   dma: Have dma_buf_rw() take a void pointer
>   dma: Have dma_buf_read() / dma_buf_write() take a void pointer
>   dma: Let pci_dma_rw() take MemTxAttrs argument
>   dma: Let dma_buf_rw() take MemTxAttrs argument
>   dma: Let dma_buf_write() take MemTxAttrs argument
>   dma: Let dma_buf_read() take MemTxAttrs argument
>   dma: Let dma_buf_rw() propagate MemTxResult
>   dma: Let dma_buf_read() / dma_buf_write() propagate MemTxResult
>
>  include/hw/pci/pci.h  | 10 +++++----
>  include/sysemu/dma.h  |  6 ++++--
>  hw/audio/intel-hda.c  |  3 ++-
>  hw/ide/ahci.c         | 10 +++++----
>  hw/nvme/ctrl.c        |  5 +++--
>  hw/scsi/esp-pci.c     |  2 +-
>  hw/scsi/megasas.c     | 48 ++++++++++++++++++++++++++++++-------------
>  hw/scsi/scsi-bus.c    |  4 ++--
>  softmmu/dma-helpers.c | 25 ++++++++++++++--------
>  9 files changed, 74 insertions(+), 39 deletions(-)
>
> --
> 2.33.1
>
>
>