mbox series

[PATCH-for-7.0,0/2] hw/nvme/ctrl: Buffer types cleanups

Message ID 20211111154552.2263410-1-philmd@redhat.com
Headers show
Series hw/nvme/ctrl: Buffer types cleanups | expand

Message

Philippe Mathieu-Daudé Nov. 11, 2021, 3:45 p.m. UTC 
Some trivial notes I took while reviewing CVE-2021-3947:
https://lore.kernel.org/qemu-devel/20211111153125.2258176-1-philmd@redhat.com/

Based-on: <20211111153125.2258176-1-philmd@redhat.com>

*** BLURB HERE ***

Philippe Mathieu-Daudé (2):
  hw/nvme/ctrl: Have nvme_addr_write() take const buffer
  hw/nvme/ctrl: Pass buffers as 'void *' types

 hw/nvme/nvme.h |  4 ++--
 hw/nvme/ctrl.c | 12 ++++++------
 2 files changed, 8 insertions(+), 8 deletions(-)

Comments

Klaus Jensen Nov. 11, 2021, 6:09 p.m. UTC | #1 
On Nov 11 16:45, Philippe Mathieu-Daudé wrote:
> Some trivial notes I took while reviewing CVE-2021-3947:
> https://lore.kernel.org/qemu-devel/20211111153125.2258176-1-philmd@redhat.com/
> 
> Based-on: <20211111153125.2258176-1-philmd@redhat.com>
> 
> *** BLURB HERE ***
> 
> Philippe Mathieu-Daudé (2):
>   hw/nvme/ctrl: Have nvme_addr_write() take const buffer
>   hw/nvme/ctrl: Pass buffers as 'void *' types
> 
>  hw/nvme/nvme.h |  4 ++--
>  hw/nvme/ctrl.c | 12 ++++++------
>  2 files changed, 8 insertions(+), 8 deletions(-)
> 

Thanks Philippe, LGTM.

Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
Klaus Jensen Jan. 26, 2022, 9:05 a.m. UTC | #2 
On Nov 11 19:09, Klaus Jensen wrote:
> On Nov 11 16:45, Philippe Mathieu-Daudé wrote:
> > Some trivial notes I took while reviewing CVE-2021-3947:
> > https://lore.kernel.org/qemu-devel/20211111153125.2258176-1-philmd@redhat.com/
> > 
> > Based-on: <20211111153125.2258176-1-philmd@redhat.com>
> > 
> > *** BLURB HERE ***
> > 
> > Philippe Mathieu-Daudé (2):
> >   hw/nvme/ctrl: Have nvme_addr_write() take const buffer
> >   hw/nvme/ctrl: Pass buffers as 'void *' types
> > 
> >  hw/nvme/nvme.h |  4 ++--
> >  hw/nvme/ctrl.c | 12 ++++++------
> >  2 files changed, 8 insertions(+), 8 deletions(-)
> > 
> 
> Thanks Philippe, LGTM.
> 
> Reviewed-by: Klaus Jensen <k.jensen@samsung.com>

Applied to nvme-next. Thanks!