Message ID | 20211023214803.522078-1-f4bug@amsat.org |
---|---|
Headers | show |
Series | target/mips: Fully convert MSA opcodes to decodetree | expand |
在 2021/10/23 22:47, Philippe Mathieu-Daudé 写道: > Hi, > > > > This series converts 2000+ lines of switch() code to decodetree > > description, so this hard-to-review/modify switch is auto generated > > by the decodetree script. This is a big win for maintenance (and > > indeed the convertion revealed 2 bugs). > > > > Massive convertions are - beside being often boring - bug-prone. > > In this series we re-start running the MSA tests (the tests are > > run automagically in the 'build-user-static' job on gitlab CI). > > > > Although boring, the conversion is very clean, so I hope it will > > be easy enough to review. The TRANS*() macros are heavily used. > > > > When possible, constant fields are hold with tcg_constant(). > > > > Note, various opcodes can be optimized using TCG host vectors. > > We won't address that in this series, as it makes the resulting > > review harder. We will post that in a following series. Here we > > simply dummy-convert. > > > > The resulting msa.decode file is quite pleasant to look at, and > > the diff-stat is encouraging: number of LoC halved. > > > > Regards, Thanks that's really helpful! For the whole series: Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com> Double checked decode tree opcode with manual. Thanks. - Jiaxun > > > > Phil. > > > > git: https://gitlab.com/philmd/qemu.git tree/mips-msa-decodetree > > Based-on: <20211023164329.328137-1-f4bug@amsat.org> > > > > Philippe Mathieu-Daudé (33): > > tests/tcg: Fix some targets default cross compiler path > > target/mips: Fix MSA MADDV.B opcode > > target/mips: Fix MSA MSUBV.B opcode > > tests/tcg/mips: Run MSA opcodes tests on user-mode emulation > > target/mips: Have check_msa_access() return a boolean > > target/mips: Use enum definitions from CPUMIPSMSADataFormat enum > > target/mips: Rename sa16 -> sa, bz_df -> bz -> bz_v > > target/mips: Convert MSA LDI opcode to decodetree > > target/mips: Introduce generic TRANS_CHECK() for decodetree helpers > > target/mips: Extract df_extract() helper > > target/mips: Convert MSA I5 instruction format to decodetree > > target/mips: Convert MSA BIT instruction format to decodetree > > target/mips: Convert MSA SHF opcode to decodetree > > target/mips: Convert MSA I8 instruction format to decodetree > > target/mips: Convert MSA load/store instruction format to decodetree > > target/mips: Convert MSA 2RF instruction format to decodetree > > target/mips: Convert MSA FILL opcode to decodetree > > target/mips: Convert MSA 2R instruction format to decodetree > > target/mips: Convert MSA VEC instruction format to decodetree > > target/mips: Convert MSA 3RF instruction format to decodetree > > (DF_HALF) > > target/mips: Convert MSA 3RF instruction format to decodetree > > (DF_WORD) > > target/mips: Convert MSA 3R instruction format to decodetree (part > > 1/4) > > target/mips: Convert MSA 3R instruction format to decodetree (part > > 2/4) > > target/mips: Convert MSA 3R instruction format to decodetree (part > > 3/4) > > target/mips: Convert MSA 3R instruction format to decodetree (part > > 4/4) > > target/mips: Convert MSA ELM instruction format to decodetree > > target/mips: Convert MSA COPY_U opcode to decodetree > > target/mips: Convert MSA COPY_S and INSERT opcodes to decodetree > > target/mips: Convert MSA MOVE.V opcode to decodetree > > target/mips: Convert CFCMSA and CTCMSA opcodes to decodetree > > target/mips: Remove generic MSA opcode > > target/mips: Remove one MSA unnecessary decodetree overlap group > > target/mips: Adjust style in msa_translate_init() > > > > tests/tcg/mips/ase-msa.mak | 30 + > > target/mips/tcg/translate.h | 9 + > > target/mips/tcg/msa.decode | 231 ++- > > target/mips/tcg/msa_helper.c | 64 +- > > target/mips/tcg/msa_translate.c | 2781 +++++++--------------------- > > MAINTAINERS | 1 + > > tests/tcg/configure.sh | 14 +- > > tests/tcg/mips/Makefile.target | 5 + > > tests/tcg/mips64/Makefile.target | 9 + > > tests/tcg/mips64el/Makefile.target | 12 + > > tests/tcg/mipsel/Makefile.target | 9 + > > 11 files changed, 1052 insertions(+), 2113 deletions(-) > > create mode 100644 tests/tcg/mips/ase-msa.mak > > create mode 100644 tests/tcg/mips64/Makefile.target > > create mode 100644 tests/tcg/mips64el/Makefile.target > > create mode 100644 tests/tcg/mipsel/Makefile.target > > >
On 10/24/21 20:26, Jiaxun Yang wrote: > Thanks that's really helpful! > > For the whole series: > > Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com> > > Double checked decode tree opcode with manual. Thank you! I'll respin addressing Richard comments but won't change the msa.decode file, so I'll include your R-b tag. Regards, Phil.