From patchwork Wed Jun 16 16:14:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 1492974 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=cPOnscp/; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4G4qyt5Vzmz9sXL for ; Thu, 17 Jun 2021 02:15:01 +1000 (AEST) Received: from localhost ([::1]:49072 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ltYBt-0001KT-N6 for incoming@patchwork.ozlabs.org; Wed, 16 Jun 2021 12:14:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36478) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ltYBS-0001K4-3b; Wed, 16 Jun 2021 12:14:30 -0400 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]:37816) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ltYBO-0005hf-PF; Wed, 16 Jun 2021 12:14:29 -0400 Received: by mail-wm1-x332.google.com with SMTP id f16-20020a05600c1550b02901b00c1be4abso4503647wmg.2; Wed, 16 Jun 2021 09:14:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=uI7EBv0jj9+GiVTjrqxKvPzX6O3I8/xNn/berB0WuHs=; b=cPOnscp/Q2hzTxEdazmqWSLbj8u5pMyoNwvR+2gwJk2qM9BLhZXiN7dYWr679Gpunb i2fA1QSVTp0NEm+4Hihrwo1ig4BSXSgMKZL8A/1y6XoQf1JXg8g8VQ2Skpl69sB+cfjo dmkZyIZ56mgolVMh7QRQzuF/knlV20418SnYBG6IHhrQkFSXCI16Bfg6Pq0KlzvkFVTy HR6S1j+3BOWs1ACU8GiOD+0MiQomSfsdnMDK/7MaDcaYd1kr3WcB0EAitgLCcHb0L6E6 77LpIbXHuuE6Ak+AS8SubfpSUIajbrkklLc62P9SRZmWXMgvmQY1npkb8ITrNm0DUnWG 7COQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=uI7EBv0jj9+GiVTjrqxKvPzX6O3I8/xNn/berB0WuHs=; b=CBCpdNF01d4PqsS9kqxmfZx+tEoQw+PqdCNyz/TANJOhiTVfT3oxkoztPvNtYzJcCj TW1qpXfwaIlpqqvb9pR6Py0Nf2621ZCRNZMmaqgDPZoMXCqG7f2KZLMKp2/ecQGVHCGz GzdU5dsgECO8Wh3taC/AtcZMfR4IWMmX1zd9Apbv1FeMc5Gp2L61GXUKMqbXIV+B8sqJ KT9kvvs6K6wjSyFGH3yBWjCvnryMuOOs2jiUu3xWAC/zTC2lct/7y2WHf0K09LulTQdU FNPtHPqmR2qsIzL/LXU7M0B9KwD6X8ZVwdfq8x0GV751/aCK8UzgfzkbEBjx2xbv6shB vwNw== X-Gm-Message-State: AOAM531kWE0UT37rSG4fFKvVOqSyvcyoHSa50qcob4DQS0m1ttpRu8G5 fK32tAFYOKSWkqh0zOQ2kfZxo7AezN58Zw== X-Google-Smtp-Source: ABdhPJw6I/FGZN5I9vSaLsozx3p0Ecvga2NFytKW+Y3kv4R+w07moHHn4SGAV0a8m5LVGDp/GAnY/w== X-Received: by 2002:a05:600c:4f0c:: with SMTP id l12mr12158690wmq.93.1623860060849; Wed, 16 Jun 2021 09:14:20 -0700 (PDT) Received: from x1w.. (93.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.93]) by smtp.gmail.com with ESMTPSA id z10sm2212350wmp.39.2021.06.16.09.14.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Jun 2021 09:14:19 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v3 00/13] hw/i2c: Remove confusing i2c_send_recv() API Date: Wed, 16 Jun 2021 18:14:05 +0200 Message-Id: <20210616161418.2514095-1-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x332.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= , "Signed-off-by : Frederic Konrad" , qemu-arm@nongnu.org, qemu-ppc@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" This is a respin of Zoltan's patch: https://www.mail-archive.com/qemu-devel@nongnu.org/msg714711.html Since v2, tried to address Corey's review comments resulting in a i2c_send_recv() removal and code easier to review (to my taste at least). Supersedes: <20200623063123.20776-1-f4bug@amsat.org> BALATON Zoltan (1): hw/i2c: Make i2c_start_transfer() direction argument a boolean Philippe Mathieu-Daudé (12): hw/input/lm832x: Move lm832x_key_event() declaration to "lm832x.h" hw/input/lm832x: Define TYPE_LM8323 in public header hw/display/sm501: Simplify sm501_i2c_write() logic hw/display/sm501: Replace i2c_send_recv() by i2c_recv() & i2c_send() hw/i2c/ppc4xx_i2c: Add reference to datasheet hw/i2c/ppc4xx_i2c: Replace i2c_send_recv() by i2c_recv() & i2c_send() hw/misc/auxbus: Fix MOT/classic I2C mode hw/misc/auxbus: Explode READ_I2C / WRITE_I2C_MOT cases hw/misc/auxbus: Replace 'is_write' boolean by its value hw/misc/auxbus: Replace i2c_send_recv() by i2c_recv() & i2c_send() hw/i2c: Remove confusing i2c_send_recv() hw/i2c: Rename i2c_set_slave_address() -> i2c_slave_set_address() include/hw/i2c/i2c.h | 21 +++++++++--- include/hw/input/lm832x.h | 28 ++++++++++++++++ hw/arm/nseries.c | 3 +- hw/arm/pxa2xx.c | 2 +- hw/arm/spitz.c | 4 +-- hw/display/ati.c | 2 +- hw/display/sm501.c | 16 +++++---- hw/display/xlnx_dp.c | 2 +- hw/i2c/core.c | 56 ++++++++++++++----------------- hw/i2c/imx_i2c.c | 2 +- hw/i2c/ppc4xx_i2c.c | 15 ++++++--- hw/input/lm832x.c | 2 +- hw/misc/auxbus.c | 69 +++++++++++++++++++++++++++++---------- MAINTAINERS | 1 + 14 files changed, 149 insertions(+), 74 deletions(-) create mode 100644 include/hw/input/lm832x.h Acked-by: Corey Minyard