mbox series

[0/3] hw/virtio: Constify VirtIOFeature

Message ID 20210511104157.2880306-1-philmd@redhat.com
Headers show
Series hw/virtio: Constify VirtIOFeature | expand

Message

Philippe Mathieu-Daudé May 11, 2021, 10:41 a.m. UTC 
Trivial patches to keep VirtIOFeature arrays read-only
(better safe than sorry).

Philippe Mathieu-Daudé (3):
  hw/virtio: Pass virtio_feature_get_config_size() a const argument
  virtio-blk: Constify VirtIOFeature feature_sizes[]
  virtio-net: Constify VirtIOFeature feature_sizes[]

 include/hw/virtio/virtio.h | 2 +-
 hw/block/virtio-blk.c      | 2 +-
 hw/net/virtio-net.c        | 2 +-
 hw/virtio/virtio.c         | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

Comments

Richard Henderson May 11, 2021, 4:54 p.m. UTC | #1 
On 5/11/21 5:41 AM, Philippe Mathieu-Daudé wrote:
> Philippe Mathieu-Daudé (3):
>    hw/virtio: Pass virtio_feature_get_config_size() a const argument
>    virtio-blk: Constify VirtIOFeature feature_sizes[]
>    virtio-net: Constify VirtIOFeature feature_sizes[]

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~
Stefano Garzarella May 12, 2021, 7:13 a.m. UTC | #2 
On Tue, May 11, 2021 at 12:41:54PM +0200, Philippe Mathieu-Daudé wrote:
>Trivial patches to keep VirtIOFeature arrays read-only
>(better safe than sorry).
>
>Philippe Mathieu-Daudé (3):
>  hw/virtio: Pass virtio_feature_get_config_size() a const argument
>  virtio-blk: Constify VirtIOFeature feature_sizes[]
>  virtio-net: Constify VirtIOFeature feature_sizes[]
>
> include/hw/virtio/virtio.h | 2 +-
> hw/block/virtio-blk.c      | 2 +-
> hw/net/virtio-net.c        | 2 +-
> hw/virtio/virtio.c         | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Stefan Hajnoczi May 12, 2021, 3:54 p.m. UTC | #3 
On Tue, May 11, 2021 at 12:41:54PM +0200, Philippe Mathieu-Daudé wrote:
> Trivial patches to keep VirtIOFeature arrays read-only
> (better safe than sorry).
> 
> Philippe Mathieu-Daudé (3):
>   hw/virtio: Pass virtio_feature_get_config_size() a const argument
>   virtio-blk: Constify VirtIOFeature feature_sizes[]
>   virtio-net: Constify VirtIOFeature feature_sizes[]
> 
>  include/hw/virtio/virtio.h | 2 +-
>  hw/block/virtio-blk.c      | 2 +-
>  hw/net/virtio-net.c        | 2 +-
>  hw/virtio/virtio.c         | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> -- 
> 2.26.3
> 
> 

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Laurent Vivier May 13, 2021, 3:46 p.m. UTC | #4 
Le 11/05/2021 à 12:41, Philippe Mathieu-Daudé a écrit :
> Trivial patches to keep VirtIOFeature arrays read-only
> (better safe than sorry).
> 
> Philippe Mathieu-Daudé (3):
>   hw/virtio: Pass virtio_feature_get_config_size() a const argument
>   virtio-blk: Constify VirtIOFeature feature_sizes[]
>   virtio-net: Constify VirtIOFeature feature_sizes[]
> 
>  include/hw/virtio/virtio.h | 2 +-
>  hw/block/virtio-blk.c      | 2 +-
>  hw/net/virtio-net.c        | 2 +-
>  hw/virtio/virtio.c         | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 

Series applied to my trivial-patches branch.

Thanks,
Laurent