mbox series

[0/5] Revert query-netdev command for 6.0

Message ID 20210402081519.78878-1-jasowang@redhat.com
Headers show
Series Revert query-netdev command for 6.0 | expand

Message

Jason Wang April 2, 2021, 8:15 a.m. UTC 
Hi All:

Several issues has been reported for query-netdev command:

- coverity warnings of memory leak and cut-and-paste issue
- lacking of documentation for future new netdev development

Consider it's late in the rc, I would like to revert this series and
let's retry for 6.1.

Thanks

Jason Wang (5):
  Revert "net: Do not fill legacy info_str for backends"
  Revert "hmp: Use QAPI NetdevInfo in hmp_info_network"
  Revert "net: Move NetClientState.info_str to dynamic allocations"
  Revert "tests: Add tests for query-netdev command"
  Revert "qapi: net: Add query-netdev command"

 hw/net/xen_nic.c                  |   5 +-
 include/net/net.h                 |   5 +-
 include/qapi/hmp-output-visitor.h |  30 -----
 net/l2tpv3.c                      |   8 +-
 net/net.c                         |  73 ++---------
 net/netmap.c                      |   7 --
 net/slirp.c                       | 124 +------------------
 net/socket.c                      |  92 ++++----------
 net/tap-win32.c                   |  10 +-
 net/tap.c                         | 107 ++---------------
 net/vde.c                         |  25 +---
 net/vhost-user.c                  |  20 +---
 net/vhost-vdpa.c                  |  15 +--
 qapi/hmp-output-visitor.c         | 193 ------------------------------
 qapi/meson.build                  |   1 -
 qapi/net.json                     |  80 -------------
 tests/qtest/meson.build           |   3 -
 tests/qtest/test-query-netdev.c   | 120 -------------------
 18 files changed, 62 insertions(+), 856 deletions(-)
 delete mode 100644 include/qapi/hmp-output-visitor.h
 delete mode 100644 qapi/hmp-output-visitor.c
 delete mode 100644 tests/qtest/test-query-netdev.c

Comments

Jason Wang April 6, 2021, 4:05 a.m. UTC | #1 
在 2021/4/2 下午4:15, Jason Wang 写道:
> Hi All:
>
> Several issues has been reported for query-netdev command:
>
> - coverity warnings of memory leak and cut-and-paste issue
> - lacking of documentation for future new netdev development
>
> Consider it's late in the rc, I would like to revert this series and
> let's retry for 6.1.


Applied.

Thanks


>
> Thanks
>
> Jason Wang (5):
>    Revert "net: Do not fill legacy info_str for backends"
>    Revert "hmp: Use QAPI NetdevInfo in hmp_info_network"
>    Revert "net: Move NetClientState.info_str to dynamic allocations"
>    Revert "tests: Add tests for query-netdev command"
>    Revert "qapi: net: Add query-netdev command"
>
>   hw/net/xen_nic.c                  |   5 +-
>   include/net/net.h                 |   5 +-
>   include/qapi/hmp-output-visitor.h |  30 -----
>   net/l2tpv3.c                      |   8 +-
>   net/net.c                         |  73 ++---------
>   net/netmap.c                      |   7 --
>   net/slirp.c                       | 124 +------------------
>   net/socket.c                      |  92 ++++----------
>   net/tap-win32.c                   |  10 +-
>   net/tap.c                         | 107 ++---------------
>   net/vde.c                         |  25 +---
>   net/vhost-user.c                  |  20 +---
>   net/vhost-vdpa.c                  |  15 +--
>   qapi/hmp-output-visitor.c         | 193 ------------------------------
>   qapi/meson.build                  |   1 -
>   qapi/net.json                     |  80 -------------
>   tests/qtest/meson.build           |   3 -
>   tests/qtest/test-query-netdev.c   | 120 -------------------
>   18 files changed, 62 insertions(+), 856 deletions(-)
>   delete mode 100644 include/qapi/hmp-output-visitor.h
>   delete mode 100644 qapi/hmp-output-visitor.c
>   delete mode 100644 tests/qtest/test-query-netdev.c
>