mbox series

[0/4] ui: improve precision of VNC desktop resizing

Message ID 20210311182957.486939-1-berrange@redhat.com
Headers show
Series ui: improve precision of VNC desktop resizing | expand

Message

Daniel P. Berrangé March 11, 2021, 6:29 p.m. UTC 
Currently when resizing the VNC desktop we get a thin black bar down the
right hand side of the screen 93% of the time, because the VNC server
rounds up the display to a multiple of 16. This series solves this
problem by fixing the separation between the server surface dimensions
(which are important for dirty bitmap tracking) and the client desktop
size (which is what the client actually renders).

Daniel P. Berrangé (4):
  ui: add more trace points for VNC client/server messages
  ui: avoid sending framebuffer updates outside client desktop bounds
  ui: use client width/height in WMVi message
  ui: honour the actual guest display dimensions without rounding

 ui/trace-events | 16 ++++++++++++++++
 ui/vnc-jobs.c   | 44 ++++++++++++++++++++++++++++++++++++++++----
 ui/vnc.c        | 48 ++++++++++++++++++++++++++++++++++++++++--------
 ui/vnc.h        |  1 +
 4 files changed, 97 insertions(+), 12 deletions(-)

Comments

Gerd Hoffmann March 12, 2021, 10:36 a.m. UTC | #1 
On Thu, Mar 11, 2021 at 06:29:53PM +0000, Daniel P. Berrangé wrote:
> Currently when resizing the VNC desktop we get a thin black bar down the
> right hand side of the screen 93% of the time, because the VNC server
> rounds up the display to a multiple of 16. This series solves this
> problem by fixing the separation between the server surface dimensions
> (which are important for dirty bitmap tracking) and the client desktop
> size (which is what the client actually renders).
> 
> Daniel P. Berrangé (4):
>   ui: add more trace points for VNC client/server messages
>   ui: avoid sending framebuffer updates outside client desktop bounds
>   ui: use client width/height in WMVi message
>   ui: honour the actual guest display dimensions without rounding

Added to ui patch queue.

thanks,
  Gerd