From patchwork Wed Mar 3 21:46:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 1446894 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=CTbMElCN; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DrSKG52xbz9sR4 for ; Thu, 4 Mar 2021 08:47:46 +1100 (AEDT) Received: from localhost ([::1]:49328 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHZLM-0002ma-IK for incoming@patchwork.ozlabs.org; Wed, 03 Mar 2021 16:47:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43666) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHZKv-0002ln-Vz; Wed, 03 Mar 2021 16:47:18 -0500 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]:43100) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHZKs-00023G-NH; Wed, 03 Mar 2021 16:47:16 -0500 Received: by mail-wr1-x42d.google.com with SMTP id w11so25340443wrr.10; Wed, 03 Mar 2021 13:47:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=1BaoAdExj6YRv7tms7y+nWAE3grOuJDNl0g6v2cn370=; b=CTbMElCNFd3kzKfBoNZ9l2kkocibYVYTec9Yj3YpR7xU91uwqq9ZX4wkhuhO8R4GUD ygaWFXW2MeSmbIRlS2zUzQJGQU+Jv6Y28jmSFi47cD25c5/ePw53WNhbdKsNR4CsSH6y yj3S36vnGOnnlwAmgYcwE+BHif60Bl34I4XhuDe0odU93yP3sdDQc/CbIwlL1JknhC8V rwckDWevZ9jhdUTk7la/44Dd+MZn5azyrf4ZieECWiAeuJOQBD2BEMCUSe7ZSmB5dxRl asTGMSy3NH3+unc9G2905YP9hNk+vv7KZ38s+eAM1ZTggwHbJKS9etUgRuyQnsW5D2jB aWhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=1BaoAdExj6YRv7tms7y+nWAE3grOuJDNl0g6v2cn370=; b=EhV2sidd8g+jZFHdt4E57uSHLnHoCaVhV7+ASzszzQX7Pq1+XebrXl53wqLseKbpCA l/hqPenplOny1GGq2iu6eYLsEtaZYPJU6gBZkG4UVC9vzVzflmcfZzTVRM8F1EgO+A08 8HSSohL6uUMacqXCDldtVDP1FAE1/oTD1r09L+u1/HNqG5WKSGueIFUHoKJCogkHsRkF rieoq5IM7vYtFKqzvr0iNkKRuiqfyPVWPDtaAolsZ6bOzg5+gfuqznLk661C1yQZFhy2 7FxKOCk08TteZ4ictRFNb4wye+t0/yqgI1CD+WWKfFF70w/P4hl+QMXIEWfSJWn1pXeF Z22A== X-Gm-Message-State: AOAM530Cot9UkkK/6EI/t91f/TUKUqRdq24awt9oeXN/HKbzIkpz01WL L+OwW6KFjoBdOJWOgzav+95klLT8q5g= X-Google-Smtp-Source: ABdhPJwD3Hdi9EbcVkN4LjMz1QFpr5AoWtN2XMirdefd0SY1etAbXF56toM1YzNZhSnBdVIw7P2fIw== X-Received: by 2002:a5d:4cd1:: with SMTP id c17mr789229wrt.168.1614808030644; Wed, 03 Mar 2021 13:47:10 -0800 (PST) Received: from x1w.redhat.com (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id 21sm7280767wme.6.2021.03.03.13.47.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 13:47:09 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v4 00/28] cpu: Introduce SysemuCPUOps structure, remove watchpoints from usermode Date: Wed, 3 Mar 2021 22:46:40 +0100 Message-Id: <20210303214708.1727801-1-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x42d.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , Cornelia Huck , Richard Henderson , Laurent Vivier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, Claudio Fontana , Paolo Bonzini , =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Hi, This series is inspired on Claudio TCG work. Instead of separate TCG from other accelerators, here we separate sysemu operations (system VS user). Patches 1-6 are generic cleanups. Patches 7-15 move from CPUClass to SysemuCPUOps Patch 16 restricts SysemuCPUOps to sysemu Patches 17-26 remove watchpoint code from user emulation Patches 27-28 remove USER_ONLY #ifdef'ry from "cpu.h" Since v3: - SysemuCPUOps const (Richard) - added missing xtensa #ifdef'ry - added missing aa64/sve #ifdef'ry - added Laurent R-b Since v2: - fixed lm32/unicore32 - remove USER_ONLY ifdef'ry from "cpu.h" (Claudio) Since v1: - Name 'sysemu' (Claudio) - change each field progressively (Richard) $ git backport-diff -u v3 Key: [----] : patches are identical [####] : number of functional differences between upstream/downstream patch [down] : patch is downstream-only The flags [FC] indicate (F)unctional and (C)ontextual differences, respective= ly 001/28:[----] [--] 'target: Set CPUClass::vmsd instead of DeviceClass::vmsd' 002/28:[----] [--] 'cpu: Un-inline cpu_get_phys_page_debug and cpu_asidx_from= _attrs' 003/28:[----] [--] 'cpu: Introduce cpu_virtio_is_big_endian()' 004/28:[----] [--] 'cpu: Directly use cpu_write_elf*() fallback handlers in p= lace' 005/28:[----] [--] 'cpu: Directly use get_paging_enabled() fallback handlers = in place' 006/28:[----] [--] 'cpu: Directly use get_memory_mapping() fallback handlers = in place' 007/28:[0044] [FC] 'cpu: Introduce SysemuCPUOps structure' 008/28:[----] [-C] 'cpu: Move CPUClass::vmsd to SysemuCPUOps' 009/28:[----] [-C] 'cpu: Move CPUClass::virtio_is_big_endian to SysemuCPUOps' 010/28:[----] [-C] 'cpu: Move CPUClass::get_crash_info to SysemuCPUOps' 011/28:[----] [-C] 'cpu: Move CPUClass::write_elf* to SysemuCPUOps' 012/28:[----] [-C] 'cpu: Move CPUClass::asidx_from_attrs to SysemuCPUOps' 013/28:[----] [-C] 'cpu: Move CPUClass::get_phys_page_debug to SysemuCPUOps' 014/28:[----] [-C] 'cpu: Move CPUClass::get_memory_mapping to SysemuCPUOps' 015/28:[----] [-C] 'cpu: Move CPUClass::get_paging_enabled to SysemuCPUOps' 016/28:[----] [--] 'cpu: Restrict "hw/core/sysemu-cpu-ops.h" to target/cpu.c' 017/28:[----] [--] 'linux-user: Remove dead code' 018/28:[----] [--] 'gdbstub: Remove watchpoint dead code in gdbserver_fork()' 019/28:[----] [--] 'target/arm/internals: Fix code style for checkpatch.pl' 020/28:[----] [--] 'target/arm: Move code blocks around' 021/28:[----] [--] 'target/arm: Refactor some function bodies' 022/28:[0012] [FC] 'target/arm: Restrict watchpoint code to system emulation' 023/28:[----] [--] 'target/i386: Restrict watchpoint code to system emulation' 024/28:[down] 'target/xtensa: Restrict watchpoint code to system emulation' 025/28:[----] [--] 'accel/tcg/cpu-exec: Restrict watchpoint code to system em= ulation' 026/28:[----] [--] 'cpu: Remove watchpoint stubs for user emulation' 027/28:[----] [--] 'cpu: Fix code style for checkpatch.pl' 028/28:[----] [--] 'cpu: Move sysemu specific declarations to 'sysemu-cpu-ops= .h'' Regards, Phil. Philippe Mathieu-Daud=C3=A9 (28): target: Set CPUClass::vmsd instead of DeviceClass::vmsd cpu: Un-inline cpu_get_phys_page_debug and cpu_asidx_from_attrs cpu: Introduce cpu_virtio_is_big_endian() cpu: Directly use cpu_write_elf*() fallback handlers in place cpu: Directly use get_paging_enabled() fallback handlers in place cpu: Directly use get_memory_mapping() fallback handlers in place cpu: Introduce SysemuCPUOps structure cpu: Move CPUClass::vmsd to SysemuCPUOps cpu: Move CPUClass::virtio_is_big_endian to SysemuCPUOps cpu: Move CPUClass::get_crash_info to SysemuCPUOps cpu: Move CPUClass::write_elf* to SysemuCPUOps cpu: Move CPUClass::asidx_from_attrs to SysemuCPUOps cpu: Move CPUClass::get_phys_page_debug to SysemuCPUOps cpu: Move CPUClass::get_memory_mapping to SysemuCPUOps cpu: Move CPUClass::get_paging_enabled to SysemuCPUOps cpu: Restrict "hw/core/sysemu-cpu-ops.h" to target/cpu.c linux-user: Remove dead code gdbstub: Remove watchpoint dead code in gdbserver_fork() target/arm/internals: Fix code style for checkpatch.pl target/arm: Move code blocks around target/arm: Refactor some function bodies target/arm: Restrict watchpoint code to system emulation target/i386: Restrict watchpoint code to system emulation target/xtensa: Restrict watchpoint code to system emulation accel/tcg/cpu-exec: Restrict watchpoint code to system emulation cpu: Remove watchpoint stubs for user emulation cpu: Fix code style for checkpatch.pl cpu: Move sysemu specific declarations to 'sysemu-cpu-ops.h' include/hw/core/cpu.h | 258 +------------------------------ include/hw/core/sysemu-cpu-ops.h | 244 +++++++++++++++++++++++++++++ target/alpha/cpu.h | 3 + target/arm/cpu.h | 3 + target/arm/internals.h | 34 ++-- target/avr/cpu.h | 1 + target/cris/cpu.h | 3 + target/hexagon/cpu.h | 3 + target/hppa/cpu.h | 3 + target/i386/cpu.h | 3 + target/lm32/cpu.h | 3 + target/m68k/cpu.h | 3 + target/microblaze/cpu.h | 1 + target/mips/cpu.h | 3 + target/moxie/cpu.h | 3 + target/nios2/cpu.h | 1 + target/openrisc/cpu.h | 3 + target/ppc/cpu.h | 3 + target/riscv/cpu.h | 3 + target/rx/cpu.h | 1 + target/s390x/cpu.h | 3 + target/sh4/cpu.h | 3 + target/sparc/cpu.h | 3 + target/tilegx/cpu.h | 3 + target/tricore/cpu.h | 3 + target/unicore32/cpu.h | 3 + target/xtensa/cpu.h | 3 + accel/tcg/cpu-exec.c | 5 +- cpu.c | 19 ++- gdbstub.c | 2 +- hw/core/cpu.c | 113 ++++++++------ hw/virtio/virtio.c | 4 +- linux-user/main.c | 5 - softmmu/physmem.c | 1 + target/alpha/cpu.c | 10 +- target/arm/cpu.c | 22 ++- target/arm/debug_helper.c | 102 ++++++------ target/arm/helper.c | 9 +- target/arm/sve_helper.c | 12 ++ target/avr/cpu.c | 8 +- target/cris/cpu.c | 10 +- target/hppa/cpu.c | 10 +- target/i386/cpu.c | 31 ++-- target/lm32/cpu.c | 10 +- target/m68k/cpu.c | 10 +- target/microblaze/cpu.c | 10 +- target/mips/cpu.c | 10 +- target/moxie/cpu.c | 10 +- target/nios2/cpu.c | 15 +- target/openrisc/cpu.c | 10 +- target/riscv/cpu.c | 12 +- target/rx/cpu.c | 16 +- target/s390x/cpu.c | 14 +- target/sh4/cpu.c | 10 +- target/sparc/cpu.c | 10 +- target/tricore/cpu.c | 13 +- target/unicore32/cpu.c | 8 +- target/xtensa/cpu.c | 10 +- target/xtensa/helper.c | 4 + target/ppc/translate_init.c.inc | 20 +-- 60 files changed, 702 insertions(+), 453 deletions(-) create mode 100644 include/hw/core/sysemu-cpu-ops.h --=20 2.26.2 Reviewed-by: Richard Henderson