mbox series

[0/2] hw/block/nvme: add support for telemetry log pages

Message ID 20210208141012.377500-1-its@irrelevant.dk
Headers show
Series hw/block/nvme: add support for telemetry log pages | expand

Message

Klaus Jensen Feb. 8, 2021, 2:10 p.m. UTC 
From: Klaus Jensen <k.jensen@samsung.com>

This adds support for the telemetry log pages and fixes up the
controller IEEE OUI.

Gollu Appalanaidu (2):
  hw/block/nvme: use locally assigned QEMU IEEE OUI
  hw/block/nvme: add nvme telemetry log support

 include/block/nvme.h  | 23 ++++++++++++++++++++---
 hw/block/nvme.c       | 37 ++++++++++++++++++++++++++++++++++---
 hw/block/trace-events |  1 +
 3 files changed, 55 insertions(+), 6 deletions(-)

Comments

Klaus Jensen Feb. 8, 2021, 5:47 p.m. UTC | #1 
On Feb  9 00:40, Keith Busch wrote:
> On Mon, Feb 08, 2021 at 03:10:10PM +0100, Klaus Jensen wrote:
> > From: Klaus Jensen <k.jensen@samsung.com>
> > 
> > This adds support for the telemetry log pages and fixes up the
> > controller IEEE OUI.
> 
> Patch 1 is fine.
> 
> I don't see the point for patch 2. We don't need an empty implementation
> for every optional spec feature just because it's there. The features
> we do implement ought to provide something useful, yeah?

Alright, point taken :)