From patchwork Tue Oct 27 17:35:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 1388817 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=e9zyN4cm; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4CLJm03Rj1z9sRK for ; Wed, 28 Oct 2020 04:36:32 +1100 (AEDT) Received: from localhost ([::1]:39572 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXSta-0005H0-D4 for incoming@patchwork.ozlabs.org; Tue, 27 Oct 2020 13:36:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41330) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXSt2-0005Eq-D6 for qemu-devel@nongnu.org; Tue, 27 Oct 2020 13:35:56 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:30823) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kXSsz-0003Cv-Be for qemu-devel@nongnu.org; Tue, 27 Oct 2020 13:35:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603820152; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=f+L2aCyA9GfwtcVWRDGciGhPz9jHG8g9WOW0iydMLc4=; b=e9zyN4cmUdq19ElI9LdhpD/WBGUSHaUrelux7ogC2MuGwzMdtyrOk55m7vyMd8CVmtFMMe /QmlqajgHs5szx90+z0FT4/c4fRV/J1ZcgbtIHpUcClYFYiExXv5DHeGUzRURoSs8K5pK0 hiMZvODIdxzgCMjoSwFXz2va9nLOMQE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-478-nnYagcysNjS5gPwzAEAkEw-1; Tue, 27 Oct 2020 13:35:50 -0400 X-MC-Unique: nnYagcysNjS5gPwzAEAkEw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 251DB873112; Tue, 27 Oct 2020 17:35:49 +0000 (UTC) Received: from localhost (ovpn-115-166.ams2.redhat.com [10.36.115.166]) by smtp.corp.redhat.com (Postfix) with ESMTP id EADC96EF50; Tue, 27 Oct 2020 17:35:29 +0000 (UTC) From: Stefan Hajnoczi To: qemu-devel@nongnu.org Subject: [PATCH 00/12] block/export: vhost-user-blk server cleanups and tests Date: Tue, 27 Oct 2020 17:35:16 +0000 Message-Id: <20201027173528.213464-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=63.128.21.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/27 01:06:07 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Kevin Wolf , Thomas Huth , qemu-block@nongnu.org, "Michael S. Tsirkin" , Coiby Xu , Raphael Norwitz , Stefan Hajnoczi , Paolo Bonzini , Max Reitz Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" This patch series solves some issues with the new vhost-user-blk-server and adds the qtest test case. The test case was not included in the pull request that introduced the vhost-user-blk server because of reliability issues that are fixed in this patch series. Coiby Xu (1): test: new qTest case to test the vhost-user-blk-server Stefan Hajnoczi (11): libvhost-user: follow QEMU comment style configure: introduce --enable-vhost-user-blk-server block/export: make vhost-user-blk config space little-endian block/export: fix vhost-user-blk get_config() information leak contrib/vhost-user-blk: fix get_config() information leak tests/qtest: add multi-queue test case to vhost-user-blk-test libqtest: add qtest_socket_server() vhost-user-blk-test: rename destroy_drive() to destroy_file() vhost-user-blk-test: close fork child file descriptors vhost-user-blk-test: drop unused return value vhost-user-blk-test: fix races by using fd passing configure | 15 + contrib/libvhost-user/libvhost-user.h | 15 +- tests/qtest/libqos/libqtest.h | 25 + tests/qtest/libqos/vhost-user-blk.h | 48 ++ block/export/export.c | 4 +- block/export/vhost-user-blk-server.c | 28 +- contrib/vhost-user-blk/vhost-user-blk.c | 2 + tests/qtest/libqos/vhost-user-blk.c | 129 ++++ tests/qtest/libqtest.c | 76 ++- tests/qtest/vhost-user-blk-test.c | 843 ++++++++++++++++++++++++ block/export/meson.build | 2 +- tests/qtest/libqos/meson.build | 1 + tests/qtest/meson.build | 2 + util/meson.build | 2 +- 14 files changed, 1151 insertions(+), 41 deletions(-) create mode 100644 tests/qtest/libqos/vhost-user-blk.h create mode 100644 tests/qtest/libqos/vhost-user-blk.c create mode 100644 tests/qtest/vhost-user-blk-test.c