mbox series

[0/3] spapr NVDIMM: consider 'nvdimm' machine option

Message ID 20200825215749.213536-1-danielhb413@gmail.com
Headers show
Series spapr NVDIMM: consider 'nvdimm' machine option | expand

Message

Daniel Henrique Barboza Aug. 25, 2020, 9:57 p.m. UTC 
This series aims to solve bug [1].

First patch is a trivial cleanup, feel free to squash into
patch 02. Patch 02 attempts a code simplification to put
all NVDIMM related logic in the same function.

Patch 03 is where the actual fix is implemented. My initial
approach here was to make the handling of '-machine nvdimm' for
pSeries similar to how it is handled elsewhere, but I wasn't
able to accomplish that without either (1) breaking up existing
pseries-5.1 guests that didn't care about this option or (2)
make pseries-5.1 and pseries-5.2+ machines to have different
semantics for it.

I ended up doing what I was sure was sensible: if the user puts
'-machine nvdimm=off', we must comply to that.


[1] https://bugzilla.redhat.com/show_bug.cgi?id=1848887

Daniel Henrique Barboza (3):
  ppc/spapr_nvdimm: use g_autofree in spapr_nvdimm_validate_opts()
  spapr, spapr_nvdimm: fold NVDIMM validation in the same place
  ppc/spapr_nvdimm: do not enable support with 'nvdimm=off'

 hw/ppc/spapr.c                | 18 ++++++------------
 hw/ppc/spapr_nvdimm.c         | 31 +++++++++++++++++++++++++++----
 include/hw/ppc/spapr_nvdimm.h |  4 ++--
 3 files changed, 35 insertions(+), 18 deletions(-)

Comments

David Gibson Aug. 28, 2020, 1:17 p.m. UTC | #1 
On Tue, Aug 25, 2020 at 06:57:46PM -0300, Daniel Henrique Barboza wrote:
> This series aims to solve bug [1].
> 
> First patch is a trivial cleanup, feel free to squash into
> patch 02. Patch 02 attempts a code simplification to put
> all NVDIMM related logic in the same function.
> 
> Patch 03 is where the actual fix is implemented. My initial
> approach here was to make the handling of '-machine nvdimm' for
> pSeries similar to how it is handled elsewhere, but I wasn't
> able to accomplish that without either (1) breaking up existing
> pseries-5.1 guests that didn't care about this option or (2)
> make pseries-5.1 and pseries-5.2+ machines to have different
> semantics for it.
> 
> I ended up doing what I was sure was sensible: if the user puts
> '-machine nvdimm=off', we must comply to that.

Applied to ppc-for-5.2, thanks.

> 
> 
> [1] https://bugzilla.redhat.com/show_bug.cgi?id=1848887
> 
> Daniel Henrique Barboza (3):
>   ppc/spapr_nvdimm: use g_autofree in spapr_nvdimm_validate_opts()
>   spapr, spapr_nvdimm: fold NVDIMM validation in the same place
>   ppc/spapr_nvdimm: do not enable support with 'nvdimm=off'
> 
>  hw/ppc/spapr.c                | 18 ++++++------------
>  hw/ppc/spapr_nvdimm.c         | 31 +++++++++++++++++++++++++++----
>  include/hw/ppc/spapr_nvdimm.h |  4 ++--
>  3 files changed, 35 insertions(+), 18 deletions(-)
>