| Message ID | 1531470464-21522-1-git-send-email-thuth@redhat.com |
|---|---|
| Headers | show |
| Series | Fix crashes with introspection of ARM devices | expand |
On 07/13/2018 03:27 AM, Thomas Huth wrote: > v2: > - Updated the first patch according to the review feedback from v1 > - Added more patches with additional fixes > > Thomas Huth (16): > qom/object: Add a new function object_initialize_child() > hw/core/sysbus: Add a function for creating and attaching an object > hw/arm/bcm2836: Fix crash with device_add bcm2837 on unsupported > machines > hw/arm/armv7: Fix crash when introspecting the "iotkit" device > hw/cpu/a15mpcore: Fix introspection problem with the a15mpcore_priv > device > hw/display/xlnx_dp: Move problematic code from instance_init to > realize > hw/arm/xlnx-zynqmp: Fix crash when introspecting the "xlnx,zynqmp" > device > hw/arm/msf2-soc: Fix introspection problem with the "msf2-soc" device > hw/cpu/a9mpcore: Fix introspection problems with the "a9mpcore_priv" > device > hw/arm/fsl-imx6: Fix introspection problems with the "fsl,imx6" device > hw/arm/fsl-imx7: Fix introspection problems with the "fsl,imx7" device > hw/arm/fsl-imx25: Fix introspection problem with the "fsl,imx25" > device > hw/arm/fsl-imx31: Fix introspection problem with the "fsl,imx31" > device > hw/cpu/arm11mpcore: Fix introspection problem with 'arm11mpcore_priv' > hw/*/realview: Fix introspection problem with 'realview_mpcore' & > 'realview_gic' > hw/arm/allwinner-a10: Fix introspection problem with 'allwinner-a10' That is a great cleanup. Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
On Fri, Jul 13, 2018 at 10:27:28AM +0200, Thomas Huth wrote: > As discovered recently, you can crash QEMU with a lot of devices > that do not get the reference counting of child objects right. > You just have to run 'device-list-properties' and call 'info qtree' > afterwards. > This patch series fixes a bunch of these problems in the ARM code. > I did not fix all problems yet, since it is quite time consuming, > and this series is big enough already. The remaining problems can > be fixed in an independent patch series later. > > v2: > - Updated the first patch according to the review feedback from v1 > - Added more patches with additional fixes OK, I will stop replying to each individual patch and just send a single one for the series: Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
As discovered recently, you can crash QEMU with a lot of devices that do not get the reference counting of child objects right. You just have to run 'device-list-properties' and call 'info qtree' afterwards. This patch series fixes a bunch of these problems in the ARM code. I did not fix all problems yet, since it is quite time consuming, and this series is big enough already. The remaining problems can be fixed in an independent patch series later. v2: - Updated the first patch according to the review feedback from v1 - Added more patches with additional fixes Thomas Huth (16): qom/object: Add a new function object_initialize_child() hw/core/sysbus: Add a function for creating and attaching an object hw/arm/bcm2836: Fix crash with device_add bcm2837 on unsupported machines hw/arm/armv7: Fix crash when introspecting the "iotkit" device hw/cpu/a15mpcore: Fix introspection problem with the a15mpcore_priv device hw/display/xlnx_dp: Move problematic code from instance_init to realize hw/arm/xlnx-zynqmp: Fix crash when introspecting the "xlnx,zynqmp" device hw/arm/msf2-soc: Fix introspection problem with the "msf2-soc" device hw/cpu/a9mpcore: Fix introspection problems with the "a9mpcore_priv" device hw/arm/fsl-imx6: Fix introspection problems with the "fsl,imx6" device hw/arm/fsl-imx7: Fix introspection problems with the "fsl,imx7" device hw/arm/fsl-imx25: Fix introspection problem with the "fsl,imx25" device hw/arm/fsl-imx31: Fix introspection problem with the "fsl,imx31" device hw/cpu/arm11mpcore: Fix introspection problem with 'arm11mpcore_priv' hw/*/realview: Fix introspection problem with 'realview_mpcore' & 'realview_gic' hw/arm/allwinner-a10: Fix introspection problem with 'allwinner-a10' hw/arm/allwinner-a10.c | 19 +++++----- hw/arm/armv7m.c | 7 ++-- hw/arm/bcm2836.c | 18 +++------ hw/arm/fsl-imx25.c | 30 +++++++-------- hw/arm/fsl-imx31.c | 26 ++++++------- hw/arm/fsl-imx6.c | 56 ++++++++++------------------ hw/arm/fsl-imx7.c | 96 ++++++++++++++++-------------------------------- hw/arm/iotkit.c | 74 ++++++++++++++++--------------------- hw/arm/msf2-soc.c | 15 ++++---- hw/arm/xlnx-zynqmp.c | 61 ++++++++++++++---------------- hw/core/sysbus.c | 8 ++++ hw/cpu/a15mpcore.c | 8 ++-- hw/cpu/a9mpcore.c | 18 ++++----- hw/cpu/arm11mpcore.c | 14 +++---- hw/cpu/realview_mpcore.c | 8 ++-- hw/display/xlnx_dp.c | 23 +++++------- hw/intc/armv7m_nvic.c | 5 +-- hw/intc/realview_gic.c | 7 +--- include/hw/sysbus.h | 3 ++ include/qom/object.h | 23 +++++++++++- qom/object.c | 15 ++++++++ 21 files changed, 244 insertions(+), 290 deletions(-)