From patchwork Thu Apr 16 17:54:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Daniel M. Weeks" X-Patchwork-Id: 1271824 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4936Q52YwCz9sWM for ; Fri, 17 Apr 2020 03:57:49 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=rpi.edu Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4936Q45qHXzDsG2 for ; Fri, 17 Apr 2020 03:57:48 +1000 (AEST) X-Original-To: petitboot@lists.ozlabs.org Delivered-To: petitboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=rpi.edu (client-ip=128.113.2.229; helo=smtp9.server.rpi.edu; envelope-from=weeksd2@rpi.edu; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=rpi.edu Received: from smtp9.server.rpi.edu (smtp9.server.rpi.edu [128.113.2.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4936LF1kHrzDrR2 for ; Fri, 17 Apr 2020 03:54:28 +1000 (AEST) Received: from smtp-auth3.server.rpi.edu (route.canit.rpi.edu [128.113.2.233]) by smtp9.server.rpi.edu (8.14.4/8.14.4/Debian-8+deb8u2) with ESMTP id 03GHsM44115806 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 16 Apr 2020 13:54:23 -0400 Received: from smtp-auth3.server.rpi.edu (localhost [127.0.0.1]) by smtp-auth3.server.rpi.edu (Postfix) with ESMTP id B000458099 for ; Thu, 16 Apr 2020 13:54:22 -0400 (EDT) Received: from dev.danweeks.net (cpe-74-70-107-6.nycap.res.rr.com [74.70.107.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: weeksd2) by smtp-auth3.server.rpi.edu (Postfix) with ESMTPSA id 909DE5804D for ; Thu, 16 Apr 2020 13:54:22 -0400 (EDT) Date: Thu, 16 Apr 2020 13:54:18 -0400 From: "Daniel M. Weeks" To: petitboot@lists.ozlabs.org Subject: [PATCH 03/11] Use hwsize rather than HWADDR_SIZE Message-ID: <55f2711b818b0d5aa535b74ec514058c0738dba0.1587059210.git.weeksd2@rpi.edu> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Virus-Scanned: ClamAV using ClamSMTP X-Bayes-Prob: 0.0001 (Score 0, tokens from: outgoing, @@RPTN) X-Spam-Score: 0.00 () [Hold at 10.10] X-CanIt-Incident-Id: 022rtSm9S X-CanIt-Geo: ip=74.70.107.6; country=US; region=New York; city=Troy; latitude=42.7273; longitude=-73.6696; http://maps.google.com/maps?q=42.7273,-73.6696&z=6 X-CanItPRO-Stream: outgoing X-Canit-Stats-ID: Bayes signature not available X-Scanned-By: CanIt (www . roaringpenguin . com) on 128.113.2.229 X-BeenThere: petitboot@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Petitboot bootloader development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: petitboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Petitboot" This is mainly housekeeping in the interest of future flexibility. For now, hwsize is still required to be HWADDR_SIZE. Signed-off-by: Daniel M. Weeks --- discover/network.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/discover/network.c b/discover/network.c index 041367f..62df720 100644 --- a/discover/network.c +++ b/discover/network.c @@ -684,7 +684,7 @@ void network_mark_interface_ready(struct device_handler *handler, interface = talloc_zero(network, struct interface); interface->ifindex = ifindex; interface->state = IFSTATE_NEW; - memcpy(interface->hwaddr, mac, HWADDR_SIZE); + memcpy(interface->hwaddr, mac, hwsize); strncpy(interface->name, ifname, sizeof(interface->name) - 1); list_for_each_entry(&network->interfaces, tmp, list) @@ -713,7 +713,7 @@ void network_mark_interface_ready(struct device_handler *handler, talloc_strdup(interface->dev->device, ifname); } - if (memcmp(interface->hwaddr, mac, HWADDR_SIZE) != 0) { + if (memcmp(interface->hwaddr, mac, hwsize) != 0) { macstr = mac_bytes_to_string(interface, mac, hwsize); pb_log("Warning - new MAC for interface %d does not match: %s\n", ifindex, macstr);