From patchwork Fri Jan 28 06:12:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amitay Isaacs X-Patchwork-Id: 1585510 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=ozlabs.org header.i=@ozlabs.org header.a=rsa-sha256 header.s=201707 header.b=ZQNs5srN; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=112.213.38.117; helo=lists.ozlabs.org; envelope-from=pdbg-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4JlRvV06Ldz9t56 for ; Fri, 28 Jan 2022 17:12:37 +1100 (AEDT) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4JlRvT3swkz3bTH for ; Fri, 28 Jan 2022 17:12:37 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=ozlabs.org header.i=@ozlabs.org header.a=rsa-sha256 header.s=201707 header.b=ZQNs5srN; dkim-atps=neutral X-Original-To: pdbg@lists.ozlabs.org Delivered-To: pdbg@lists.ozlabs.org Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [IPv6:2404:9400:2:0:216:3eff:fee2:21ea]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4JlRvP0Fd2z30Mn for ; Fri, 28 Jan 2022 17:12:33 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=ozlabs.org header.i=@ozlabs.org header.a=rsa-sha256 header.s=201707 header.b=ZQNs5srN; dkim-atps=neutral Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4JlRvN53Fhz4xcY; Fri, 28 Jan 2022 17:12:32 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ozlabs.org; s=201707; t=1643350352; bh=aobJKzRmRr5Lm0WcePujcdsfkZCYday5d1OzKrmcprI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZQNs5srNVJ5PFIX4vONyEdMI2EXSW3VD7mLdHm76I0m/kV+n97beQKN7A8PFAXz2J Vqahf1iEqUpaVdT6aHhZ4ACMKjz3y53sjztJI994mIO+aFjWj8cl3EVj1eoKBeWKCE xOowoKdfFQvChUhRkRlEyMm/ay6Fyvb+yAjnvnstFbb67+/njN4uZNCgAsDUgD/C3h 0IkCRE7k1UZS7b+Y+QUCPCew0JAFEXoNKRystrrDki8LXCYfBGWuyss/QVVEiLmpuY bOqXyJa8FSZZ1ct980vxVZMeiotcElSm0zrqvdXQ8J8ew7zFzrhCC+ISQ2cRdwDQg1 u1B9Xko48myyA== From: Amitay Isaacs To: pdbg@lists.ozlabs.org Date: Fri, 28 Jan 2022 17:12:21 +1100 Message-Id: <20220128061221.1054173-4-amitay@ozlabs.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220128061221.1054173-1-amitay@ozlabs.org> References: <20220128061221.1054173-1-amitay@ozlabs.org> MIME-Version: 1.0 Subject: [Pdbg] [PATCH 3/3] libpdbg: For p10 do not assert special wakeup for core by default X-BeenThere: pdbg@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "mailing list for https://github.com/open-power/pdbg development" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Amitay Isaacs Errors-To: pdbg-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Pdbg" For p10 systems, the default behaviour (for long running bmc applications) of libpdbg is to not assert special wakeup, as the applications are not supposed to use special wakeup. So only assert special wakeup if running short applications such as pdbg tool. Signed-off-by: Amitay Isaacs --- libpdbg/p10chip.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/libpdbg/p10chip.c b/libpdbg/p10chip.c index f5c3b9f..e0d9ee2 100644 --- a/libpdbg/p10chip.c +++ b/libpdbg/p10chip.c @@ -200,6 +200,16 @@ static int p10_core_probe(struct pdbg_target *target) uint64_t value; int i = 0; + /* + * BMC applications using libpdbg, do not need special wakeup + * asserted by default. Only when running pdbg tool or equivalent + * assert special wakeup. + */ + if (!pdbg_context_is_short()) { + core->release_spwkup = false; + return 0; + } + CHECK_ERR(pib_write(target, QME_SPWU_FSP, PPC_BIT(0))); do { usleep(1000);