| Message ID | 20201221101733.912938-1-npiggin@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/3] libpdbg/p10chip: remove delay from special wakeup clearing | expand |
On Mon, 21 Dec 2020 at 10:18, Nicholas Piggin <npiggin@gmail.com> wrote: > > These were added to the p9chip in an attempt to work around some > instability. Try without them for P10, skiboot has similarly removed > the delays. > > Signed-off-by: Nicholas Piggin <npiggin@gmail.com> Reviewed-by: Joel Stanley <joel@jms.id.au> > --- > libpdbg/p10chip.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/libpdbg/p10chip.c b/libpdbg/p10chip.c > index 70067cf..f26e4ca 100644 > --- a/libpdbg/p10chip.c > +++ b/libpdbg/p10chip.c > @@ -119,8 +119,6 @@ static void p10_core_release(struct pdbg_target *target) > struct core *core = target_to_core(target); > enum pdbg_target_status status; > > - usleep(1); /* enforce small delay before and after it is cleared */ > - > /* Probe and release all threads to ensure release_spwkup is up to > * date */ > pdbg_for_each_target("thread", target, child) { > @@ -143,7 +141,6 @@ static void p10_core_release(struct pdbg_target *target) > return; > > pib_write(target, QME_SPWU_FSP, 0); > - usleep(10000); > } > > #define NUM_CORES_PER_EQ 4 > -- > 2.23.0 > > -- > Pdbg mailing list > Pdbg@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/pdbg
diff --git a/libpdbg/p10chip.c b/libpdbg/p10chip.c index 70067cf..f26e4ca 100644 --- a/libpdbg/p10chip.c +++ b/libpdbg/p10chip.c @@ -119,8 +119,6 @@ static void p10_core_release(struct pdbg_target *target) struct core *core = target_to_core(target); enum pdbg_target_status status; - usleep(1); /* enforce small delay before and after it is cleared */ - /* Probe and release all threads to ensure release_spwkup is up to * date */ pdbg_for_each_target("thread", target, child) { @@ -143,7 +141,6 @@ static void p10_core_release(struct pdbg_target *target) return; pib_write(target, QME_SPWU_FSP, 0); - usleep(10000); } #define NUM_CORES_PER_EQ 4
These were added to the p9chip in an attempt to work around some instability. Try without them for P10, skiboot has similarly removed the delays. Signed-off-by: Nicholas Piggin <npiggin@gmail.com> --- libpdbg/p10chip.c | 3 --- 1 file changed, 3 deletions(-)