| Message ID | 20190927020944.19159-1-alistair@popple.id.au |
|---|---|
| State | Accepted |
| Headers | show |
| Series | test_hw_bmc.sh: Fix path to obmcutil | expand |
Reviewed-by: Amitay Isaacs <amitay@ozlabs.org> On Fri, 2019-09-27 at 12:09 +1000, Alistair Popple wrote: > The OpenBMC project seem to have moved the obmcutil command from > /usr/sbin to /usr/bin s remove the explicit path when calling > obmcutil > to avoid issues running on different OpenBMC versions. > > Signed-off-by: Alistair Popple <alistair@popple.id.au> > --- > tests/test_hw_bmc.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/test_hw_bmc.sh b/tests/test_hw_bmc.sh > index ab6af35..e3d2e82 100755 > --- a/tests/test_hw_bmc.sh > +++ b/tests/test_hw_bmc.sh > @@ -64,7 +64,7 @@ do_skip () > > > echo -n "Checking if the host is up... " > -output=$(run_over_ssh /usr/sbin/obmcutil state | grep > CurrentHostState) > +output=$(run_over_ssh obmcutil state | grep CurrentHostState) > rc=$? > if [ $rc -ne 0 ] || \ > [ "$output" = "CurrentHostState : > xyz.openbmc_project.State.Host.HostState.Running" ] ; then > -- > 2.20.1 > Amitay.
On Fri, 2019-09-27 at 14:54 +1000, Amitay Isaacs wrote: > Reviewed-by: Amitay Isaacs <amitay@ozlabs.org> > > On Fri, 2019-09-27 at 12:09 +1000, Alistair Popple wrote: > > The OpenBMC project seem to have moved the obmcutil command from > > /usr/sbin to /usr/bin s remove the explicit path when calling Typo in the commit message.. /usr/sbin to /usr/bin, so ... > > obmcutil > > to avoid issues running on different OpenBMC versions. > > > > Signed-off-by: Alistair Popple <alistair@popple.id.au> > > --- > > tests/test_hw_bmc.sh | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tests/test_hw_bmc.sh b/tests/test_hw_bmc.sh > > index ab6af35..e3d2e82 100755 > > --- a/tests/test_hw_bmc.sh > > +++ b/tests/test_hw_bmc.sh > > @@ -64,7 +64,7 @@ do_skip () > > > > > > echo -n "Checking if the host is up... " > > -output=$(run_over_ssh /usr/sbin/obmcutil state | grep > > CurrentHostState) > > +output=$(run_over_ssh obmcutil state | grep CurrentHostState) > > rc=$? > > if [ $rc -ne 0 ] || \ > > [ "$output" = "CurrentHostState : > > xyz.openbmc_project.State.Host.HostState.Running" ] ; then > > -- > > 2.20.1 > > > > Amitay. > -- > > Art is man's attempt to improve on nature. > Amitay.
diff --git a/tests/test_hw_bmc.sh b/tests/test_hw_bmc.sh index ab6af35..e3d2e82 100755 --- a/tests/test_hw_bmc.sh +++ b/tests/test_hw_bmc.sh @@ -64,7 +64,7 @@ do_skip () echo -n "Checking if the host is up... " -output=$(run_over_ssh /usr/sbin/obmcutil state | grep CurrentHostState) +output=$(run_over_ssh obmcutil state | grep CurrentHostState) rc=$? if [ $rc -ne 0 ] || \ [ "$output" = "CurrentHostState : xyz.openbmc_project.State.Host.HostState.Running" ] ; then
The OpenBMC project seem to have moved the obmcutil command from /usr/sbin to /usr/bin s remove the explicit path when calling obmcutil to avoid issues running on different OpenBMC versions. Signed-off-by: Alistair Popple <alistair@popple.id.au> --- tests/test_hw_bmc.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)