diff mbox series

libpdbg: Change default log level to print warnings

Message ID 20190701075125.1986-1-alistair@popple.id.au
State Accepted
Headers show
Series libpdbg: Change default log level to print warnings | expand

Checks

Context Check Description
snowpatch_ozlabs/apply_patch success Successfully applied on branch master (742d66bbae8c6cc366e95e6ed663948ea028da3b)
snowpatch_ozlabs/build-multiarch success Test build-multiarch on branch master

Commit Message

Alistair Popple July 1, 2019, 7:51 a.m. UTC
The log level currently defaults to only printing errors, however
library users likely still want to know about warnings unless an
application has explicitly silenced them by changing the default log
level or setting a logging function.

Signed-off-by: Alistair Popple <alistair@popple.id.au>
---
 libpdbg/debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Amitay Isaacs July 2, 2019, 3:48 a.m. UTC | #1
Reviewed-by: Amitay Isaacs <amitay@ozlabs.org>

On Mon, 2019-07-01 at 17:51 +1000, Alistair Popple wrote:
> The log level currently defaults to only printing errors, however
> library users likely still want to know about warnings unless an
> application has explicitly silenced them by changing the default log
> level or setting a logging function.
> 
> Signed-off-by: Alistair Popple <alistair@popple.id.au>
> ---
>  libpdbg/debug.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libpdbg/debug.c b/libpdbg/debug.c
> index 64f41f6..679b035 100644
> --- a/libpdbg/debug.c
> +++ b/libpdbg/debug.c
> @@ -19,7 +19,7 @@
>  
>  #include "debug.h"
>  
> -static int pdbg_loglevel = PDBG_ERROR;
> +static int pdbg_loglevel = PDBG_WARNING;
>  
>  static void pdbg_logfunc_default(int loglevel, const char *fmt,
> va_list ap)
>  {
> -- 
> 2.11.0
> 

Amitay.
diff mbox series

Patch

diff --git a/libpdbg/debug.c b/libpdbg/debug.c
index 64f41f6..679b035 100644
--- a/libpdbg/debug.c
+++ b/libpdbg/debug.c
@@ -19,7 +19,7 @@ 
 
 #include "debug.h"
 
-static int pdbg_loglevel = PDBG_ERROR;
+static int pdbg_loglevel = PDBG_WARNING;
 
 static void pdbg_logfunc_default(int loglevel, const char *fmt, va_list ap)
 {