From patchwork Sun Mar 27 04:53:03 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeremy Kerr X-Patchwork-Id: 602248 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3qXlD45XNfz9sf6 for ; Sun, 27 Mar 2016 15:58:12 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3qXlD44nkvzDqCn for ; Sun, 27 Mar 2016 15:58:12 +1100 (AEDT) X-Original-To: patchwork@lists.ozlabs.org Delivered-To: patchwork@lists.ozlabs.org Received: from ozlabs.org (ozlabs.org [103.22.144.67]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3qXlD03PpZzDq5j for ; Sun, 27 Mar 2016 15:58:08 +1100 (AEDT) Received: by ozlabs.org (Postfix, from userid 1023) id 3qXlD02k8Yz9t0s; Sun, 27 Mar 2016 15:58:08 +1100 (AEDT) From: Jeremy Kerr To: patchwork@lists.ozlabs.org Subject: [PATCH 1/4] parsemail.sh: Always return a zero exit status Date: Sun, 27 Mar 2016 12:53:03 +0800 Message-Id: <1459054386-31394-2-git-send-email-jk@ozlabs.org> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1459054386-31394-1-git-send-email-jk@ozlabs.org> References: <1459054386-31394-1-git-send-email-jk@ozlabs.org> X-BeenThere: patchwork@lists.ozlabs.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Patchwork development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Patchwork" This reverts changes to parsemail.sh introduced by cbe992d84fba57831d44afb3a21cdf83454018b2. When parsemail is used as a delivery command from a mail server like postfix (as it is intended to be), a non-zero exit code will cause a bounce message to be returned to the user. From the postfix manual: When the command fails, a limited amount of command output is mailed back to the sender. The file /usr/include/sysexits.h defines the expected exit status codes. For cases where patchwork is unavailable, we absolutely do not want to start bouncing messages to all patch contributors. Signed-off-by: Jeremy Kerr Acked-by: Stephen Finucane --- patchwork/bin/parsemail.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/patchwork/bin/parsemail.sh b/patchwork/bin/parsemail.sh index c8220a7..9973392 100755 --- a/patchwork/bin/parsemail.sh +++ b/patchwork/bin/parsemail.sh @@ -26,4 +26,4 @@ PYTHONPATH="$PATCHWORK_BASE":"$PATCHWORK_BASE/lib/python:$PYTHONPATH" \ DJANGO_SETTINGS_MODULE=patchwork.settings.production \ "$PATCHWORK_BASE/patchwork/bin/parsemail.py" -exit $@ +exit 0