From patchwork Sat Feb 6 15:23:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?Z21pbmdjaGVuKOmZiOS+m+aYjik=?= X-Patchwork-Id: 1437012 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.136; helo=silver.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=tencent.com header.i=@tencent.com header.a=rsa-sha256 header.s=s202002 header.b=HlZuUIuY; dkim-atps=neutral Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DXx7V3m4Dz9sVq for ; Sun, 7 Feb 2021 02:30:28 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id CF5FE20463; Sat, 6 Feb 2021 15:30:24 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aKjrmUdME9sr; Sat, 6 Feb 2021 15:30:19 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 2E50B20452; Sat, 6 Feb 2021 15:30:19 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1DE68C0174; Sat, 6 Feb 2021 15:30:19 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 86C63C013A for ; Sat, 6 Feb 2021 15:30:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 744BA8704C for ; Sat, 6 Feb 2021 15:30:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1UHDSmzC3YJK for ; Sat, 6 Feb 2021 15:30:09 +0000 (UTC) X-Greylist: delayed 00:06:36 by SQLgrey-1.7.6 Received: from mail4.tencent.com (mail4.tencent.com [183.57.53.109]) by whitealder.osuosl.org (Postfix) with ESMTPS id A432B8706D for ; Sat, 6 Feb 2021 15:30:09 +0000 (UTC) Received: from EX-SZ021.tencent.com (unknown [10.28.6.73]) by mail4.tencent.com (Postfix) with ESMTP id 13769720F8; Sat, 6 Feb 2021 23:23:21 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tencent.com; s=s202002; t=1612625001; bh=ODTZI24L83SXNcvlhfeshMJcw9f6UBoxbRrJ7MOe1rs=; h=From:To:CC:Subject:Date; b=HlZuUIuYrtq30/3dwlnCNtNXk/8WhkoBJ+zI0HWkqL6GRKk2drBqYSPCcvbJwiVrs BridBFL+cvvl48eeGqKjIw6Rcjs/ZCZz3GPjoE4hqU89eaquoyP7My5ALHBPjw/tkU YQKONVoxcE+8toX35Q86zhB53IpUzj/UiTN8MHXo= Received: from EX-SZ001.tencent.com (10.28.6.13) by EX-SZ021.tencent.com (10.28.6.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Sat, 6 Feb 2021 23:23:20 +0800 Received: from EX-SZ004.tencent.com (10.28.6.25) by EX-SZ001.tencent.com (10.28.6.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Sat, 6 Feb 2021 23:23:20 +0800 Received: from EX-SZ004.tencent.com ([fe80::5deb:928d:fe5e:850d]) by EX-SZ004.tencent.com ([fe80::5deb:928d:fe5e:850d%8]) with mapi id 15.01.2106.002; Sat, 6 Feb 2021 23:23:20 +0800 From: =?utf-8?b?Z21pbmdjaGVuKOmZiOS+m+aYjik=?= To: "ovs-dev@openvswitch.org" Thread-Topic: [PATCH ovn] tests: Fix Port_Binding up test. Thread-Index: AQHW/JwAkCWUgahyh0KXbdMV8pAt/g== Date: Sat, 6 Feb 2021 15:23:20 +0000 Message-ID: <578B9197-F0DA-474D-950A-BB0FDD4F4A7C@tencent.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [9.19.161.99] Content-ID: MIME-Version: 1.0 Cc: Dumitru Ceara Subject: [ovs-dev] [PATCH ovn] tests: Fix Port_Binding up test. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" After setting the iface-id, immediately check the up status of the port binding, it will occasionally fail, especially when the port binding status is reported later. When it fails, the following will be output: Checking values in sb Port_Binding with logical_port=lsp1 against false... found false ovs-vsctl add-port br-int lsp1 -- set Interface lsp1 external-ids:iface-id=lsp1 ./ovn-macros.at:307: "$@" Checking values in sb Port_Binding with logical_port=lsp1 against true... found false _uuid : 15ebabb6-3dbb-4806-aa85-d1c03e3b39f6 logical_port : lsp1 up : true ./ovn-macros.at:393: hard failure Fixes: 4d3cb42b076b ("binding: Set Logical_Switch_Port.up when all OVS flows are installed.") Signed-off-by: Gongming Chen --- tests/ovn.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ovn.at b/tests/ovn.at index 80c9fe138..43dc16dd8 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -23885,7 +23885,7 @@ check ovn-nbctl --wait=hv sync check_column "false" Port_Binding up logical_port=lsp1 check ovs-vsctl add-port br-int lsp1 -- set Interface lsp1 external-ids:iface-id=lsp1 -check_column "true" Port_Binding up logical_port=lsp1 +wait_column "true" Port_Binding up logical_port=lsp1 wait_column "true" nb:Logical_Switch_Port up name=lsp1 OVS_WAIT_UNTIL([test `ovs-vsctl get Interface lsp1 external_ids:ovn-installed` = '"true"'])