diff mbox series

[ovs-dev,v4,01/14] ic: Do not include config.h from headers.

Message ID 20260902211744.2159261-2-guilherme.paulo@magalu.cloud
State New
Headers show
Series ic: Incremental processing for ovn-ic. | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/github-robot-_ovn-kubernetes success github build: passed

Commit Message

Paulo Guilherme Silva Sept. 2, 2026, 9:17 p.m. UTC 
config.h is generated by autoconf and is only meant to be included by
source files, as the very first include so that the feature macros it
defines apply to every header that follows.  ic/en-ic.h and
ic/inc-proc-ic.h, added by commit 782b8b535438 ("ovn-ic: Introduce
incremental processing."), include it themselves.  Drop it from both:
every .c file that includes these headers already includes <config.h>
first.

Suggested-by: Mark Michelson <mmichels@redhat.com>
Assisted-by: Claude Opus 5, Claude Code
Signed-off-by: Paulo Guilherme Silva <guilherme.paulo@magalu.cloud>
---
 ic/en-ic.h       | 2 --
 ic/inc-proc-ic.h | 2 --
 2 files changed, 4 deletions(-)
diff mbox series

Patch

diff --git a/ic/en-ic.h b/ic/en-ic.h
index a4b75bb0e..48150b163 100644
--- a/ic/en-ic.h
+++ b/ic/en-ic.h
@@ -1,8 +1,6 @@ 
 #ifndef EN_IC_H
 #define EN_IC_H 1
 
-#include <config.h>
-
 #include <getopt.h>
 #include <stdlib.h>
 #include <stdio.h>
diff --git a/ic/inc-proc-ic.h b/ic/inc-proc-ic.h
index 36464564d..30e3071ae 100644
--- a/ic/inc-proc-ic.h
+++ b/ic/inc-proc-ic.h
@@ -1,8 +1,6 @@ 
 #ifndef INC_PROC_IC_H
 #define INC_PROC_IC_H 1
 
-#include <config.h>
-
 #include "ovn-ic.h"
 #include "ovsdb-idl.h"
 #include "lib/inc-proc-eng.h"