diff mbox series

[ovs-dev,07/11] tests: Fix flaky "send arp for nexthop".

Message ID 20250710153345.104954-8-xsimonar@redhat.com
State Superseded
Headers show
Series Multiple unit/system tests fixes. | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/github-robot-_ovn-kubernetes success github build: passed

Commit Message

Xavier Simonart July 10, 2025, 3:33 p.m. UTC
Signed-off-by: Xavier Simonart <xsimonar@redhat.com>
---
 tests/ovn.at | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Mark Michelson July 21, 2025, 8:49 p.m. UTC | #1
Acked-by: Mark Michelson <mmichels@redhat.com>

On 7/10/25 11:33 AM, Xavier Simonart via dev wrote:
> Signed-off-by: Xavier Simonart <xsimonar@redhat.com>
> ---
>   tests/ovn.at | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/ovn.at b/tests/ovn.at
> index 01221a264..274b77d70 100644
> --- a/tests/ovn.at
> +++ b/tests/ovn.at
> @@ -9786,10 +9786,9 @@ as hv1 ovs-appctl netdev-dummy/receive hv1-ls1lp2 $packet
>   # ARP packet should be received with Target IP Address set to 192.168.1.254 and
>   # not 8.8.8.8
>   
> -$PYTHON "$ovs_srcdir/utilities/ovs-pcap.in" hv1/ls2lp2-tx.pcap | trim_zeros > packets
>   expected="fffffffffffff0000000000208060001080006040001f00000000002c0a80101000000000000c0a801fe"
> -echo $expected > expout
> -AT_CHECK([cat packets], [0], [expout])
> +echo $expected > expected
> +OVN_CHECK_PACKETS([hv1/ls2lp2-tx.pcap], [expected])
>   cat packets
>   
>   OVN_CLEANUP([hv1])
diff mbox series

Patch

diff --git a/tests/ovn.at b/tests/ovn.at
index 01221a264..274b77d70 100644
--- a/tests/ovn.at
+++ b/tests/ovn.at
@@ -9786,10 +9786,9 @@  as hv1 ovs-appctl netdev-dummy/receive hv1-ls1lp2 $packet
 # ARP packet should be received with Target IP Address set to 192.168.1.254 and
 # not 8.8.8.8
 
-$PYTHON "$ovs_srcdir/utilities/ovs-pcap.in" hv1/ls2lp2-tx.pcap | trim_zeros > packets
 expected="fffffffffffff0000000000208060001080006040001f00000000002c0a80101000000000000c0a801fe"
-echo $expected > expout
-AT_CHECK([cat packets], [0], [expout])
+echo $expected > expected
+OVN_CHECK_PACKETS([hv1/ls2lp2-tx.pcap], [expected])
 cat packets
 
 OVN_CLEANUP([hv1])