| Message ID | 20250515185225.3116847-1-mmichels@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] en-lflow: Return correct type in northd_handler. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/github-robot-_ovn-kubernetes | success | github build: passed |
On Thu, May 15, 2025 at 8:52 PM Mark Michelson via dev < ovs-dev@openvswitch.org> wrote: > A recent refactor changed the return type of input node handlers to no > longer return a boolean. This line was missed during the refactor and > apparently caused no testsuite issues. > > Signed-off-by: Mark Michelson <mmichels@redhat.com> > --- > northd/en-lflow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/northd/en-lflow.c b/northd/en-lflow.c > index 6ad14d0b8..898869287 100644 > --- a/northd/en-lflow.c > +++ b/northd/en-lflow.c > @@ -132,7 +132,7 @@ lflow_northd_handler(struct engine_node *node, > { > struct northd_data *northd_data = engine_get_input_data("northd", > node); > if (!northd_has_tracked_data(&northd_data->trk_data)) { > - return false; > + return EN_UNHANDLED; > } > > const struct engine_context *eng_ctx = engine_get_context(); > -- > 2.47.0 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > Hi Mark, thank you for the patch. I have added the missing fixes tag and merged it into main. Regards, Ales
diff --git a/northd/en-lflow.c b/northd/en-lflow.c index 6ad14d0b8..898869287 100644 --- a/northd/en-lflow.c +++ b/northd/en-lflow.c @@ -132,7 +132,7 @@ lflow_northd_handler(struct engine_node *node, { struct northd_data *northd_data = engine_get_input_data("northd", node); if (!northd_has_tracked_data(&northd_data->trk_data)) { - return false; + return EN_UNHANDLED; } const struct engine_context *eng_ctx = engine_get_context();
A recent refactor changed the return type of input node handlers to no longer return a boolean. This line was missed during the refactor and apparently caused no testsuite issues. Signed-off-by: Mark Michelson <mmichels@redhat.com> --- northd/en-lflow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)