diff mbox series

[ovs-dev,branch-24.09,1/2] Set release date for 24.09.0.

Message ID 20240905171153.760891-2-mmichels@redhat.com
State Deferred
Headers show
Series Release patches for v24.09.0. | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/github-robot-_ovn-kubernetes success github build: passed

Commit Message

Mark Michelson Sept. 5, 2024, 5:11 p.m. UTC
Signed-off-by: Mark Michelson <mmichels@redhat.com>
---
 NEWS             | 2 +-
 debian/changelog | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Numan Siddique Sept. 5, 2024, 8 p.m. UTC | #1
On Thu, Sep 5, 2024 at 1:12 PM Mark Michelson <mmichels@redhat.com> wrote:
>
> Signed-off-by: Mark Michelson <mmichels@redhat.com>

Acked-by: Numan Siddique <numans@ovn.org>

Numan

> ---
>  NEWS             | 2 +-
>  debian/changelog | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/NEWS b/NEWS
> index 29d60274e..92ebe6e9c 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -1,4 +1,4 @@
> -OVN v24.09.0 - xx xxx xxxx
> +OVN v24.09.0 - 06 Sep 2024
>  --------------------------
>    - Added a new logical switch port option "pkt_clone_type".
>      If the value is set to "mc_unknown", packets destined to the port gets
> diff --git a/debian/changelog b/debian/changelog
> index 8168d1e83..f31208d7d 100644
> --- a/debian/changelog
> +++ b/debian/changelog
> @@ -2,7 +2,7 @@ ovn (24.09.0-1) unstable; urgency=low
>
>     * New upstream version
>
> - -- OVN team <dev@openvswitch.org>  Fri, 09 Aug 2024 09:56:41 -0400
> + -- OVN team <dev@openvswitch.org>  Thu, 06 Sep 2024 13:05:51 -0400
>
>  ovn (24.03.0-1) unstable; urgency=low
>
> --
> 2.45.2
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
Dumitru Ceara Sept. 6, 2024, 10:59 a.m. UTC | #2
On 9/5/24 19:11, Mark Michelson wrote:
> Signed-off-by: Mark Michelson <mmichels@redhat.com>
> ---

Hi Mark,

>  NEWS             | 2 +-
>  debian/changelog | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/NEWS b/NEWS
> index 29d60274e..92ebe6e9c 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -1,4 +1,4 @@
> -OVN v24.09.0 - xx xxx xxxx
> +OVN v24.09.0 - 06 Sep 2024
>  --------------------------
>    - Added a new logical switch port option "pkt_clone_type".
>      If the value is set to "mc_unknown", packets destined to the port gets
> diff --git a/debian/changelog b/debian/changelog
> index 8168d1e83..f31208d7d 100644
> --- a/debian/changelog
> +++ b/debian/changelog
> @@ -2,7 +2,7 @@ ovn (24.09.0-1) unstable; urgency=low
>  
>     * New upstream version
>  
> - -- OVN team <dev@openvswitch.org>  Fri, 09 Aug 2024 09:56:41 -0400
> + -- OVN team <dev@openvswitch.org>  Thu, 06 Sep 2024 13:05:51 -0400

This should be: Fri, 06 Sep.

With that addressed:
Acked-by: Dumitru Ceara <dceara@redhat.com>

Thanks,
Dumitru

>  
>  ovn (24.03.0-1) unstable; urgency=low
>
Dumitru Ceara Sept. 6, 2024, 3:37 p.m. UTC | #3
On 9/6/24 12:59, Dumitru Ceara wrote:
> On 9/5/24 19:11, Mark Michelson wrote:
>> Signed-off-by: Mark Michelson <mmichels@redhat.com>
>> ---
> 
> Hi Mark,
> 
>>  NEWS             | 2 +-
>>  debian/changelog | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/NEWS b/NEWS
>> index 29d60274e..92ebe6e9c 100644
>> --- a/NEWS
>> +++ b/NEWS
>> @@ -1,4 +1,4 @@
>> -OVN v24.09.0 - xx xxx xxxx
>> +OVN v24.09.0 - 06 Sep 2024
>>  --------------------------
>>    - Added a new logical switch port option "pkt_clone_type".
>>      If the value is set to "mc_unknown", packets destined to the port gets
>> diff --git a/debian/changelog b/debian/changelog
>> index 8168d1e83..f31208d7d 100644
>> --- a/debian/changelog
>> +++ b/debian/changelog
>> @@ -2,7 +2,7 @@ ovn (24.09.0-1) unstable; urgency=low
>>  
>>     * New upstream version
>>  
>> - -- OVN team <dev@openvswitch.org>  Fri, 09 Aug 2024 09:56:41 -0400
>> + -- OVN team <dev@openvswitch.org>  Thu, 06 Sep 2024 13:05:51 -0400
> 
> This should be: Fri, 06 Sep.
> 
> With that addressed:
> Acked-by: Dumitru Ceara <dceara@redhat.com>
> 

Sorry for the last minute bug report but it seems there's a regression
that was introduced in the 24.09 code:

https://issues.redhat.com/browse/FDP-773

It's about ovn-controller incorrectly flushing conntrack zones that it
used to own when it gets restarted.  Git bisect points to:

https://github.com/ovn-org/ovn/commit/f2363f49f6a46e784b1d8dad33eee733aa09380c

Mark, what do you think we should do?  This bug potentially disrupts the
dataplane (for ovn-kubernetes at least) during upgrades.

Regards,
Dumitru
Mark Michelson Sept. 6, 2024, 3:40 p.m. UTC | #4
On 9/6/24 11:37, Dumitru Ceara wrote:
> On 9/6/24 12:59, Dumitru Ceara wrote:
>> On 9/5/24 19:11, Mark Michelson wrote:
>>> Signed-off-by: Mark Michelson <mmichels@redhat.com>
>>> ---
>>
>> Hi Mark,
>>
>>>   NEWS             | 2 +-
>>>   debian/changelog | 2 +-
>>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/NEWS b/NEWS
>>> index 29d60274e..92ebe6e9c 100644
>>> --- a/NEWS
>>> +++ b/NEWS
>>> @@ -1,4 +1,4 @@
>>> -OVN v24.09.0 - xx xxx xxxx
>>> +OVN v24.09.0 - 06 Sep 2024
>>>   --------------------------
>>>     - Added a new logical switch port option "pkt_clone_type".
>>>       If the value is set to "mc_unknown", packets destined to the port gets
>>> diff --git a/debian/changelog b/debian/changelog
>>> index 8168d1e83..f31208d7d 100644
>>> --- a/debian/changelog
>>> +++ b/debian/changelog
>>> @@ -2,7 +2,7 @@ ovn (24.09.0-1) unstable; urgency=low
>>>   
>>>      * New upstream version
>>>   
>>> - -- OVN team <dev@openvswitch.org>  Fri, 09 Aug 2024 09:56:41 -0400
>>> + -- OVN team <dev@openvswitch.org>  Thu, 06 Sep 2024 13:05:51 -0400
>>
>> This should be: Fri, 06 Sep.
>>
>> With that addressed:
>> Acked-by: Dumitru Ceara <dceara@redhat.com>
>>
> 
> Sorry for the last minute bug report but it seems there's a regression
> that was introduced in the 24.09 code:
> 
> https://issues.redhat.com/browse/FDP-773
> 
> It's about ovn-controller incorrectly flushing conntrack zones that it
> used to own when it gets restarted.  Git bisect points to:
> 
> https://github.com/ovn-org/ovn/commit/f2363f49f6a46e784b1d8dad33eee733aa09380c
> 
> Mark, what do you think we should do?  This bug potentially disrupts the
> dataplane (for ovn-kubernetes at least) during upgrades.
> 
> Regards,
> Dumitru
> 

Releasing with a known regression is a bad idea. Let's get this fixed, 
with the goal being to release in a week (13 September). I'll remove 
this review from patchwwork and post a new set of patches next week.

Thanks,
Mark Michelson
diff mbox series

Patch

diff --git a/NEWS b/NEWS
index 29d60274e..92ebe6e9c 100644
--- a/NEWS
+++ b/NEWS
@@ -1,4 +1,4 @@ 
-OVN v24.09.0 - xx xxx xxxx
+OVN v24.09.0 - 06 Sep 2024
 --------------------------
   - Added a new logical switch port option "pkt_clone_type".
     If the value is set to "mc_unknown", packets destined to the port gets
diff --git a/debian/changelog b/debian/changelog
index 8168d1e83..f31208d7d 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -2,7 +2,7 @@  ovn (24.09.0-1) unstable; urgency=low
 
    * New upstream version
 
- -- OVN team <dev@openvswitch.org>  Fri, 09 Aug 2024 09:56:41 -0400
+ -- OVN team <dev@openvswitch.org>  Thu, 06 Sep 2024 13:05:51 -0400
 
 ovn (24.03.0-1) unstable; urgency=low