| Message ID | 20240422064031.1646196-1-hzhou@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] northd: Fix the comment about route priorities. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/github-robot-_ovn-kubernetes | fail | github build: failed |
On Mon, Apr 22, 2024 at 2:41 AM Han Zhou <hzhou@ovn.org> wrote: > > The current comments are obviously conflicting. Fixing it according the > current implementation - static route overrides src-ip route. > > Signed-off-by: Han Zhou <hzhou@ovn.org> Acked-by: Numan Siddique <numans@ovn.org> Numan > --- > northd/northd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/northd/northd.c b/northd/northd.c > index 331d9c2677b8..dec1eb3679f5 100644 > --- a/northd/northd.c > +++ b/northd/northd.c > @@ -271,7 +271,7 @@ static bool default_acl_drop; > * Route offsets implement logic to prioritize traffic for routes with > * same ip_prefix values: > * - connected route overrides static one; > - * - static route overrides connected route. */ > + * - static route overrides src-ip route. */ > #define ROUTE_PRIO_OFFSET_MULTIPLIER 3 > #define ROUTE_PRIO_OFFSET_STATIC 1 > #define ROUTE_PRIO_OFFSET_CONNECTED 2 > -- > 2.38.1 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
On Thu, May 2, 2024 at 9:01 AM Numan Siddique <numans@ovn.org> wrote: > > On Mon, Apr 22, 2024 at 2:41 AM Han Zhou <hzhou@ovn.org> wrote: > > > > The current comments are obviously conflicting. Fixing it according the > > current implementation - static route overrides src-ip route. > > > > Signed-off-by: Han Zhou <hzhou@ovn.org> > > Acked-by: Numan Siddique <numans@ovn.org> > > Numan > Thanks Numan. Applied to main. Han > > --- > > northd/northd.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/northd/northd.c b/northd/northd.c > > index 331d9c2677b8..dec1eb3679f5 100644 > > --- a/northd/northd.c > > +++ b/northd/northd.c > > @@ -271,7 +271,7 @@ static bool default_acl_drop; > > * Route offsets implement logic to prioritize traffic for routes with > > * same ip_prefix values: > > * - connected route overrides static one; > > - * - static route overrides connected route. */ > > + * - static route overrides src-ip route. */ > > #define ROUTE_PRIO_OFFSET_MULTIPLIER 3 > > #define ROUTE_PRIO_OFFSET_STATIC 1 > > #define ROUTE_PRIO_OFFSET_CONNECTED 2 > > -- > > 2.38.1 > > > > _______________________________________________ > > dev mailing list > > dev@openvswitch.org > > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > >
diff --git a/northd/northd.c b/northd/northd.c index 331d9c2677b8..dec1eb3679f5 100644 --- a/northd/northd.c +++ b/northd/northd.c @@ -271,7 +271,7 @@ static bool default_acl_drop; * Route offsets implement logic to prioritize traffic for routes with * same ip_prefix values: * - connected route overrides static one; - * - static route overrides connected route. */ + * - static route overrides src-ip route. */ #define ROUTE_PRIO_OFFSET_MULTIPLIER 3 #define ROUTE_PRIO_OFFSET_STATIC 1 #define ROUTE_PRIO_OFFSET_CONNECTED 2
The current comments are obviously conflicting. Fixing it according the current implementation - static route overrides src-ip route. Signed-off-by: Han Zhou <hzhou@ovn.org> --- northd/northd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)