| Message ID | 20240416025820.1492-1-liuxie_11@163.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] tests: Ignore log setting extended ack support failed. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | warning | apply and check: warning |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/github-robot-_ovn-kubernetes | success | github build: passed |
On 4/16/24 04:57, liuxie_11@163.com wrote: > From: shylou <liuxie_11@163.com> > > The test error log 'setting extended ack support failed' in the test > results may cause test failures. However, according to the OVS commit[1], > this is not a critical issue, so we can safely ignore this log. > > [1]https://github.com/openvswitch/ovs/commit/812164adefc716dd35c50c2101e8e60a15167635 > > Signed-off-by: Xie Liu <liushyshy@gmail.com> > --- Hi Xie Liu, Thanks for the patch, it looks good to me. There's one small thing though: the git email address used to author the patch doesn't match the signed-off-by address. I can change it to Xie Liu <liushyshy@gmail.com> when accepting the patch if you're OK with that. Regards, Dumitru
@Dumitru Thanks for your review! Yeah, I'm OK! At 2024-04-18 19:22:01, "Dumitru Ceara" <dceara@redhat.com> wrote: >On 4/16/24 04:57, liuxie_11@163.com wrote: >> From: shylou <liuxie_11@163.com> >> >> The test error log 'setting extended ack support failed' in the test >> results may cause test failures. However, according to the OVS commit[1], >> this is not a critical issue, so we can safely ignore this log. >> >> [1]https://github.com/openvswitch/ovs/commit/812164adefc716dd35c50c2101e8e60a15167635 >> >> Signed-off-by: Xie Liu <liushyshy@gmail.com> >> --- > >Hi Xie Liu, > >Thanks for the patch, it looks good to me. > >There's one small thing though: the git email address used to author the >patch doesn't match the signed-off-by address. > >I can change it to Xie Liu <liushyshy@gmail.com> when accepting the >patch if you're OK with that. > >Regards, >Dumitru
On 4/18/24 13:29, Xie Liu wrote: > > @Dumitru > Thanks for your review! > Yeah, I'm OK! > Awesome, I fixed up the git author and pushed this to main. Best regards, Dumitru > At 2024-04-18 19:22:01, "Dumitru Ceara" <dceara@redhat.com> wrote: >> On 4/16/24 04:57, liuxie_11@163.com wrote: >>> From: shylou <liuxie_11@163.com> >>> >>> The test error log 'setting extended ack support failed' in the test >>> results may cause test failures. However, according to the OVS commit[1], >>> this is not a critical issue, so we can safely ignore this log. >>> >>> [1]https://github.com/openvswitch/ovs/commit/812164adefc716dd35c50c2101e8e60a15167635 >>> >>> Signed-off-by: Xie Liu <liushyshy@gmail.com> >>> --- >> >> Hi Xie Liu, >> >> Thanks for the patch, it looks good to me. >> >> There's one small thing though: the git email address used to author the >> patch doesn't match the signed-off-by address. >> >> I can change it to Xie Liu <liushyshy@gmail.com> when accepting the >> patch if you're OK with that. >> >> Regards, >> Dumitru
diff --git a/tests/ofproto-macros.at b/tests/ofproto-macros.at index bccedbaf7..31a067c1e 100644 --- a/tests/ofproto-macros.at +++ b/tests/ofproto-macros.at @@ -288,6 +288,7 @@ check_logs () { /ovs_rcu.*blocked [[0-9]]* ms waiting for .* to quiesce/d /Dropped [[0-9]]* log messages/d /.*Trying to release unknown interface.*/d +/setting extended ack support failed/d /|WARN|/p /|ERR|/p /|EMER|/p" ${logs}