diff mbox series

[ovs-dev,v6,3/6] tests: Correct tunnel ids exhaustion scenario.

Message ID 20240412015727.4152034-4-ihrachys@redhat.com
State Superseded, archived
Headers show
Series Correct tunnel ids exhaustion scenario. | expand


Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/github-robot-_ovn-kubernetes success github build: passed

Commit Message

Ihar Hrachyshka April 12, 2024, 1:57 a.m. UTC
The original version of the scenario passed with or without the fix.
This is because all LSs were processed in one go, so the allocate
function was never entered with *hint==0.

Also, added another scenario that will check behavior when *hint is out
of [min;max] bounds but > max (this happens in an obscure scenario where
a vxlan chassis is added to the cluster mid-light, forcing northd to
reduce its effective max value for tunnel ids; which may become lower
than the current *hint for ports.)

Fixes: a1f165a7b807 ("northd: fix infinite loop in ovn_allocate_tnlid()")
Co-Authored-By: Vladislav Odintsov <odivlad@gmail.com>
Signed-off-by: Vladislav Odintsov <odivlad@gmail.com>
Signed-off-by: Ihar Hrachyshka <ihrachys@redhat.com>
 tests/ovn-northd.at | 43 ++++++++++++++++++++++++++++++++++++++++---
 1 file changed, 40 insertions(+), 3 deletions(-)
diff mbox series


diff --git a/tests/ovn-northd.at b/tests/ovn-northd.at
index be006fb32..1a4e7274d 100644
--- a/tests/ovn-northd.at
+++ b/tests/ovn-northd.at
@@ -2823,7 +2823,7 @@  AT_CLEANUP
-AT_SETUP([check tunnel ids exhaustion])
+AT_SETUP([check datapath tunnel ids exhaustion])
 # Create a fake chassis with vxlan encap to lower MAX DP tunnel key to 2^12
@@ -2833,13 +2833,18 @@  ovn-sbctl \
 cmd="ovn-nbctl --wait=sb"
-for i in {1..4097}; do
+for i in {1..4095}; do
     cmd="${cmd} -- ls-add lsw-${i}"
 eval $cmd
-check_row_count nb:Logical_Switch 4097
+check_row_count nb:Logical_Switch 4095
+wait_row_count sb:Datapath_Binding 4095
+ovn-nbctl ls-add lsw-exhausted
+check_row_count nb:Logical_Switch 4096
 wait_row_count sb:Datapath_Binding 4095
 OVS_WAIT_UNTIL([grep "all datapath tunnel ids exhausted" northd/ovn-northd.log])
@@ -2847,6 +2852,38 @@  OVS_WAIT_UNTIL([grep "all datapath tunnel ids exhausted" northd/ovn-northd.log])
+AT_SETUP([check port tunnel ids exhaustion; vxlan chassis pops up midflight])
+cmd="ovn-nbctl --wait=sb"
+cmd="${cmd} -- ls-add lsw"
+for i in {1..2048}; do
+    cmd="${cmd} -- lsp-add lsw lsp-${i}"
+eval $cmd
+check_row_count nb:Logical_Switch_Port 2048
+wait_row_count sb:Port_Binding 2048
+# Now create a fake chassis with vxlan encap to lower MAX port tunnel key to 2^11
+ovn-sbctl \
+    --id=@e create encap chassis_name=hv1 ip="" type="vxlan" \
+    -- --id=@c create chassis name=hv1 encaps=@e
+ovn-nbctl lsp-add lsw lsp-exhausted
+check_row_count nb:Logical_Switch_Port 2049
+wait_row_count sb:Port_Binding 2048
+OVS_WAIT_UNTIL([grep "all port tunnel ids exhausted" northd/ovn-northd.log])
 AT_SETUP([Logical Flow Datapath Groups])