diff mbox series

[ovs-dev,v5,3/7] northd: Don't remove detached op from list.

Message ID 20240411225922.2473043-4-ihrachys@redhat.com
State Superseded, archived
Headers show
Series Correct tunnel ids exhaustion scenario. | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test fail github build: failed
ovsrobot/github-robot-_ovn-kubernetes success github build: passed

Commit Message

Ihar Hrachyshka April 11, 2024, 10:59 p.m. UTC 
The `op` here is a new port structure that is not, yet, attached
anywhere, and the attempt to detach it will result in undefined
behavior.

Signed-off-by: Ihar Hrachyshka <ihrachys@redhat.com>
---
 northd/northd.c | 1 -
 1 file changed, 1 deletion(-)
diff mbox series

Patch

diff --git a/northd/northd.c b/northd/northd.c
index ace663d54..3d2715911 100644
--- a/northd/northd.c
+++ b/northd/northd.c
@@ -4346,7 +4346,6 @@  ls_port_create(struct ovsdb_idl_txn *ovnsb_txn, struct hmap *ls_ports,
         if (op->sb) {
             sbrec_port_binding_delete(op->sb);
         }
-        ovs_list_remove(&op->list);
         ovn_port_destroy(ls_ports, op);
         return NULL;
     }