| Message ID | 20240315184307.1486458-1-xsimonar@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] tests: Ignore transaction errors in MAC Binding. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/github-robot-_ovn-kubernetes | success | github build: passed |
On Fri, Mar 15, 2024 at 7:43 PM Xavier Simonart <xsimonar@redhat.com> wrote: > Fixes: 65f9f010b426 ("tests: Check unit tests logs for errors.") > Signed-off-by: Xavier Simonart <xsimonar@redhat.com> > --- > tests/ovn-macros.at | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tests/ovn-macros.at b/tests/ovn-macros.at > index 3410afb74..5c69facd2 100644 > --- a/tests/ovn-macros.at > +++ b/tests/ovn-macros.at > @@ -48,12 +48,15 @@ m4_define([OVN_CLEANUP_SBOX],[ > # "has no network name*" as localnet network_name is often set > "after" creating localnet. > # "receive tunnel port not found*" happening when closing other hv. > # "Failed to locate tunnel to reach main chassis" happening when > controller started e.g. before ovn-bridge-mappings is set > + # "Transaction causes multiple rows in \"MAC_Binding\" table to have > identical values" > + # happening as ovn-controller has a race condition over MAC binding > table with other controllers (GARP). > AT_CHECK([check_logs " > $error > /connection failed (No such file or directory)/d > /has no network name*/d > /receive tunnel port not found*/d > /Failed to locate tunnel to reach main chassis/d > + /Transaction causes multiple rows.*MAC_Binding/d > " $sbox]) > ]) > > -- > 2.31.1 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > Looks good to me, thanks. Acked-by: Ales Musil <amusil@redhat.com>
On 3/19/24 08:06, Ales Musil wrote: > On Fri, Mar 15, 2024 at 7:43 PM Xavier Simonart <xsimonar@redhat.com> wrote: > >> Fixes: 65f9f010b426 ("tests: Check unit tests logs for errors.") >> Signed-off-by: Xavier Simonart <xsimonar@redhat.com> >> --- >> tests/ovn-macros.at | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/tests/ovn-macros.at b/tests/ovn-macros.at >> index 3410afb74..5c69facd2 100644 >> --- a/tests/ovn-macros.at >> +++ b/tests/ovn-macros.at >> @@ -48,12 +48,15 @@ m4_define([OVN_CLEANUP_SBOX],[ >> # "has no network name*" as localnet network_name is often set >> "after" creating localnet. >> # "receive tunnel port not found*" happening when closing other hv. >> # "Failed to locate tunnel to reach main chassis" happening when >> controller started e.g. before ovn-bridge-mappings is set >> + # "Transaction causes multiple rows in \"MAC_Binding\" table to have >> identical values" >> + # happening as ovn-controller has a race condition over MAC binding >> table with other controllers (GARP). >> AT_CHECK([check_logs " >> $error >> /connection failed (No such file or directory)/d >> /has no network name*/d >> /receive tunnel port not found*/d >> /Failed to locate tunnel to reach main chassis/d >> + /Transaction causes multiple rows.*MAC_Binding/d >> " $sbox]) >> ]) >> >> -- >> 2.31.1 >> >> _______________________________________________ >> dev mailing list >> dev@openvswitch.org >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev >> >> > Looks good to me, thanks. > > Acked-by: Ales Musil <amusil@redhat.com> > Thanks, Xavier and Ales! Applied to main and 24.03. Regards, Dumitru
diff --git a/tests/ovn-macros.at b/tests/ovn-macros.at index 3410afb74..5c69facd2 100644 --- a/tests/ovn-macros.at +++ b/tests/ovn-macros.at @@ -48,12 +48,15 @@ m4_define([OVN_CLEANUP_SBOX],[ # "has no network name*" as localnet network_name is often set "after" creating localnet. # "receive tunnel port not found*" happening when closing other hv. # "Failed to locate tunnel to reach main chassis" happening when controller started e.g. before ovn-bridge-mappings is set + # "Transaction causes multiple rows in \"MAC_Binding\" table to have identical values" + # happening as ovn-controller has a race condition over MAC binding table with other controllers (GARP). AT_CHECK([check_logs " $error /connection failed (No such file or directory)/d /has no network name*/d /receive tunnel port not found*/d /Failed to locate tunnel to reach main chassis/d + /Transaction causes multiple rows.*MAC_Binding/d " $sbox]) ])
Fixes: 65f9f010b426 ("tests: Check unit tests logs for errors.") Signed-off-by: Xavier Simonart <xsimonar@redhat.com> --- tests/ovn-macros.at | 3 +++ 1 file changed, 3 insertions(+)