| Message ID | 20240212162727.867388-1-xsimonar@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] tests: Fix flaky "lr multiple gw ports" test. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/github-robot-_ovn-kubernetes | success | github build: passed |
On Mon, Feb 12, 2024 at 5:27 PM Xavier Simonart <xsimonar@redhat.com> wrote: > The test was confused as 192.168.0.1 was configured for DR-S3 port > (configured as a gateway-chassis hv4) as well as the encap_ip for hv1. > > Hence packets which were supposed to be sent towards hv1 got sent > to hv4. > > Signed-off-by: Xavier Simonart <xsimonar@redhat.com> > --- > tests/ovn.at | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/ovn.at b/tests/ovn.at > index 902dd3793..7cf4d02d3 100644 > --- a/tests/ovn.at > +++ b/tests/ovn.at > @@ -33322,7 +33322,7 @@ for i in 1 2 3 4 5; do > as hv$i > ovs-vsctl add-br br-phys > ovs-vsctl set open . external-ids:ovn-bridge-mappings=phys:br-phys > - ovn_attach n1 br-phys 192.168.0.$i 24 $encap > + ovn_attach n1 br-phys 192.168.1.$i 24 $encap > done > > # Add a vif on HV1 > -- > 2.41.0 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > Looks good to me, thanks. Acked-by: Ales Musil <amusil@redhat.com>
On 2/13/24 02:15, Ales Musil wrote: > On Mon, Feb 12, 2024 at 5:27 PM Xavier Simonart <xsimonar@redhat.com> wrote: > >> The test was confused as 192.168.0.1 was configured for DR-S3 port >> (configured as a gateway-chassis hv4) as well as the encap_ip for hv1. >> >> Hence packets which were supposed to be sent towards hv1 got sent >> to hv4. >> >> Signed-off-by: Xavier Simonart <xsimonar@redhat.com> >> --- >> tests/ovn.at | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tests/ovn.at b/tests/ovn.at >> index 902dd3793..7cf4d02d3 100644 >> --- a/tests/ovn.at >> +++ b/tests/ovn.at >> @@ -33322,7 +33322,7 @@ for i in 1 2 3 4 5; do >> as hv$i >> ovs-vsctl add-br br-phys >> ovs-vsctl set open . external-ids:ovn-bridge-mappings=phys:br-phys >> - ovn_attach n1 br-phys 192.168.0.$i 24 $encap >> + ovn_attach n1 br-phys 192.168.1.$i 24 $encap >> done >> >> # Add a vif on HV1 >> -- >> 2.41.0 >> >> _______________________________________________ >> dev mailing list >> dev@openvswitch.org >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev >> >> > Looks good to me, thanks. > > Acked-by: Ales Musil <amusil@redhat.com> > Thanks Xavier and Ales. I pushed this to main, 24.03, 23.09, and 23.06.
diff --git a/tests/ovn.at b/tests/ovn.at index 902dd3793..7cf4d02d3 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -33322,7 +33322,7 @@ for i in 1 2 3 4 5; do as hv$i ovs-vsctl add-br br-phys ovs-vsctl set open . external-ids:ovn-bridge-mappings=phys:br-phys - ovn_attach n1 br-phys 192.168.0.$i 24 $encap + ovn_attach n1 br-phys 192.168.1.$i 24 $encap done # Add a vif on HV1
The test was confused as 192.168.0.1 was configured for DR-S3 port (configured as a gateway-chassis hv4) as well as the encap_ip for hv1. Hence packets which were supposed to be sent towards hv1 got sent to hv4. Signed-off-by: Xavier Simonart <xsimonar@redhat.com> --- tests/ovn.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)