| Message ID | 20240130075828.325536-1-amusil@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] tests: Fix grep warning | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | warning | apply and check: warning |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/github-robot-_ovn-kubernetes | success | github build: passed |
On Tue, Jan 30, 2024 at 8:58 AM Ales Musil <amusil@redhat.com> wrote: > The Fedora version of grep (grep (GNU grep) 3.11) complains > about the syntax grep "output\:": grep: warning: stray \ before : > > Remove the \ which works also for Ubuntu grep version > (grep (GNU grep) 3.7). > > I forgot to add the Fixes tag. Fixes: 17b6a12fa286 ("ovn-controller: Support VIF-based local encap IPs selection.") > Signed-off-by: Ales Musil <amusil@redhat.com> > --- > tests/ovn.at | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/ovn.at b/tests/ovn.at > index 62966752f..cf87b9ad4 100644 > --- a/tests/ovn.at > +++ b/tests/ovn.at > @@ -30435,7 +30435,7 @@ check_packet_tunnel() { > as $hv > echo "vif$src -> vif$dst should go through tunnel $local_encap_ip -> > $remote_encap_ip" > tunnel_ofport=$(ovs-vsctl --bare --column=ofport find interface > options:local_ip=$local_encap_ip options:remote_ip=$remote_encap_ip) > - AT_CHECK([test $(ovs-appctl ofproto/trace br-int in_port=vif$src > $packet | grep "output\:" | awk -F ':' '{ print $2 }') == $tunnel_ofport]) > + AT_CHECK([test $(ovs-appctl ofproto/trace br-int in_port=vif$src > $packet | grep "output:" | awk -F ':' '{ print $2 }') == $tunnel_ofport]) > } > > for i in 1 2; do > -- > 2.43.0 > >
On 1/30/24 08:59, Ales Musil wrote: > On Tue, Jan 30, 2024 at 8:58 AM Ales Musil <amusil@redhat.com> wrote: > >> The Fedora version of grep (grep (GNU grep) 3.11) complains >> about the syntax grep "output\:": grep: warning: stray \ before : >> >> Remove the \ which works also for Ubuntu grep version >> (grep (GNU grep) 3.7). >> >> > I forgot to add the Fixes tag. > > Fixes: 17b6a12fa286 ("ovn-controller: Support VIF-based local encap IPs > selection.") > > >> Signed-off-by: Ales Musil <amusil@redhat.com> >> --- Thanks, I added the "fixes" tag and a dot at the end of the commit summary then pushed this to main. Regards, Dumitru >> tests/ovn.at | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tests/ovn.at b/tests/ovn.at >> index 62966752f..cf87b9ad4 100644 >> --- a/tests/ovn.at >> +++ b/tests/ovn.at >> @@ -30435,7 +30435,7 @@ check_packet_tunnel() { >> as $hv >> echo "vif$src -> vif$dst should go through tunnel $local_encap_ip -> >> $remote_encap_ip" >> tunnel_ofport=$(ovs-vsctl --bare --column=ofport find interface >> options:local_ip=$local_encap_ip options:remote_ip=$remote_encap_ip) >> - AT_CHECK([test $(ovs-appctl ofproto/trace br-int in_port=vif$src >> $packet | grep "output\:" | awk -F ':' '{ print $2 }') == $tunnel_ofport]) >> + AT_CHECK([test $(ovs-appctl ofproto/trace br-int in_port=vif$src >> $packet | grep "output:" | awk -F ':' '{ print $2 }') == $tunnel_ofport]) >> } >> >> for i in 1 2; do >> -- >> 2.43.0 >> >> >
On Tue, Jan 30, 2024 at 3:35 AM Dumitru Ceara <dceara@redhat.com> wrote: > > On 1/30/24 08:59, Ales Musil wrote: > > On Tue, Jan 30, 2024 at 8:58 AM Ales Musil <amusil@redhat.com> wrote: > > > >> The Fedora version of grep (grep (GNU grep) 3.11) complains > >> about the syntax grep "output\:": grep: warning: stray \ before : > >> > >> Remove the \ which works also for Ubuntu grep version > >> (grep (GNU grep) 3.7). > >> > >> > > I forgot to add the Fixes tag. > > > > Fixes: 17b6a12fa286 ("ovn-controller: Support VIF-based local encap IPs > > selection.") > > > > > >> Signed-off-by: Ales Musil <amusil@redhat.com> > >> --- > > Thanks, I added the "fixes" tag and a dot at the end of the commit > summary then pushed this to main. > > Regards, > Dumitru Thanks Ales and Dumitru for the fix. Han > > >> tests/ovn.at | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/tests/ovn.at b/tests/ovn.at > >> index 62966752f..cf87b9ad4 100644 > >> --- a/tests/ovn.at > >> +++ b/tests/ovn.at > >> @@ -30435,7 +30435,7 @@ check_packet_tunnel() { > >> as $hv > >> echo "vif$src -> vif$dst should go through tunnel $local_encap_ip -> > >> $remote_encap_ip" > >> tunnel_ofport=$(ovs-vsctl --bare --column=ofport find interface > >> options:local_ip=$local_encap_ip options:remote_ip=$remote_encap_ip) > >> - AT_CHECK([test $(ovs-appctl ofproto/trace br-int in_port=vif$src > >> $packet | grep "output\:" | awk -F ':' '{ print $2 }') == $tunnel_ofport]) > >> + AT_CHECK([test $(ovs-appctl ofproto/trace br-int in_port=vif$src > >> $packet | grep "output:" | awk -F ':' '{ print $2 }') == $tunnel_ofport]) > >> } > >> > >> for i in 1 2; do > >> -- > >> 2.43.0 > >> > >> > > >
diff --git a/tests/ovn.at b/tests/ovn.at index 62966752f..cf87b9ad4 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -30435,7 +30435,7 @@ check_packet_tunnel() { as $hv echo "vif$src -> vif$dst should go through tunnel $local_encap_ip -> $remote_encap_ip" tunnel_ofport=$(ovs-vsctl --bare --column=ofport find interface options:local_ip=$local_encap_ip options:remote_ip=$remote_encap_ip) - AT_CHECK([test $(ovs-appctl ofproto/trace br-int in_port=vif$src $packet | grep "output\:" | awk -F ':' '{ print $2 }') == $tunnel_ofport]) + AT_CHECK([test $(ovs-appctl ofproto/trace br-int in_port=vif$src $packet | grep "output:" | awk -F ':' '{ print $2 }') == $tunnel_ofport]) } for i in 1 2; do
The Fedora version of grep (grep (GNU grep) 3.11) complains about the syntax grep "output\:": grep: warning: stray \ before : Remove the \ which works also for Ubuntu grep version (grep (GNU grep) 3.7). Signed-off-by: Ales Musil <amusil@redhat.com> --- tests/ovn.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)