| Message ID | 20231115110634.41374-1-amusil@redhat.com |
|---|---|
| State | Accepted |
| Delegated to: | Dumitru Ceara |
| Headers | show |
| Series | [ovs-dev] controller: Disable inactivity probe for statctrl | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/github-robot-_ovn-kubernetes | success | github build: passed |
Thanks Ales for the patch. My patch was under review for a long period of time and there appeared a new OF connection :) Acked-by: Vladislav Odintsov <odivlad@gmail.com <mailto:odivlad@gmail.com>> > On 15 Nov 2023, at 14:06, Ales Musil <amusil@redhat.com> wrote: > > The inactivity probe was disabled for all connections > over unix socket [0]. However, the statctrl connection > wasn't updated by this patch. Remove the inactivity probe > from statctrl connection as well. > > [0] c16e5da80383 ("controller: disable OpenFlow inactivity probing") > Signed-off-by: Ales Musil <amusil@redhat.com> > --- > controller/statctrl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/controller/statctrl.c b/controller/statctrl.c > index cb1545cbb..8cce97df8 100644 > --- a/controller/statctrl.c > +++ b/controller/statctrl.c > @@ -233,7 +233,7 @@ statctrl_thread_handler(void *arg) > struct statctrl_ctx *ctx = arg; > > /* OpenFlow connection to the switch. */ > - struct rconn *swconn = rconn_create(5, 0, DSCP_DEFAULT, > + struct rconn *swconn = rconn_create(0, 0, DSCP_DEFAULT, > 1 << OFP15_VERSION); > > while (!latch_is_set(&ctx->exit_latch)) { > -- > 2.41.0 > Regards, Vladislav Odintsov
Thanks Ales, Acked-by: Mark Michelson <mmichels@redhat.com> On 11/15/23 06:06, Ales Musil wrote: > The inactivity probe was disabled for all connections > over unix socket [0]. However, the statctrl connection > wasn't updated by this patch. Remove the inactivity probe > from statctrl connection as well. > > [0] c16e5da80383 ("controller: disable OpenFlow inactivity probing") > Signed-off-by: Ales Musil <amusil@redhat.com> > --- > controller/statctrl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/controller/statctrl.c b/controller/statctrl.c > index cb1545cbb..8cce97df8 100644 > --- a/controller/statctrl.c > +++ b/controller/statctrl.c > @@ -233,7 +233,7 @@ statctrl_thread_handler(void *arg) > struct statctrl_ctx *ctx = arg; > > /* OpenFlow connection to the switch. */ > - struct rconn *swconn = rconn_create(5, 0, DSCP_DEFAULT, > + struct rconn *swconn = rconn_create(0, 0, DSCP_DEFAULT, > 1 << OFP15_VERSION); > > while (!latch_is_set(&ctx->exit_latch)) {
I merged this to main and branch-23.09. On 11/15/23 16:33, Mark Michelson wrote: > Thanks Ales, > > Acked-by: Mark Michelson <mmichels@redhat.com> > > On 11/15/23 06:06, Ales Musil wrote: >> The inactivity probe was disabled for all connections >> over unix socket [0]. However, the statctrl connection >> wasn't updated by this patch. Remove the inactivity probe >> from statctrl connection as well. >> >> [0] c16e5da80383 ("controller: disable OpenFlow inactivity probing") >> Signed-off-by: Ales Musil <amusil@redhat.com> >> --- >> controller/statctrl.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/controller/statctrl.c b/controller/statctrl.c >> index cb1545cbb..8cce97df8 100644 >> --- a/controller/statctrl.c >> +++ b/controller/statctrl.c >> @@ -233,7 +233,7 @@ statctrl_thread_handler(void *arg) >> struct statctrl_ctx *ctx = arg; >> /* OpenFlow connection to the switch. */ >> - struct rconn *swconn = rconn_create(5, 0, DSCP_DEFAULT, >> + struct rconn *swconn = rconn_create(0, 0, DSCP_DEFAULT, >> 1 << OFP15_VERSION); >> while (!latch_is_set(&ctx->exit_latch)) { >
diff --git a/controller/statctrl.c b/controller/statctrl.c index cb1545cbb..8cce97df8 100644 --- a/controller/statctrl.c +++ b/controller/statctrl.c @@ -233,7 +233,7 @@ statctrl_thread_handler(void *arg) struct statctrl_ctx *ctx = arg; /* OpenFlow connection to the switch. */ - struct rconn *swconn = rconn_create(5, 0, DSCP_DEFAULT, + struct rconn *swconn = rconn_create(0, 0, DSCP_DEFAULT, 1 << OFP15_VERSION); while (!latch_is_set(&ctx->exit_latch)) {
The inactivity probe was disabled for all connections over unix socket [0]. However, the statctrl connection wasn't updated by this patch. Remove the inactivity probe from statctrl connection as well. [0] c16e5da80383 ("controller: disable OpenFlow inactivity probing") Signed-off-by: Ales Musil <amusil@redhat.com> --- controller/statctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)