| Message ID | 20231004234930.2466-1-ihrachys@redhat.com |
|---|---|
| State | Accepted |
| Delegated to: | Dumitru Ceara |
| Headers | show |
| Series | [ovs-dev] Don't mention packet cloning when failing to find tunnel | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | fail | github build: failed |
| ovsrobot/github-robot-_ovn-kubernetes | fail | github build: failed |
On 10/5/23 01:49, Ihar Hrachyshka wrote: > Packet cloning is relevant to multichassis ports only, so the message > made no sense for single chassis ports with no additional_chassis. > > Even for multichassis ports, this part of the message is redundant and > confusing. It's better to remove it. > Fixes: 10398c1f51d5 ("Clone packets to all port chassis") > Signed-off-by: Ihar Hrachyshka <ihrachys@redhat.com> > --- Thanks, applied to main and backported to all branches down to 22.06. Regards, Dumitru
diff --git a/controller/physical.c b/controller/physical.c index 75257bc85..72e88a203 100644 --- a/controller/physical.c +++ b/controller/physical.c @@ -341,7 +341,7 @@ get_remote_tunnels(const struct sbrec_port_binding *binding, static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 1); VLOG_WARN_RL( &rl, "Failed to locate tunnel to reach main chassis %s " - "for port %s. Cloning packets disabled for the chassis.", + "for port %s.", binding->chassis->name, binding->logical_port); } else { struct tunnel *tun_elem = xmalloc(sizeof *tun_elem); @@ -363,7 +363,7 @@ get_remote_tunnels(const struct sbrec_port_binding *binding, static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 1); VLOG_WARN_RL( &rl, "Failed to locate tunnel to reach additional chassis %s " - "for port %s. Cloning packets disabled for the chassis.", + "for port %s.", binding->additional_chassis[i]->name, binding->logical_port); continue; }
Packet cloning is relevant to multichassis ports only, so the message made no sense for single chassis ports with no additional_chassis. Even for multichassis ports, this part of the message is redundant and confusing. It's better to remove it. Signed-off-by: Ihar Hrachyshka <ihrachys@redhat.com> --- controller/physical.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)