diff mbox series

[ovs-dev] docs: require ovn-set-local-ip for co-located ovn-controllers

Message ID 20230922154655.5571-1-ihrachys@redhat.com
State Accepted
Delegated to: Dumitru Ceara
Headers show
Series [ovs-dev] docs: require ovn-set-local-ip for co-located ovn-controllers | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_ovn-kubernetes fail github build: failed
ovsrobot/github-robot-_Build_and_Test success github build: passed

Commit Message

Ihar Hrachyshka Sept. 22, 2023, 3:46 p.m. UTC
Without using the setting, ovn-controllers will fail to create their
tunnel ports pointing to the same remote chassis due to identical
configuration used (same remote_ips and no different in local_ips).

The error observed then is:

```
2023-08-01T13:55:37.772Z|00050|tunnel|WARN|ovn-hv3-0: attempting to
add tunnel port with same config as port 'ovn0-hv3-0' (::->1.1.202.26,
key=flow, legacy_l2, dp port=3)
2023-08-01T13:55:37.772Z|00051|ofproto|WARN|br-hv1: could not add port
ovn-hv3-0 (File exists)
2023-08-01T13:55:37.772Z|00052|bridge|WARN|could not add network
device ovn-hv3-0 to ofproto (File exists)
```

Signed-off-by: Ihar Hrachyshka <ihrachys@redhat.com>
---
 controller/ovn-controller.8.xml | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

Comments

Dumitru Ceara Oct. 10, 2023, 1:35 p.m. UTC | #1
On 9/22/23 17:46, Ihar Hrachyshka wrote:
> Without using the setting, ovn-controllers will fail to create their
> tunnel ports pointing to the same remote chassis due to identical
> configuration used (same remote_ips and no different in local_ips).
> 
> The error observed then is:
> 
> ```
> 2023-08-01T13:55:37.772Z|00050|tunnel|WARN|ovn-hv3-0: attempting to
> add tunnel port with same config as port 'ovn0-hv3-0' (::->1.1.202.26,
> key=flow, legacy_l2, dp port=3)
> 2023-08-01T13:55:37.772Z|00051|ofproto|WARN|br-hv1: could not add port
> ovn-hv3-0 (File exists)
> 2023-08-01T13:55:37.772Z|00052|bridge|WARN|could not add network
> device ovn-hv3-0 to ofproto (File exists)
> ```
> 
> Signed-off-by: Ihar Hrachyshka <ihrachys@redhat.com>
> ---

Thanks for improving the documentation, Ihar!

Fixes: ce126c9a8210 ("Document experimental support for co-hosted controllers")

I applied this to main and backported it to all branches down to 23.03.

Regards,
Dumitru
diff mbox series

Patch

diff --git a/controller/ovn-controller.8.xml b/controller/ovn-controller.8.xml
index 7b4100592..0b9641045 100644
--- a/controller/ovn-controller.8.xml
+++ b/controller/ovn-controller.8.xml
@@ -363,7 +363,10 @@ 
         The boolean flag indicates if <code>ovn-controller</code> when create
         tunnel ports should set <code>local_ip</code> parameter.  Can be
         heplful to pin source outer IP for the tunnel when multiple interfaces
-        are used on the host for overlay traffic.
+        are used on the host for overlay traffic. This is also useful when
+        running multiple <code>ovn-controller</code> instances on the same
+        chassis, in which case this setting will guarantee that their tunnel
+        ports have unique configuration and can exist in parallel.
       </dd>
       <dt><code>external_ids:garp-max-timeout-sec</code></dt>
       <dd>
@@ -398,9 +401,11 @@ 
         names on the same host using the same <code>vswitchd</code> instance.
         This may be useful when running a hybrid setup with more than one CMS
         managing ports on the host, or to use different datapath types on the
-        same host. Note that this ability is highly experimental and has known
-        limitations (for example, stateful ACLs are not supported). Use at your
-        own risk.
+        same host. Make sure you also set
+        <code>external_ids:ovn-set-local-ip</code> when using such
+        configuration. Also note that this ability is highly experimental and
+        has known limitations (for example, stateful ACLs are not supported).
+        Use at your own risk.
     </p>
 
     <p>