| Message ID | 20230713152608.357832-1-dceara@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] tests: Remove accidental debug echo. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/github-robot-_ovn-kubernetes | success | github build: passed |
Reviewed-By: Ihar Hrachyshka <ihar@redhat.com> +1. Removing IHAR from OVN? Long overdue. :) On Thu, Jul 13, 2023 at 11:30 AM Dumitru Ceara <dceara@redhat.com> wrote: > Remove what seems to be an accidental test debug echo command. > > Fixes: ab7b0eb8ca05 ("Add connectivity test for 2 controllers on the same > host") > Signed-off-by: Dumitru Ceara <dceara@redhat.com> > --- > tests/ovn-macros.at | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tests/ovn-macros.at b/tests/ovn-macros.at > index 6f2d085ae4..30478140e9 100644 > --- a/tests/ovn-macros.at > +++ b/tests/ovn-macros.at > @@ -371,7 +371,6 @@ start_virtual_controller() { > -- set bridge $int_bridge fail-mode=secure > other-config:disable-in-band=true \ > || return 1 > > - echo IHAR ${cli_args} > ovn-controller --enable-dummy-vif-plug ${cli_args} -vconsole:off > --detach --no-chdir > } > > -- > 2.31.1 > >
On 7/13/23 18:01, Ihar Hrachyshka wrote: > Reviewed-By: Ihar Hrachyshka <ihar@redhat.com> > > +1. Removing IHAR from OVN? Long overdue. :) > I'm sure you know I didn't mean anything like that. I hope to see many more contributions from IHAR in the future! :D Thanks for the review, I pushed this to main and backported it to all branches down to 23.03. Regards, Dumitru > On Thu, Jul 13, 2023 at 11:30 AM Dumitru Ceara <dceara@redhat.com> wrote: > >> Remove what seems to be an accidental test debug echo command. >> >> Fixes: ab7b0eb8ca05 ("Add connectivity test for 2 controllers on the same >> host") >> Signed-off-by: Dumitru Ceara <dceara@redhat.com> >> --- >> tests/ovn-macros.at | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/tests/ovn-macros.at b/tests/ovn-macros.at >> index 6f2d085ae4..30478140e9 100644 >> --- a/tests/ovn-macros.at >> +++ b/tests/ovn-macros.at >> @@ -371,7 +371,6 @@ start_virtual_controller() { >> -- set bridge $int_bridge fail-mode=secure >> other-config:disable-in-band=true \ >> || return 1 >> >> - echo IHAR ${cli_args} >> ovn-controller --enable-dummy-vif-plug ${cli_args} -vconsole:off >> --detach --no-chdir >> } >> >> -- >> 2.31.1 >> >> >
diff --git a/tests/ovn-macros.at b/tests/ovn-macros.at index 6f2d085ae4..30478140e9 100644 --- a/tests/ovn-macros.at +++ b/tests/ovn-macros.at @@ -371,7 +371,6 @@ start_virtual_controller() { -- set bridge $int_bridge fail-mode=secure other-config:disable-in-band=true \ || return 1 - echo IHAR ${cli_args} ovn-controller --enable-dummy-vif-plug ${cli_args} -vconsole:off --detach --no-chdir }
Remove what seems to be an accidental test debug echo command. Fixes: ab7b0eb8ca05 ("Add connectivity test for 2 controllers on the same host") Signed-off-by: Dumitru Ceara <dceara@redhat.com> --- tests/ovn-macros.at | 1 - 1 file changed, 1 deletion(-)