| Message ID | 20230526113306.39212-1-amusil@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] ci: ovn-kubernetes: Align the timeouts with u/s ovnk | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/github-robot-_ovn-kubernetes | success | github build: passed |
On 5/26/23 13:33, Ales Musil wrote: > We saw a lot of failures recently due to jobs timing out. > Align the timeouts with upstream ovn-kubernetes. Hi Ales, Thanks for this! Nit: I'd point to the ovn-kubernetes commit (or permalink) where timeouts were increased. If this passes ovn-kubernetes tests in the robot run [0]: Acked-by: Dumitru Ceara <dceara@redhat.com> Regards, Dumitru [0] https://github.com/ovsrobot/ovn/actions/runs/5090383556 > > Signed-off-by: Ales Musil <amusil@redhat.com> > --- > .github/workflows/ovn-kubernetes.yml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/.github/workflows/ovn-kubernetes.yml b/.github/workflows/ovn-kubernetes.yml > index 8f0579527..b8cacf873 100644 > --- a/.github/workflows/ovn-kubernetes.yml > +++ b/.github/workflows/ovn-kubernetes.yml > @@ -56,7 +56,7 @@ jobs: > name: e2e > if: github.event_name != 'schedule' > runs-on: ubuntu-latest > - timeout-minutes: 120 > + timeout-minutes: 220 > strategy: > fail-fast: false > matrix: > @@ -137,6 +137,9 @@ jobs: > working-directory: src/github.com/ovn-org/ovn-kubernetes > > - name: Run Tests > + # e2e tests take ~60 minutes normally, 120 should be more than enough > + # set 180 for control-plane tests as these might take a while > + timeout-minutes: ${{ matrix.target == 'control-plane' && 180 || 120 }} > run: | > make -C test ${{ matrix.target }} > working-directory: src/github.com/ovn-org/ovn-kubernetes
On 5/26/23 13:46, Dumitru Ceara wrote: > On 5/26/23 13:33, Ales Musil wrote: >> We saw a lot of failures recently due to jobs timing out. >> Align the timeouts with upstream ovn-kubernetes. > > Hi Ales, > > Thanks for this! > > Nit: I'd point to the ovn-kubernetes commit (or permalink) where > timeouts were increased. > > If this passes ovn-kubernetes tests in the robot run [0]: > > Acked-by: Dumitru Ceara <dceara@redhat.com> It passed CI. I changed my ack into a signed-off-by and pushed the patch to the main branch and backported it to all branches down to 22.03. Regards, Dumitru > > Regards, > Dumitru > > [0] https://github.com/ovsrobot/ovn/actions/runs/5090383556 >
diff --git a/.github/workflows/ovn-kubernetes.yml b/.github/workflows/ovn-kubernetes.yml index 8f0579527..b8cacf873 100644 --- a/.github/workflows/ovn-kubernetes.yml +++ b/.github/workflows/ovn-kubernetes.yml @@ -56,7 +56,7 @@ jobs: name: e2e if: github.event_name != 'schedule' runs-on: ubuntu-latest - timeout-minutes: 120 + timeout-minutes: 220 strategy: fail-fast: false matrix: @@ -137,6 +137,9 @@ jobs: working-directory: src/github.com/ovn-org/ovn-kubernetes - name: Run Tests + # e2e tests take ~60 minutes normally, 120 should be more than enough + # set 180 for control-plane tests as these might take a while + timeout-minutes: ${{ matrix.target == 'control-plane' && 180 || 120 }} run: | make -C test ${{ matrix.target }} working-directory: src/github.com/ovn-org/ovn-kubernetes
We saw a lot of failures recently due to jobs timing out. Align the timeouts with upstream ovn-kubernetes. Signed-off-by: Ales Musil <amusil@redhat.com> --- .github/workflows/ovn-kubernetes.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)