From patchwork Mon May 22 21:18:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladislav Odintsov X-Patchwork-Id: 1784695 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::133; helo=smtp2.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20221208 header.b=H31TFlBr; dkim-atps=neutral Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4QQ9Kb3Wxcz20Pb for ; Tue, 23 May 2023 07:18:27 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 181184056F; Mon, 22 May 2023 21:18:25 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 181184056F Authentication-Results: smtp2.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20221208 header.b=H31TFlBr X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0esJOFLmUKKR; Mon, 22 May 2023 21:18:24 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTPS id 00261401B7; Mon, 22 May 2023 21:18:22 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 00261401B7 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id BC8C5C0035; Mon, 22 May 2023 21:18:22 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3593FC002A for ; Mon, 22 May 2023 21:18:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 1D557822CC for ; Mon, 22 May 2023 21:18:21 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 1D557822CC Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20221208 header.b=H31TFlBr X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qwCEQKOxCeB4 for ; Mon, 22 May 2023 21:18:20 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org D958782288 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by smtp1.osuosl.org (Postfix) with ESMTPS id D958782288 for ; Mon, 22 May 2023 21:18:19 +0000 (UTC) Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-2af2696fd1cso45127101fa.2 for ; Mon, 22 May 2023 14:18:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684790297; x=1687382297; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=BazDlW67GAA1S+fKjXs8jc7qOEdsOzwZIDM+e6bsLK8=; b=H31TFlBr+bO51nBj0x+egitdzE7R0CKQM2NmS6WL8dVsrKU8qbdm5BO0oBSSBSk6x7 7vT98bp4I3cGpJEdlS8TfvgIeG3kGe/fgyPpAIlPpaUKlYhN8sGC3PcquUlP3lbtg5M5 JjRh2TwEho3kKXSZZGeC/ukOv/gKKySrvzA5hVwfsf/MBSgSVPwOEBhRzn1F03/tkpsm ot29GLNx1WCWgKSooRA1ZfJnHJGc64HZtf33iXDv6D8vnDamzR9Brvo1o9yJvyjvGxPI peCEISD/w2hMGlMKEFA+7TUkBWFifpgJdYIgv4ngOjprnBuR3CIXMKhweh1MczwOVztB 00zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684790297; x=1687382297; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BazDlW67GAA1S+fKjXs8jc7qOEdsOzwZIDM+e6bsLK8=; b=cpM/cDlv8tWAmEVoju0d+LwXM6FvtKmh6qa+8W5ZMv26dx6S1mYHy3SeQhsyq7vNQl Vq2A6nF1xrmABGvjBGKAI9FCoaCTDNmF6X79JgIqy1Q4E8na2zE77R59NvmnS1TWvjrw +4L9tBiHRySQrcXGHGOymW3n0V46mBATP0HnmqmfxVyT1V2QCC4KXS4Bg7ixbhwTYHCM aK3WOFdV8X605yvrWFjpexCVGd+KLO1D6JXkbTH+l2fnqdBOf9FkzIosgCZUnbq6kNcv CbQqpr8srz0tYPMR0wQa52llLPwol4+yqJuBM68WLRWsx2+7dyoMLvORY0/6cAqnConQ RNWA== X-Gm-Message-State: AC+VfDy7+GwRWR/dQuxNXiWw2ih4M4dnknsy8Pp1pAowPeCfMaAjDahD Pq8SvVkrL1VVIVF4R+6ALwGuJ+KAUVrjDw== X-Google-Smtp-Source: ACHHUZ6kYExsgoThFxk24gREm4QJa8AE8VIrZ5GXw5gDdEDhahxConlxJd464TbNaHViOwCz8NLs1A== X-Received: by 2002:a2e:9008:0:b0:2a8:c8c5:c769 with SMTP id h8-20020a2e9008000000b002a8c8c5c769mr3826324ljg.36.1684790297116; Mon, 22 May 2023 14:18:17 -0700 (PDT) Received: from ip-10-70-112-12.vpc-1e810be1.internal (c2-178-216-98-9.elastic.cloud.croc.ru. [178.216.98.9]) by smtp.gmail.com with ESMTPSA id u18-20020ac25192000000b004eb3b675d43sm1103013lfi.302.2023.05.22.14.18.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 May 2023 14:18:16 -0700 (PDT) From: Vladislav Odintsov To: dev@openvswitch.org Date: Tue, 23 May 2023 00:18:15 +0300 Message-Id: <20230522211815.1201754-1-odivlad@gmail.com> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Cc: Vladislav Odintsov Subject: [ovs-dev] [PATCH ovn] controller: don't report UDP as unsupported proto in svc_check X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" Depending on the udp service, it can reply with some udp data. In that case ovn-controller will warn with next message: pinctrl(ovn_pinctrl0)|WARN|handle service check: Unsupported protocol - [11] With this patch ovn-controller ignores UDP packets, which came to pinctrl_handle_svc_check(). This is not something abnormal, so don't write warnings. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1913162 Signed-off-by: Vladislav Odintsov Acked-by: Ales Musil --- controller/pinctrl.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/controller/pinctrl.c b/controller/pinctrl.c index b4be22020..f2e753cdb 100644 --- a/controller/pinctrl.c +++ b/controller/pinctrl.c @@ -7777,6 +7777,13 @@ pinctrl_handle_svc_check(struct rconn *swconn, const struct flow *ip_flow, ip_proto = in_ip->ip6_nxt; } + if (ip_proto == IPPROTO_UDP) { + /* We should do nothing if we got UDP packet. + * If service is running, it can respond with any UDP data, + * so just ingore it. */ + return; + } + if (ip_proto != IPPROTO_TCP && ip_proto != IPPROTO_ICMP && ip_proto != IPPROTO_ICMPV6) { static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);