diff mbox series

[ovs-dev,04/14] ovn.at: Fix test case: delete mac bindings.

Message ID 20230513000356.2475960-5-hzhou@ovn.org
State Changes Requested
Headers show
Series ovn-northd incremental processing for VIF changes | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/github-robot-_ovn-kubernetes success github build: passed

Commit Message

Han Zhou May 13, 2023, 12:03 a.m. UTC
MAC_Binding table is to store neighbour cache for logical router
datapaths to resolve unknown IP addresses to MAC. The datapath field is
always logical router and the logical_port feild is always logical
router port. The test case used logical switch and logical switch ports
by mistake. Correct it to use logical router and logical router ports.

Signed-off-by: Han Zhou <hzhou@ovn.org>
---
 tests/ovn.at | 26 ++++++++++++--------------
 1 file changed, 12 insertions(+), 14 deletions(-)
diff mbox series

Patch

diff --git a/tests/ovn.at b/tests/ovn.at
index 2ba7c7ce52c0..ed5b10589194 100644
--- a/tests/ovn.at
+++ b/tests/ovn.at
@@ -9265,23 +9265,21 @@  sim_add hv1
 as hv1
 ovs-vsctl -- add-br br-phys
 ovn_attach n1 br-phys 192.168.0.1
-# Create logical switch ls0
-ovn-nbctl ls-add ls0
-# Create ports lp0, lp1 in ls0
-ovn-nbctl lsp-add ls0 lp0
-ovn-nbctl lsp-add ls0 lp1
-ovn-nbctl lsp-set-addresses lp0 "f0:00:00:00:00:01 192.168.0.1"
-ovn-nbctl lsp-set-addresses lp1 "f0:00:00:00:00:02 192.168.0.2"
+# Create logical router lr0
+ovn-nbctl lr-add lr0
+# Create ports lrp0, lrp1 in lr0
+ovn-nbctl lrp-add lr0 lrp0 f0:00:00:00:00:01 192.168.0.1/24
+ovn-nbctl lrp-add lr0 lrp1 f0:00:00:00:00:02 192.168.1.1/24
 dp_uuid=$(fetch_column Datapath_Binding _uuid)
-ovn-sbctl create MAC_Binding ip=10.0.0.1 datapath=$dp_uuid logical_port=lp0 mac="mac1"
-ovn-sbctl create MAC_Binding ip=10.0.0.1 datapath=$dp_uuid logical_port=lp1 mac="mac2"
+ovn-sbctl create MAC_Binding ip=10.0.0.1 datapath=$dp_uuid logical_port=lrp0 mac="mac1"
+ovn-sbctl create MAC_Binding ip=10.0.0.1 datapath=$dp_uuid logical_port=lrp1 mac="mac2"
 ovn-sbctl find MAC_Binding
-# Delete port lp0 and check that its MAC_Binding is deleted.
-ovn-nbctl lsp-del lp0
+# Delete port lrp0 and check that its MAC_Binding is deleted.
+ovn-nbctl lrp-del lrp0
 ovn-sbctl find MAC_Binding
-wait_row_count MAC_Binding 0 logical_port=lp0
-# Delete logical switch ls0 and check that its MAC_Binding is deleted.
-ovn-nbctl ls-del ls0
+wait_row_count MAC_Binding 0 logical_port=lrp0
+# Delete logical switch lr0 and check that its MAC_Binding is deleted.
+ovn-nbctl lr-del lr0
 ovn-sbctl find MAC_Binding
 wait_row_count MAC_Binding 0