diff mbox series

[ovs-dev] Typo fix in the ovn-nbctl man page.

Message ID 20230328134612.1930048-1-dceara@redhat.com
State Accepted
Headers show
Series [ovs-dev] Typo fix in the ovn-nbctl man page. | expand

Checks

Context Check Description
ovsrobot/apply-robot warning apply and check: warning
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/github-robot-_ovn-kubernetes success github build: passed

Commit Message

Dumitru Ceara March 28, 2023, 1:46 p.m. UTC 
From: Roberto Bartzen Acosta <rbartzen@gmail.com>

According to the ovn-nbctl man8 (NAT):
[--may-exist] [--stateless] [--gateway_port=GATEWAY_PORT]
lr-nat-add router type external_ip logical_ip [logical_port external_mac]

Result using man page syntax:
ovn-nbctl: unrecognized option '--gateway_port'

The option expected by the implementation is:
--gateway-port

Signed-off-by: Roberto Bartzen Acosta <rbartzen@gmail.com>
---
 utilities/ovn-nbctl.8.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

0-day Robot March 28, 2023, 1:57 p.m. UTC | #1 
Bleep bloop.  Greetings Dumitru Ceara, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Line is 275 characters long (recommended limit is 79)
#30 FILE: utilities/ovn-nbctl.8.xml:1154:
      <dt>[<code>--may-exist</code>] [<code>--stateless</code>] [<code>--gateway-port</code>=<var>GATEWAY_PORT</var>] <code>lr-nat-add</code> <var>router</var> <var>type</var> <var>external_ip</var> <var>logical_ip</var> [<var>logical_port</var> <var>external_mac</var>]</dt>

Lines checked: 37, Warnings: 1, Errors: 0


Please check this out.  If you feel there has been an error, please email aconole@redhat.com

Thanks,
0-day Robot
Dumitru Ceara March 28, 2023, 2 p.m. UTC | #2 
On 3/28/23 15:46, Dumitru Ceara wrote:
> From: Roberto Bartzen Acosta <rbartzen@gmail.com>
> 
> According to the ovn-nbctl man8 (NAT):
> [--may-exist] [--stateless] [--gateway_port=GATEWAY_PORT]
> lr-nat-add router type external_ip logical_ip [logical_port external_mac]
> 
> Result using man page syntax:
> ovn-nbctl: unrecognized option '--gateway_port'
> 
> The option expected by the implementation is:
> --gateway-port
> 
> Signed-off-by: Roberto Bartzen Acosta <rbartzen@gmail.com>
> ---

Submitted-at: https://github.com/ovn-org/ovn/pull/184

Thanks for the contribution, Roberto!

I applied this to the main branch and I added you to the authors list.

Regards,
Dumitru
diff mbox series

Patch

diff --git a/utilities/ovn-nbctl.8.xml b/utilities/ovn-nbctl.8.xml
index 72d4088f0c..54dbdb791e 100644
--- a/utilities/ovn-nbctl.8.xml
+++ b/utilities/ovn-nbctl.8.xml
@@ -1151,7 +1151,7 @@ 
     <h2>NAT Commands</h2>
 
     <dl>
-      <dt>[<code>--may-exist</code>] [<code>--stateless</code>] [<code>--gateway_port</code>=<var>GATEWAY_PORT</var>] <code>lr-nat-add</code> <var>router</var> <var>type</var> <var>external_ip</var> <var>logical_ip</var> [<var>logical_port</var> <var>external_mac</var>]</dt>
+      <dt>[<code>--may-exist</code>] [<code>--stateless</code>] [<code>--gateway-port</code>=<var>GATEWAY_PORT</var>] <code>lr-nat-add</code> <var>router</var> <var>type</var> <var>external_ip</var> <var>logical_ip</var> [<var>logical_port</var> <var>external_mac</var>]</dt>
       <dd>
         <p>
           Adds the specified NAT to <var>router</var>.