| Message ID | 20230309085015.751270-1-amusil@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] tests: Properly wait for chassis to added | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/github-robot-_ovn-kubernetes | success | github build: passed |
On 3/9/23 09:50, Ales Musil wrote: > Properly wait for chassis to be added before > getting the id. > > Signed-off-by: Ales Musil <amusil@redhat.com> > --- Thanks for the quick fix, Ales! Just so I don't forget, dropping this here: Fixes: a09852bfe631 ("chassis: Remove unsupported config option") Regards, Dumtiru > tests/ovn-controller.at | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/ovn-controller.at b/tests/ovn-controller.at > index 159e66461..597aed00b 100644 > --- a/tests/ovn-controller.at > +++ b/tests/ovn-controller.at > @@ -2540,6 +2540,7 @@ ovs-vsctl add-br br-phys > ovn_attach n1 br-phys 192.168.0.1 > > ovn-nbctl --wait=sb sync > +wait_row_count Chassis 1 name=hv1 > > chassis_id=$(fetch_column Chassis _uuid name=hv1) > check ovn-sbctl set chassis $chassis_id other_config:unsupported="value"
On 3/9/23 09:50, Ales Musil wrote: > Properly wait for chassis to be added before > getting the id. > > Signed-off-by: Ales Musil <amusil@redhat.com> > --- I guess you meant to title this "tests: Properly wait for chassis to be added". I changed the commit title and pushed it to the main branch. Thanks!
On 3/9/23 09:52, Dumitru Ceara wrote: > On 3/9/23 09:50, Ales Musil wrote: >> Properly wait for chassis to be added before >> getting the id. >> >> Signed-off-by: Ales Musil <amusil@redhat.com> >> --- > > Thanks for the quick fix, Ales! Just so I don't forget, dropping this here: > > Fixes: a09852bfe631 ("chassis: Remove unsupported config option") > I applied this to the main branch. Regards, Dumitru
diff --git a/tests/ovn-controller.at b/tests/ovn-controller.at index 159e66461..597aed00b 100644 --- a/tests/ovn-controller.at +++ b/tests/ovn-controller.at @@ -2540,6 +2540,7 @@ ovs-vsctl add-br br-phys ovn_attach n1 br-phys 192.168.0.1 ovn-nbctl --wait=sb sync +wait_row_count Chassis 1 name=hv1 chassis_id=$(fetch_column Chassis _uuid name=hv1) check ovn-sbctl set chassis $chassis_id other_config:unsupported="value"
Properly wait for chassis to be added before getting the id. Signed-off-by: Ales Musil <amusil@redhat.com> --- tests/ovn-controller.at | 1 + 1 file changed, 1 insertion(+)