diff mbox series

[ovs-dev,v4,3/7] system-tests: Do not use verbose output for ping6

Message ID 20230308143211.712618-4-amusil@redhat.com
State Accepted
Headers show
Series Enable system tests over userspace datapath in CI | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_ovn-kubernetes success github build: passed
ovsrobot/github-robot-_Build_and_Test fail github build: failed

Commit Message

Ales Musil March 8, 2023, 2:32 p.m. UTC
Newer versions of ping6 print some info to
stderr when specified with -v flag. This info
causes tests to fail. Do not use the verbose
output.

It reports following info into stderr
which is then represtend as error by the
NS_CHECK_EXEC:

ping6: sock4.fd: -1 (socktype: 0), sock6.fd: 3 (socktype: SOCK_RAW), hints.ai_family: AF_INET6

There is also possibility to ignore
the stderr, but it doesn't bring any value
to the test.

Signed-off-by: Ales Musil <amusil@redhat.com>
---
v3: Rebase on top of current main.
    Update commit message with reasoning why it fails.
v4: Rebase on top of current main.
---
 tests/system-ovn.at | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Simon Horman March 9, 2023, 1:11 p.m. UTC | #1
On Wed, Mar 08, 2023 at 03:32:07PM +0100, Ales Musil wrote:
> Newer versions of ping6 print some info to
> stderr when specified with -v flag. This info
> causes tests to fail. Do not use the verbose
> output.
> 
> It reports following info into stderr
> which is then represtend as error by the
> NS_CHECK_EXEC:
> 
> ping6: sock4.fd: -1 (socktype: 0), sock6.fd: 3 (socktype: SOCK_RAW), hints.ai_family: AF_INET6
> 
> There is also possibility to ignore
> the stderr, but it doesn't bring any value
> to the test.
> 
> Signed-off-by: Ales Musil <amusil@redhat.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>
diff mbox series

Patch

diff --git a/tests/system-ovn.at b/tests/system-ovn.at
index 501f9ad06..29734331b 100644
--- a/tests/system-ovn.at
+++ b/tests/system-ovn.at
@@ -285,7 +285,7 @@  ovn-nbctl --wait=hv sync
 OVS_WAIT_UNTIL([ovs-ofctl dump-flows br-int | grep 'nat(src=fd30::1)'])
 
 # 'alice1' should be able to ping 'foo1' directly.
-NS_CHECK_EXEC([alice1], [ping6 -v -q -c 3 -i 0.3 -w 2 fd11::2 | FORMAT_PING], \
+NS_CHECK_EXEC([alice1], [ping6 -q -c 3 -i 0.3 -w 2 fd11::2 | FORMAT_PING], \
 [0], [dnl
 3 packets transmitted, 3 received, 0% packet loss, time 0ms
 ])
@@ -8497,7 +8497,7 @@  NS_CHECK_EXEC([ls1p1], [ping -q -c 3 -i 0.3 -w 2  172.16.1.1 | FORMAT_PING], \
 3 packets transmitted, 3 received, 0% packet loss, time 0ms
 ])
 
-NS_CHECK_EXEC([ls1p1], [ping6 -v -q -c 3 -i 0.3 -w 2 1711::1  | FORMAT_PING], \
+NS_CHECK_EXEC([ls1p1], [ping6 -q -c 3 -i 0.3 -w 2 1711::1  | FORMAT_PING], \
 [0], [dnl
 3 packets transmitted, 3 received, 0% packet loss, time 0ms
 ])