| Message ID | 20230209100013.1006920-1-xsimonar@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] tests: Fix Flaky system-tests "omit connection tracking ..." | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/github-robot-_ovn-kubernetes | fail | github build: failed |
On Thu, Feb 9, 2023 at 11:00 AM Xavier Simonart <xsimonar@redhat.com> wrote: > While conntrack entries were flushed between the sub-tests, flows from > previous tests might still be present, causing conntrack entries to be > re-created. > > Fixes: a0f82efdd9df ("northd: bypass connection tracking for stateless > flows when there are LB flows present") > > Signed-off-by: Xavier Simonart <xsimonar@redhat.com> > --- > tests/system-ovn.at | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/system-ovn.at b/tests/system-ovn.at > index 2ece0f571..505c7f916 100644 > --- a/tests/system-ovn.at > +++ b/tests/system-ovn.at > @@ -9839,7 +9839,7 @@ ovn-nbctl ls-lb-del foo lb1 > > # add stateless acl > check ovn-nbctl acl-add foo from-lport 1 1 allow-stateless > -check ovn-nbctl acl-add foo to-lport 1 1 allow-stateless > +check ovn-nbctl --wait=hv acl-add foo to-lport 1 1 allow-stateless > > AT_CHECK([ip netns exec foo1 wget 192.168.2.2 -t 3 -T 1], [0], > [ignore], [ignore]) > > @@ -9984,7 +9984,7 @@ ovn-nbctl ls-lb-del foo lb1 > > # add stateless acl > check ovn-nbctl acl-add foo from-lport 1 1 allow-stateless > -check ovn-nbctl acl-add foo to-lport 1 1 allow-stateless > +check ovn-nbctl --wait=hv acl-add foo to-lport 1 1 allow-stateless > > AT_CHECK([ip netns exec foo1 wget http://[[fd12::2]] -t 3 -T 1], [0], > [ignore], [ignore]) > > -- > 2.31.1 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > Looks good to me, thanks. Acked-by: Ales Musil <amusil@redhat.com>
On 2/10/23 09:38, Ales Musil wrote: > On Thu, Feb 9, 2023 at 11:00 AM Xavier Simonart <xsimonar@redhat.com> wrote: > >> While conntrack entries were flushed between the sub-tests, flows from >> previous tests might still be present, causing conntrack entries to be >> re-created. >> >> Fixes: a0f82efdd9df ("northd: bypass connection tracking for stateless >> flows when there are LB flows present") >> >> Signed-off-by: Xavier Simonart <xsimonar@redhat.com> >> --- >> > Looks good to me, thanks. > > Acked-by: Ales Musil <amusil@redhat.com> > Thanks, Xavier and Ales! I applied this to the main branch. Regards, Dumitru
diff --git a/tests/system-ovn.at b/tests/system-ovn.at index 2ece0f571..505c7f916 100644 --- a/tests/system-ovn.at +++ b/tests/system-ovn.at @@ -9839,7 +9839,7 @@ ovn-nbctl ls-lb-del foo lb1 # add stateless acl check ovn-nbctl acl-add foo from-lport 1 1 allow-stateless -check ovn-nbctl acl-add foo to-lport 1 1 allow-stateless +check ovn-nbctl --wait=hv acl-add foo to-lport 1 1 allow-stateless AT_CHECK([ip netns exec foo1 wget 192.168.2.2 -t 3 -T 1], [0], [ignore], [ignore]) @@ -9984,7 +9984,7 @@ ovn-nbctl ls-lb-del foo lb1 # add stateless acl check ovn-nbctl acl-add foo from-lport 1 1 allow-stateless -check ovn-nbctl acl-add foo to-lport 1 1 allow-stateless +check ovn-nbctl --wait=hv acl-add foo to-lport 1 1 allow-stateless AT_CHECK([ip netns exec foo1 wget http://[[fd12::2]] -t 3 -T 1], [0], [ignore], [ignore])
While conntrack entries were flushed between the sub-tests, flows from previous tests might still be present, causing conntrack entries to be re-created. Fixes: a0f82efdd9df ("northd: bypass connection tracking for stateless flows when there are LB flows present") Signed-off-by: Xavier Simonart <xsimonar@redhat.com> --- tests/system-ovn.at | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)