diff mbox series

[ovs-dev,branch-22.09,3/3] tests: Fix flaky test "IPv6 Neighbor Solicitation for unknown MAC"

Message ID 20230131091047.184728-3-amusil@redhat.com
State Accepted
Headers show
Series [ovs-dev,branch-22.09,1/3] ovn-macros: support ipv6 in ovn_attach | expand

Checks

Context Check Description
ovsrobot/apply-robot warning apply and check: warning
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/github-robot-_ovn-kubernetes fail github build: failed

Commit Message

Ales Musil Jan. 31, 2023, 9:10 a.m. UTC 
From: Xavier Simonart <xsimonar@redhat.com>

Fixes: 9ac548524218 ("pinctrl: Send RARPs for external ipv6 interfaces")

Acked-by: Ales Musil <amusil@redhat.com>
Signed-off-by: Xavier Simonart <xsimonar@redhat.com>
Signed-off-by: Dumitru Ceara <dceara@redhat.com>
Signed-off-by: Ales Musil <amusil@redhat.com>
(cherry picked from commit f6edbc02)
---
 tests/ovn.at | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

0-day Robot Jan. 31, 2023, 9:18 a.m. UTC | #1 
Bleep bloop.  Greetings Ales Musil, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Dumitru Ceara <dceara@redhat.com>, Ales Musil <amusil@redhat.com>
Lines checked: 46, Warnings: 1, Errors: 0


Please check this out.  If you feel there has been an error, please email aconole@redhat.com

Thanks,
0-day Robot
diff mbox series

Patch

diff --git a/tests/ovn.at b/tests/ovn.at
index 9f8e8b8fc..eedc67fe7 100644
--- a/tests/ovn.at
+++ b/tests/ovn.at
@@ -13979,8 +13979,9 @@  AT_CHECK([cat 2.packets | cut -c 117-], [0], [expout])
 
 # Check that NS packets are not flooded across routing domains. That means
 # that hv2 should not send any packets across the physical network.
+# Use the grep here to filter out rarp packets that might have arrived
 $PYTHON "$ovs_srcdir/utilities/ovs-pcap.in" hv2/br-phys_n1-tx.pcap | \
-trim_zeros > 2.packets
+grep -v ffffffffffff | trim_zeros > 2.packets
 AT_CHECK([cat 2.packets], [0], [])
 
 # Now send a packet with destination ip other than
@@ -14020,8 +14021,9 @@  AT_CHECK([cat 2.packets | cut -c 117-], [0], [expout])
 
 # Check that NS packets are not flooded across routing domains. That means
 # that hv2 should not send any packets across the physical network.
+# Use the grep here to filter out rarp packets that might have arrived
 $PYTHON "$ovs_srcdir/utilities/ovs-pcap.in" hv2/br-phys_n1-tx.pcap | \
-trim_zeros > 2.packets
+grep -v ffffffffffff | trim_zeros > 2.packets
 AT_CHECK([cat 2.packets], [0], [])
 
 OVN_CLEANUP([hv1])