diff mbox series

[ovs-dev,v1,1/6] controller: fix recompute pflows if sampling changes

Message ID 20230124151632.695912-2-amorenoz@redhat.com
State Accepted
Headers show
Series drop sampling: Fixes and optimizations | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/github-robot-_ovn-kubernetes fail github build: failed

Commit Message

Adrian Moreno Jan. 24, 2023, 3:16 p.m. UTC 
From: Adrian Moreno <amorenoz@redhat.com>

The engine handler needs to return "false" in order to trigger a full
recompute of the physical flows.

Fixes: a42c808f30b4 ("northd: add drop sampling")
Signed-off-by: Adrian Moreno <amorenoz@redhat.com>
---
 controller/ovn-controller.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/controller/ovn-controller.c b/controller/ovn-controller.c
index 265740cab..f20972c76 100644
--- a/controller/ovn-controller.c
+++ b/controller/ovn-controller.c
@@ -3839,10 +3839,11 @@  pflow_output_sb_sb_global_handler(struct engine_node *node, void *data)
 
     if (pfo->debug.collector_set_id != collector_set_id ||
         pfo->debug.obs_domain_id != obs_domain_id) {
-        engine_set_node_state(node, EN_UPDATED);
         pfo->debug.collector_set_id = collector_set_id;
         pfo->debug.obs_domain_id = obs_domain_id;
+        return false;
     }
+    engine_set_node_state(node, EN_UPDATED);
     return true;
 }