diff mbox series

[ovs-dev,3/6] controller: add missing drop to loopback check table

Message ID 20221219161814.55422-4-amorenoz@redhat.com
State Superseded
Headers show
Series drop sampling: Fixes and optimizations | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/github-robot-_ovn-kubernetes fail github build: failed

Commit Message

Adrián Moreno Dec. 19, 2022, 4:18 p.m. UTC 
The drop was implicit (using empty actions). Make it explicit and
sampled.

Fixes: a42c808f30b4 ("northd: add drop sampling")
Signed-off-by: Adrian Moreno <amorenoz@redhat.com>
---
 controller/physical.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Mark Michelson Jan. 6, 2023, 7:15 p.m. UTC | #1 
Acked-by: Mark Michelson <mmichels@redhat.com>

On 12/19/22 11:18, Adrian Moreno wrote:
> The drop was implicit (using empty actions). Make it explicit and
> sampled.
> 
> Fixes: a42c808f30b4 ("northd: add drop sampling")
> Signed-off-by: Adrian Moreno <amorenoz@redhat.com>
> ---
>   controller/physical.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/controller/physical.c b/controller/physical.c
> index bda64741e..2444d3ebd 100644
> --- a/controller/physical.c
> +++ b/controller/physical.c
> @@ -1498,6 +1498,7 @@ consider_port_binding(struct ovsdb_idl_index *sbrec_port_binding_by_name,
>           if (!strcmp(binding->type, "localnet")) {
>               /* do not forward traffic from localport to localnet port */
>               ofpbuf_clear(ofpacts_p);
> +            put_drop(debug, OFTABLE_CHECK_LOOPBACK, ofpacts_p);
>               match_outport_dp_and_port_keys(&match, dp_key, port_key);
>               match_set_reg_masked(&match, MFF_LOG_FLAGS - MFF_REG0,
>                                    MLF_LOCALPORT, MLF_LOCALPORT);
diff mbox series

Patch

diff --git a/controller/physical.c b/controller/physical.c
index bda64741e..2444d3ebd 100644
--- a/controller/physical.c
+++ b/controller/physical.c
@@ -1498,6 +1498,7 @@  consider_port_binding(struct ovsdb_idl_index *sbrec_port_binding_by_name,
         if (!strcmp(binding->type, "localnet")) {
             /* do not forward traffic from localport to localnet port */
             ofpbuf_clear(ofpacts_p);
+            put_drop(debug, OFTABLE_CHECK_LOOPBACK, ofpacts_p);
             match_outport_dp_and_port_keys(&match, dp_key, port_key);
             match_set_reg_masked(&match, MFF_LOG_FLAGS - MFF_REG0,
                                  MLF_LOCALPORT, MLF_LOCALPORT);