diff mbox series

[ovs-dev,v2] CI: Update GH actions version

Message ID 20221125115043.425189-1-amusil@redhat.com
State Accepted
Headers show
Series [ovs-dev,v2] CI: Update GH actions version | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test fail github build: failed
ovsrobot/github-robot-_ovn-kubernetes fail github build: failed

Commit Message

Ales Musil Nov. 25, 2022, 11:50 a.m. UTC
As stated by the Github CI:
"Node.js 12 actions are deprecated. For more information see:
https://github.blog/changelog/2022-09-22-github-actions-all-
actions-will-begin-running-on-node16-instead-of-node12/.
Please update the following actions to use Node.js 16:
actions/checkout@v2, actions/setup-python@v2"

Signed-off-by: Ales Musil <amusil@redhat.com>
---
v2: Address comments from Dumitru.
---
 .github/workflows/ovn-kubernetes.yml | 14 +++++++-------
 .github/workflows/test.yml           | 24 ++++++++++++------------
 2 files changed, 19 insertions(+), 19 deletions(-)

Comments

Dumitru Ceara Nov. 28, 2022, 9:43 a.m. UTC | #1
On 11/25/22 12:50, Ales Musil wrote:
> As stated by the Github CI:
> "Node.js 12 actions are deprecated. For more information see:
> https://github.blog/changelog/2022-09-22-github-actions-all-
> actions-will-begin-running-on-node16-instead-of-node12/.
> Please update the following actions to use Node.js 16:
> actions/checkout@v2, actions/setup-python@v2"
> 
> Signed-off-by: Ales Musil <amusil@redhat.com>
> ---
> v2: Address comments from Dumitru.
> ---

Thanks!  I applied this to the main branch.

Regards,
Dumitru
diff mbox series

Patch

diff --git a/.github/workflows/ovn-kubernetes.yml b/.github/workflows/ovn-kubernetes.yml
index ba6b291ff..344937e53 100644
--- a/.github/workflows/ovn-kubernetes.yml
+++ b/.github/workflows/ovn-kubernetes.yml
@@ -30,7 +30,7 @@  jobs:
     runs-on: ubuntu-20.04
     steps:
     - name: Check out ovn
-      uses: actions/checkout@v2
+      uses: actions/checkout@v3
       with:
         submodules: recursive
 
@@ -42,7 +42,7 @@  jobs:
         mkdir /tmp/_output
         docker save ovn-daemonset-f:dev > /tmp/_output/image.tar
 
-    - uses: actions/upload-artifact@v2
+    - uses: actions/upload-artifact@v3
       with:
         name: test-image
         path: /tmp/_output/image.tar
@@ -86,13 +86,13 @@  jobs:
       run: sudo eatmydata apt-get remove --auto-remove -y aspnetcore-* dotnet-* libmono-* mono-* msbuild php-* php7* ghc-* zulu-*
 
     - name: Set up Go
-      uses: actions/setup-go@v2
+      uses: actions/setup-go@v3
       with:
         go-version: ${{ env.GO_VERSION }}
       id: go
 
     - name: Check out ovn-kubernetes
-      uses: actions/checkout@v2
+      uses: actions/checkout@v3
       with:
           path: src/github.com/ovn-org/ovn-kubernetes
           repository: ovn-org/ovn-kubernetes
@@ -109,7 +109,7 @@  jobs:
       run: |
         sudo ufw disable
 
-    - uses: actions/download-artifact@v2
+    - uses: actions/download-artifact@v3
       with:
         name: test-image
 
@@ -130,7 +130,7 @@  jobs:
 
     - name: Upload Junit Reports
       if: always()
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v3
       with:
         name: kind-junit-${{ env.JOB_NAME }}-${{ github.run_id }}
         path: 'src/github.com/ovn-org/ovn-kubernetes/test/_artifacts/*.xml'
@@ -144,7 +144,7 @@  jobs:
 
     - name: Upload logs
       if: always()
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v3
       with:
         name: kind-logs-${{ env.JOB_NAME }}-${{ github.run_id }}
         path: /tmp/kind/logs
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 88c48dd2c..f7ad08a57 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -58,20 +58,20 @@  jobs:
     steps:
     - name: checkout
       if: github.event_name == 'push' || github.event_name == 'pull_request'
-      uses: actions/checkout@v2
+      uses: actions/checkout@v3
       with:
         submodules: recursive
 
     # For weekly runs, don't update submodules
     - name: checkout without submodule
       if: github.event_name == 'schedule'
-      uses: actions/checkout@v2
+      uses: actions/checkout@v3
 
     # Weekly runs test using OVS master instead of the
     # submodule.
     - name: checkout OVS master
       if: github.event_name == 'schedule'
-      uses: actions/checkout@v2
+      uses: actions/checkout@v3
       with:
         repository: 'openvswitch/ovs'
         path: 'ovs'
@@ -100,7 +100,7 @@  jobs:
         echo "$HOME/.local/bin" >> $GITHUB_PATH
 
     - name: set up python
-      uses: actions/setup-python@v2
+      uses: actions/setup-python@v4
       with:
         python-version: '3.x'
 
@@ -113,9 +113,9 @@  jobs:
     - name: copy logs on failure
       if: failure() || cancelled()
       run: |
-        # upload-artifact@v2 throws exceptions if it tries to upload socket
+        # upload-artifact@v3 throws exceptions if it tries to upload socket
         # files and we could have some socket files in testsuite.dir.
-        # Also, upload-artifact@v2 doesn't work well enough with wildcards.
+        # Also, upload-artifact@v3 doesn't work well enough with wildcards.
         # So, we're just archiving everything here to avoid any issues.
         mkdir logs
         cp config.log ./logs/
@@ -127,7 +127,7 @@  jobs:
 
     - name: upload logs on failure
       if: failure() || cancelled()
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v3
       with:
         name: logs-linux-${{ join(matrix.cfg.*, '-') }}
         path: logs.tgz
@@ -146,18 +146,18 @@  jobs:
     steps:
     - name: checkout
       if: github.event_name == 'push' || github.event_name == 'pull_request'
-      uses: actions/checkout@v2
+      uses: actions/checkout@v3
       with:
         submodules: recursive
     # For weekly runs, don't update submodules
     - name: checkout without submodule
       if: github.event_name == 'schedule'
-      uses: actions/checkout@v2
+      uses: actions/checkout@v3
     # Weekly runs test using OVS master instead of the
     # submodule.
     - name: checkout OVS master
       if: github.event_name == 'schedule'
-      uses: actions/checkout@v2
+      uses: actions/checkout@v3
       with:
         repository: 'openvswitch/ovs'
         path: 'ovs'
@@ -169,7 +169,7 @@  jobs:
         echo "$HOME/bin"        >> $GITHUB_PATH
         echo "$HOME/.local/bin" >> $GITHUB_PATH
     - name: set up python
-      uses: actions/setup-python@v2
+      uses: actions/setup-python@v4
       with:
         python-version: '3.x'
     - name: prepare
@@ -178,7 +178,7 @@  jobs:
       run:  ./.ci/osx-build.sh
     - name: upload logs on failure
       if: failure()
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v3
       with:
         name: logs-osx-clang---disable-ssl
         path: config.log