Message ID | 20221121091657.192420-1-amusil@redhat.com |
---|---|
State | Superseded |
Headers | show |
Series | [ovs-dev] tests: Add missing filter for rARP | expand |
Context | Check | Description |
---|---|---|
ovsrobot/apply-robot | success | apply and check: success |
ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
ovsrobot/github-robot-_ovn-kubernetes | success | github build: passed |
Hi Ales Isn't it the same as second chunk of http://patchwork.ozlabs.org/project/ovn/patch/20221114105040.4070453-1-xsimonar@redhat.com/ Thanks Xavier On Mon, Nov 21, 2022 at 10:17 AM Ales Musil <amusil@redhat.com> wrote: > Add missing filter for rARP to prevent flakiness > of the test. > > Signed-off-by: Ales Musil <amusil@redhat.com> > --- > tests/ovn.at | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tests/ovn.at b/tests/ovn.at > index 6552681bd..7f0447363 100644 > --- a/tests/ovn.at > +++ b/tests/ovn.at > @@ -13995,8 +13995,10 @@ AT_CHECK([cat 2.packets | cut -c 117-], [0], > [expout]) > > # Check that NS packets are not flooded across routing domains. That means > # that hv2 should not send any packets across the physical network. > +# Use the grep here to filter out rarp packets that might have arrived > $PYTHON "$ovs_srcdir/utilities/ovs-pcap.in" hv2/br-phys_n1-tx.pcap | \ > -trim_zeros > 2.packets > +grep -v ffffffffffff | trim_zeros > 2.packets > + > AT_CHECK([cat 2.packets], [0], []) > > OVN_CLEANUP([hv1]) > -- > 2.38.1 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > >
Oops it is, my bad, ignore this one please. Thanks, Ales On Mon, Nov 21, 2022 at 12:08 PM Xavier Simonart <xsimonar@redhat.com> wrote: > Hi Ales > > Isn't it the same as second chunk of > http://patchwork.ozlabs.org/project/ovn/patch/20221114105040.4070453-1-xsimonar@redhat.com/ > Thanks > Xavier > > > > > On Mon, Nov 21, 2022 at 10:17 AM Ales Musil <amusil@redhat.com> wrote: > >> Add missing filter for rARP to prevent flakiness >> of the test. >> >> Signed-off-by: Ales Musil <amusil@redhat.com> >> --- >> tests/ovn.at | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/tests/ovn.at b/tests/ovn.at >> index 6552681bd..7f0447363 100644 >> --- a/tests/ovn.at >> +++ b/tests/ovn.at >> @@ -13995,8 +13995,10 @@ AT_CHECK([cat 2.packets | cut -c 117-], [0], >> [expout]) >> >> # Check that NS packets are not flooded across routing domains. That >> means >> # that hv2 should not send any packets across the physical network. >> +# Use the grep here to filter out rarp packets that might have arrived >> $PYTHON "$ovs_srcdir/utilities/ovs-pcap.in" hv2/br-phys_n1-tx.pcap | \ >> -trim_zeros > 2.packets >> +grep -v ffffffffffff | trim_zeros > 2.packets >> + >> AT_CHECK([cat 2.packets], [0], []) >> >> OVN_CLEANUP([hv1]) >> -- >> 2.38.1 >> >> _______________________________________________ >> dev mailing list >> dev@openvswitch.org >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev >> >>
diff --git a/tests/ovn.at b/tests/ovn.at index 6552681bd..7f0447363 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -13995,8 +13995,10 @@ AT_CHECK([cat 2.packets | cut -c 117-], [0], [expout]) # Check that NS packets are not flooded across routing domains. That means # that hv2 should not send any packets across the physical network. +# Use the grep here to filter out rarp packets that might have arrived $PYTHON "$ovs_srcdir/utilities/ovs-pcap.in" hv2/br-phys_n1-tx.pcap | \ -trim_zeros > 2.packets +grep -v ffffffffffff | trim_zeros > 2.packets + AT_CHECK([cat 2.packets], [0], []) OVN_CLEANUP([hv1])
Add missing filter for rARP to prevent flakiness of the test. Signed-off-by: Ales Musil <amusil@redhat.com> --- tests/ovn.at | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)