diff mbox series

[ovs-dev,branch-22.06,v2,7/8] northd: Increase the MAC binding removal delay

Message ID 20221104080342.248001-7-amusil@redhat.com
State Deferred
Headers show
Series [ovs-dev,branch-22.06,v2,1/8] northd, controller: Add timestamp column to MAC_Binding table | expand

Checks

Context Check Description
ovsrobot/apply-robot warning apply and check: warning
ovsrobot/github-robot-_Build_and_Test fail github build: failed
ovsrobot/github-robot-_ovn-kubernetes fail github build: failed

Commit Message

Ales Musil Nov. 4, 2022, 8:03 a.m. UTC 
Reported-at: https://bugzilla.redhat.com/2084668
Signed-off-by: Ales Musil <amusil@redhat.com>
Acked-by: Dumitru Ceara <dceara@redhat.com>
Signed-off-by: Mark Michelson <mmichels@redhat.com>
---
 northd/mac-binding-aging.c | 2 +-
 ovn-nb.xml                 | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

0-day Robot Nov. 4, 2022, 8:28 a.m. UTC | #1 
Bleep bloop.  Greetings Ales Musil, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Mark Michelson <mmichels@redhat.com>
Lines checked: 44, Warnings: 1, Errors: 0


Please check this out.  If you feel there has been an error, please email aconole@redhat.com

Thanks,
0-day Robot
diff mbox series

Patch

diff --git a/northd/mac-binding-aging.c b/northd/mac-binding-aging.c
index 4a2dfbbf8..0196a116b 100644
--- a/northd/mac-binding-aging.c
+++ b/northd/mac-binding-aging.c
@@ -28,7 +28,7 @@ 
 
 VLOG_DEFINE_THIS_MODULE(mac_binding_aging);
 
-#define MAC_BINDING_BULK_REMOVAL_DELAY_MSEC 10
+#define MAC_BINDING_BULK_REMOVAL_DELAY_MSEC 5000
 
 struct mac_binding_waker {
     bool should_schedule;
diff --git a/ovn-nb.xml b/ovn-nb.xml
index 2747b0a7d..8aa125093 100644
--- a/ovn-nb.xml
+++ b/ovn-nb.xml
@@ -167,7 +167,7 @@ 
         MAC binding aging bulk removal limit. This limits how many rows
         can expire in a single transaction. Default value is 0 which
         is unlimited. When we hit the limit next batch removal is delayed by
-        10 ms.
+        5 s.
       </column>
 
       <column name="options" key="controller_event" type='{"type": "boolean"}'>